Verified Commit 6817f476 authored by Dave Long's avatar Dave Long
Browse files

task: #3571886 Remove Ban from core 

By: mstrelan
By: andypost
By: quietone
By: smustgrave
By: longwave
parent 40419648

core/.deprecation-ignore.txt

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ 
%The "Drupal\\(?:Core\\(?:Action|Field|Condition)|(?:user|action_test|action_bulk_test|user_batch_action_test)\\Plugin\\Action)\\.*::execute\(\)" method will require a new "object\|null \$object" argument in the next major version of its interface "Drupal\\Core\\Executable\\ExecutableInterface"%

%.*::getDefaultOperations\(\) will require a new "\Drupal\Core\Cache\CacheableMetadata|null \$cacheability" argument in the next major version of its parent class%

%.*::getOperations\(\) will require a new "\Drupal\Core\Cache\CacheableMetadata|null \$cacheability" argument in the next major version of its interface%

%Class "Drupal\\migrate_drupal\\Plugin\\migrate\\source\\DrupalSqlBase" as extended by "Drupal\\(ban|block|block_content|comment|config_translation|contact|content_translation|field|file|filter|image|language|menu_link_content|migrate_drupal|node|path|responsive_image|search|shortcut|system|taxonomy|update|user)\\[^"]+" is deprecated in drupal:11.3.0 and is removed from drupal:12.0.0%

%Class "Drupal\\migrate_drupal\\Plugin\\migrate\\source\\DrupalSqlBase" as extended by "Drupal\\(block|block_content|comment|config_translation|contact|content_translation|field|file|filter|image|language|menu_link_content|migrate_drupal|node|path|responsive_image|search|shortcut|system|taxonomy|update|user)\\[^"]+" is deprecated in drupal:11.3.0 and is removed from drupal:12.0.0%

%Class "Drupal\\migrate_drupal\\Plugin\\migrate\\source\\DrupalSqlBase" as extended by "Drupal\\Tests\\migrate_drupal\\[^"]+" is deprecated in drupal:11.3.0 and is removed from drupal:12.0.0%

%Migrate source plugin "md_empty" used in migration "(d6_upload_field|user_picture_field)" is deprecated in drupal:11.3.0 and is removed from drupal:12.0.0%

%Trait "Drupal\\migrate_drupal\\Plugin\\migrate\\source\\I18nQueryTrait" used by "Drupal\\(block_content|menu_link_content|taxonomy)\\[^"]+" is deprecated in drupal:11.3.0 and is removed from drupal:12.0.0%

core/.phpstan-baseline.php

+0 −62
Original line number Diff line number Diff line
@@ -10633,68 +10633,6 @@ 
	'count' => 1,

	'path' => __DIR__ . '/lib/Drupal/Core/Validation/Plugin/Validation/Constraint/UniqueFieldValueValidator.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\ban\\\\BanIpManager\\:\\:banIp\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/ban/src/BanIpManager.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\ban\\\\BanIpManager\\:\\:unbanIp\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/ban/src/BanIpManager.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\ban\\\\BanIpManagerInterface\\:\\:banIp\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/ban/src/BanIpManagerInterface.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\ban\\\\BanIpManagerInterface\\:\\:unbanIp\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/ban/src/BanIpManagerInterface.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\ban\\\\Form\\\\BanAdmin\\:\\:create\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/ban/src/Form/BanAdmin.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\ban\\\\Form\\\\BanAdmin\\:\\:submitForm\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/ban/src/Form/BanAdmin.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\ban\\\\Form\\\\BanAdmin\\:\\:validateForm\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/ban/src/Form/BanAdmin.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\ban\\\\Form\\\\BanDelete\\:\\:create\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/ban/src/Form/BanDelete.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\ban\\\\Form\\\\BanDelete\\:\\:submitForm\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/ban/src/Form/BanDelete.php',

];

$ignoreErrors[] = [

	'message' => '#^Class Drupal\\\\ban\\\\Plugin\\\\migrate\\\\source\\\\d7\\\\BlockedIps extends deprecated class Drupal\\\\migrate_drupal\\\\Plugin\\\\migrate\\\\source\\\\DrupalSqlBase\\:

in drupal\\:11\\.3\\.0 and is removed from drupal\\:12\\.0\\.0\\. There is no

replacement\\.$#',

	'identifier' => 'class.extendsDeprecatedClass',

	'count' => 1,

	'path' => __DIR__ . '/modules/ban/src/Plugin/migrate/source/d7/BlockedIps.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\basic_auth_test\\\\BasicAuthTestController\\:\\:modifyState\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

core/MAINTAINERS.txt

+0 −3
Original line number Diff line number Diff line
@@ -84,9 +84,6 @@ Authentication and Authorization 
Automated Cron

- ?



Ban

- ?



Base system

- See "Framework managers" above.

core/lib/Drupal/Core/Config/ConfigImporter.php

+2 −2
Original line number Diff line number Diff line
@@ -413,7 +413,7 @@ protected function createExtensionChangelist() { 
    // @code

    // [

    //   'actions' => 0,

    //   'ban' => 0,

    //   'block' => 0,

    //   'options' => -2,

    //   'text' => -1,

    // ];
@@ -421,7 +421,7 @@ protected function createExtensionChangelist() { 
    // Will result in the following sort order:

    // 1. -2   options

    // 2. -1   text

    // 3.  0 0 ban

    // 3.  0 0 block

    // 4.  0 1 actions

    // @todo Move this sorting functionality to the extension system.

    array_multisort(array_values($module_list), SORT_ASC, array_keys($module_list), SORT_DESC, $module_list);

core/modules/ban/ban.info.yml

deleted100644 → 0
+0 −8
Original line number Diff line number Diff line 
name: Ban

type: module

description: 'Allows banning visits from specific IP addresses.'

package: Core

lifecycle: deprecated

lifecycle_link: https://www.drupal.org/node/3223395#s-ban

version: VERSION

configure: ban.admin_page