Verified Commit 6688407e authored by quietone's avatar quietone
Browse files

Issue #3556583 by mondrake, astonvictor: Remove remaining references to... 

Issue #3556583 by mondrake, astonvictor: Remove remaining references to @dataProvider annotations from tests

(cherry picked from commit 17d83a56)
parent b11f562b

core/tests/Drupal/FunctionalJavascriptTests/Core/Field/TimestampFormatterWithTimeDiffTest.php

+5 −4
Original line number Diff line number Diff line
@@ -96,8 +96,8 @@ protected function setUp(): void { 
  public function testTimestampFormatterWithTimeDiff(): void {

    $this->drupalGet($this->entity->toUrl());



    // Unit testing Drupal.timeDiff.format(). Not using @dataProvider mechanism

    // here in order to avoid installing the site for each case.

    // Unit testing Drupal.timeDiff.format(). Not using the data provider

    // mechanism here in order to avoid reinstalling the site for each case.

    foreach ($this->getFormatDiffTestCases() as $case) {

      $from = \DateTime::createFromFormat(\DateTimeInterface::RFC3339, $case['from'])->getTimestamp();

      $to = \DateTime::createFromFormat(\DateTimeInterface::RFC3339, $case['to'])->getTimestamp();
@@ -112,8 +112,9 @@ public function testTimestampFormatterWithTimeDiff(): void { 
      $this->assertJsCondition("Drupal.timeDiff.format($diff, $options).formatted === '$expected_formatted_value'");

    }



    // Unit testing Drupal.timeDiff.refreshInterval(). Not using @dataProvider

    // mechanism here in order to avoid reinstalling the site for each case.

    // Unit testing Drupal.timeDiff.refreshInterval(). Not using the data

    // provider mechanism here in order to avoid reinstalling the site for each

    // case.

    foreach ($this->getRefreshIntervalTestCases() as $case) {

      $interval = json_encode($case['time_diff']);

      $this->assertJsCondition("Drupal.timeDiff.refreshInterval($interval, {$case['configured_refresh_interval']}, {$case['granularity']}) === {$case['computed_refresh_interval']}");

core/tests/Drupal/Tests/Core/Asset/LibraryDiscoveryParserTest.php

+0 −6
Original line number Diff line number Diff line
@@ -734,12 +734,6 @@ public function testLibraryOverrideDeprecated(): void { 
    $this->libraryDiscoveryParser->buildByExtension('deprecated');

  }



  /**

   * Verifies assertions catch invalid CSS declarations.

   *

   * @dataProvider providerTestCssAssert

   */



  /**

   * Verify an assertion fails if CSS declarations have non-existent categories.

   *