Skip to content
Snippets Groups Projects
Verified Commit 653c5733 authored by Théodore Biadala's avatar Théodore Biadala
Browse files

Issue #3396099 by Utkarsh_33, nod_, Gauravvvv, bnjmnm, tedbow, smustgrave,...

Issue #3396099 by Utkarsh_33, nod_, Gauravvvv, bnjmnm, tedbow, smustgrave, Anybody, Rob230: The core/drupal.message library requires a status_messages render element

(cherry picked from commit bff71e54)
parent 429b5dc1
Branches
Tags
26 merge requests!10663Issue #3495778: Update phpdoc in FileSaveHtaccessLoggingTest,!10451Issue #3472458 by watergate, smustgrave: CKEditor 5 show blocks label is not translated,!103032838547 Fix punctuation rules for inline label suffix colon with CSS only,!10150Issue #3467294 by quietone, nod_, smustgrave, catch, longwave: Change string...,!10130Resolve #3480321 "Second level menu",!9936Issue #3483087: Check the module:// prefix in the translation server path and replace it with the actual module path,!9933Issue #3394728 by ankondrat4: Undefined array key "#prefix" and deprecated function: explode() in Drupal\file\Element\ManagedFile::uploadAjaxCallback(),!9914Issue #3451136 by quietone, gapple, ghost of drupal past: Improve...,!9882Draft: Issue #3481777 In bulk_form ensure the triggering element is the bulk_form button,!9839Issue #3445469 by pooja_sharma, smustgrave: Add additional test coverage for...,!9815Issue #3480025: There is no way to remove entity cache items,!9757Issue #3478869 Add "All" or overview links to parent links,!9752Issue #3439910 by pooja_sharma, vensires: Fix Toolbar tests that rely on UID1's super user behavior,!9749Issue #3439910 by pooja_sharma, vensires: Fix Toolbar tests that rely on UID1's super user behavior,!9678Issue #3465132 by catch, Spokje, nod_: Show test run time by class in run-tests.sh output,!9578Issue #3304746 by scott_euser, casey, smustgrave: BigPipe cannot handle (GET)...,!9449Issue #3344041: Allow textarea widgets to be used for text (formatted) fields,!8945🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥...,!8893Resolve #3444391 "Navigation center sm logo",!8772Issue #3445909 by seanB, smustgrave, alexpott, catch: Add static caching to...,!8723Make dblog entities,!8708Filter out disabled display extenders on save,!8691#3459116 - Update Manager Settings: Validate same email address added multiple times,!8665Issue #3449743 by catch: Try to optimize test ordering when run-tests.sh is...,!8598Draft: Issue #3458215: Migrate Toolbar button to SDC,!8572Reorder checkboxes on "Development settings" page
Pipeline #209377 passed with warnings
Pipeline: drupal

#209407

    Pipeline: drupal

    #209397

      Pipeline: drupal

      #209385

        ......@@ -37,13 +37,27 @@
        * The default destination for JavaScript messages.
        */
        static defaultWrapper() {
        let wrapper = document.querySelector('[data-drupal-messages]');
        // Search for the element with '[data-drupal-messages]' selector.
        // If not found then only try to search for fallback element.
        let wrapper =
        document.querySelector('[data-drupal-messages]') ||
        document.querySelector('[data-drupal-messages-fallback]');
        if (!wrapper) {
        wrapper = document.querySelector('[data-drupal-messages-fallback]');
        // If no status messages element is found, a fallback element is created to prevent
        // execution-breaking JS errors when attempting to report a problem.
        // This scenario can occur on any page that does not include a status_messages
        // render element.
        wrapper = document.createElement('div');
        document.body.appendChild(wrapper);
        }
        if (wrapper.hasAttribute('data-drupal-messages-fallback')) {
        // Remove the fallback attribute if it exists.
        wrapper.removeAttribute('data-drupal-messages-fallback');
        wrapper.setAttribute('data-drupal-messages', '');
        wrapper.classList.remove('hidden');
        }
        wrapper.setAttribute('data-drupal-messages', '');
        return wrapper.innerHTML === ''
        ? Drupal.Message.messageInternalWrapper(wrapper)
        : wrapper.firstElementChild;
        ......
        ......@@ -58,19 +58,6 @@ public function batchPage(Request $request) {
        return $output;
        }
        elseif (isset($output)) {
        // Directly render a status message placeholder without any messages.
        // Messages are not intended to be show on the batch page, but in the
        // event an error in a AJAX callback the messages will be displayed.
        // @todo Remove in https://drupal.org/i/3396099.
        $output['batch_messages'] = [
        '#theme' => 'status_messages',
        '#message_list' => [],
        '#status_headings' => [
        'status' => $this->t('Status message'),
        'error' => $this->t('Error message'),
        'warning' => $this->t('Warning message'),
        ],
        ];
        $title = $output['#title'] ?? NULL;
        $page = [
        '#type' => 'page',
        ......
        0% Loading or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Please register or to comment