Skip to content
Snippets Groups Projects
Commit 6316f212 authored by Scott Reeves's avatar Scott Reeves
Browse files

Issue #2655772 by Anishnirmal, andrewmacpherson, pbuyle, BarisW, mgifford,...

Issue #2655772 by Anishnirmal, andrewmacpherson, pbuyle, BarisW, mgifford, LaravZ: Remove unneeded role="button" attribute from <button> elements
parent ebac0ec1
No related branches found
No related tags found
2 merge requests!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!789Issue #3210310: Adjust Database API to remove deprecated Drupal 9 code in Drupal 10
...@@ -493,7 +493,7 @@ ...@@ -493,7 +493,7 @@
* A HTML string for the button to create a name for a new button group. * A HTML string for the button to create a name for a new button group.
*/ */
Drupal.theme.ckeditorNewButtonGroup = function () { Drupal.theme.ckeditorNewButtonGroup = function () {
return '<li class="ckeditor-add-new-group"><button role="button" aria-label="' + Drupal.t('Add a CKEditor button group to the end of this row.') + '">' + Drupal.t('Add group') + '</button></li>'; return '<li class="ckeditor-add-new-group"><button aria-label="' + Drupal.t('Add a CKEditor button group to the end of this row.') + '">' + Drupal.t('Add group') + '</button></li>';
}; };
})(jQuery, Drupal, drupalSettings, _); })(jQuery, Drupal, drupalSettings, _);
...@@ -35,7 +35,6 @@ function contextual_toolbar() { ...@@ -35,7 +35,6 @@ function contextual_toolbar() {
'#value' => t('Edit'), '#value' => t('Edit'),
'#attributes' => array( '#attributes' => array(
'class' => array('toolbar-icon', 'toolbar-icon-edit'), 'class' => array('toolbar-icon', 'toolbar-icon-edit'),
'role' => 'button',
'aria-pressed' => 'false', 'aria-pressed' => 'false',
), ),
), ),
......
...@@ -53,7 +53,6 @@ function tour_toolbar() { ...@@ -53,7 +53,6 @@ function tour_toolbar() {
'#value' => t('Tour'), '#value' => t('Tour'),
'#attributes' => array( '#attributes' => array(
'class' => array('toolbar-icon', 'toolbar-icon-help'), 'class' => array('toolbar-icon', 'toolbar-icon-help'),
'role' => 'button',
'aria-pressed' => 'false', 'aria-pressed' => 'false',
), ),
), ),
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment