Issue #3464271 by mondrake, smustgrave: Method getMockForAbstractClass() of...

Issue #3464271 by mondrake, smustgrave: Method getMockForAbstractClass() of class PHPUnit\Framework\TestCase is deprecated in PHPUnit 10 - replace in class ControllerBaseTest

(cherry picked from commit 5ac4f96a)

core/.phpstan-baseline.php

@@ -2581,12 +2581,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/tests/Drupal/Tests/Core/Config/Entity/ConfigEntityStorageTest.php',
 ];
-$ignoreErrors[] = [
-	// identifier: method.deprecated
-	'message' => '#^Call to deprecated method getMockForAbstractClass\\(\\) of class PHPUnit\\\\Framework\\\\TestCase\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/tests/Drupal/Tests/Core/Controller/ControllerBaseTest.php',
-];
 $ignoreErrors[] = [
 	// identifier: method.deprecated
 	'message' => '#^Call to deprecated method getMockForAbstractClass\\(\\) of class PHPUnit\\\\Framework\\\\MockObject\\\\MockBuilder\\.$#',

core/tests/Drupal/Tests/Core/Controller/ControllerBaseTest.php

@@ -15,10 +15,8 @@ class ControllerBaseTest extends UnitTestCase {
 
   /**
    * The tested controller base class.
-   *
-   * @var \Drupal\Core\Controller\ControllerBase|\PHPUnit\Framework\MockObject\MockObject
    */
-  protected $controllerBase;
+  protected StubControllerBase $controllerBase;
 
   /**
    * {@inheritdoc}
@@ -26,7 +24,7 @@ class ControllerBaseTest extends UnitTestCase {
   protected function setUp(): void {
     parent::setUp();
 
-    $this->controllerBase = $this->getMockForAbstractClass('Drupal\Core\Controller\ControllerBase');
+    $this->controllerBase = new StubControllerBase();
   }
 
   /**
@@ -49,7 +47,7 @@ public function testGetConfig(): void {
       ->willReturn($config_factory);
     \Drupal::setContainer($container);
 
-    $config_method = new \ReflectionMethod('Drupal\Core\Controller\ControllerBase', 'config');
+    $config_method = new \ReflectionMethod(StubControllerBase::class, 'config');
 
     // Call config twice to ensure that the container is just called once.
     $config = $config_method->invoke($this->controllerBase, 'config_name');

core/tests/Drupal/Tests/Core/Controller/StubControllerBase.php

+<?php
+
+declare(strict_types=1);
+
+namespace Drupal\Tests\Core\Controller;
+
+use Drupal\Core\Controller\ControllerBase;
+
+/**
+ * Stubs ControllerBase.
+ */
+class StubControllerBase extends ControllerBase {
+}