Verified Commit 5a47e624 authored by Dave Long's avatar Dave Long
Browse files

Issue #3136459 by ranjith_kumar_k_u, dishabhadra, Gauravvvv, priyanka.sahni,... 

Issue #3136459 by ranjith_kumar_k_u, dishabhadra, Gauravvvv, priyanka.sahni, smustgrave, sheldonreed3: Filter tips disappear when changing of text format is cancelled

(cherry picked from commit 44cc4df7)
parent 39f90b16

core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5AllowedTagsTest.php

+7 −0
Original line number Diff line number Diff line
@@ -454,6 +454,13 @@ public function testFullHtml() { 


    // Change the node's text format to Full HTML.

    $this->drupalGet('node/1/edit');

    $filter_tips = $page->find('css', '[data-drupal-format-id="basic_html"]');

    $this->assertTrue($filter_tips->isVisible());

    $page->selectFieldOption('body[0][format]', 'full_html');

    $this->assertNotEmpty($assert_session->waitForText('Change text format?'));

    // Check the visibility of "Filter tips" by clicking the "Cancel" button.

    $page->pressButton('Cancel');

    $this->assertTrue($filter_tips->isVisible());

    $page->selectFieldOption('body[0][format]', 'full_html');

    $this->assertNotEmpty($assert_session->waitForText('Change text format?'));

    $page->pressButton('Continue');

core/modules/editor/js/editor.js

+2 −0
Original line number Diff line number Diff line
@@ -157,6 +157,8 @@ 
              // change event is only triggered after the change has already

              // been accepted.

              select.value = activeFormatID;

              const eventChange = new Event('change');

              select.dispatchEvent(eventChange);

              confirmationDialog.close();

            },

          },