Commit 5996e3a4 authored by Ben Mullins's avatar Ben Mullins
Browse files

Issue #3276974 by hooroomoo, Wim Leers: [drupalMedia] Media View Modes don't...

Issue #3276974 by hooroomoo, Wim Leers: [drupalMedia] Media View Modes don't work if alignment not enabled
parent 953a69bf
Loading
Loading
Loading
Loading
+1 −0
Original line number Diff line number Diff line
@@ -630,6 +630,7 @@ media_media:
  ckeditor5:
    plugins:
      - drupalMedia.DrupalMedia
      - drupalMedia.DrupalElementStyle
    config:
      drupalMedia:
        toolbar: [mediaImageTextAlternative]
+0 −5
Original line number Diff line number Diff line
@@ -229,12 +229,7 @@ public function testAllowedMediaTypes() {
        ->setFilterConfig('media_embed', [
          'status' => TRUE,
          'settings' => [
            'default_view_mode' => 'view_mode_1',
            'allowed_media_types' => $allowed_media_types,
            'allowed_view_modes' => [
              'view_mode_1' => 'view_mode_1',
              'view_mode_2' => 'view_mode_2',
            ],
          ],
        ])->save();

+17 −1
Original line number Diff line number Diff line
@@ -1196,8 +1196,10 @@ function (ConstraintViolation $v) {
   * Tests that view mode is reflected onto the CKEditor 5 Widget wrapper, that
   * the media style toolbar allows changing the view mode and that the changes
   * are reflected on the widget and downcast drupal-media tag.
   *
   * @dataProvider providerTestViewMode
   */
  public function testViewMode() {
  public function testViewMode(bool $with_alignment) {
    EntityViewMode::create([
      'id' => 'media.view_mode_1',
      'targetEntityType' => 'media',
@@ -1263,6 +1265,10 @@ public function testViewMode() {
      ],
    ])->save();

    if (!$with_alignment) {
      $filter_format->filters('filter_align')->setConfiguration(array_merge($filter_format->filters('filter_align')->getConfiguration(), ['status' => FALSE]));
    }

    // Test that view mode dependencies are returned from the MediaEmbed
    // filter's ::getDependencies() method.
    $expected_config_dependencies = [
@@ -1478,6 +1484,16 @@ public function testViewMode() {
    $this->assertNotEmpty($this->getBalloonButton('View Mode 4'));
  }

  /**
   * For testing view modes in different scenarios.
   */
  public function providerTestViewMode(): array {
    return [
      'with alignment' => [TRUE],
      'without alignment' => [FALSE],
    ];
  }

  /**
   * Verifies value of an attribute on the downcast <drupal-media> element.
   *