Verified Commit 58be5f12 authored by Dave Long's avatar Dave Long
Browse files

Issue #3492235 by catch, longwave, mikelutz: Default container_rebuild_required to FALSE

parent 16967de8

core/includes/install.core.inc

+1 −4
Original line number Diff line number Diff line
@@ -1616,10 +1616,7 @@ function install_profile_modules(&$install_state) { 
  foreach (array_keys($required + $non_required) as $module) {

    // If the container needs to be rebuilt, ensure this happens both before and

    // after the module is installed.

    // @todo Consider reversing this logic so that modules must explicitly

    // state that they need a container build.

    // @see https://www.drupal.org/project/drupal/issues/3492235

    $container_rebuild_required = !isset($files[$module]->info['container_rebuild_required']) || $files[$module]->info['container_rebuild_required'];

    $container_rebuild_required = !empty($files[$module]->info['container_rebuild_required']);

    if ($container_rebuild_required && !empty($module_groups[$index])) {

      $index++;

    }

core/lib/Drupal/Core/Extension/ModuleInstaller.php

+1 −3
Original line number Diff line number Diff line
@@ -216,9 +216,7 @@ public function install(array $module_list, $enable_dependencies = TRUE) { 
    foreach ($module_list as $module) {

      // Ensure the container is rebuilt both before and after a module that

      // requires a container rebuild is installed.

      // @todo Consider reversing the behavior when the info key is not set.

      // See https://www.drupal.org/project/drupal/issues/3492235

      $container_rebuild_required = !isset($module_data[$module]->info['container_rebuild_required']) || $module_data[$module]->info['container_rebuild_required'];

      $container_rebuild_required = !empty($module_data[$module]->info['container_rebuild_required']);

      if ($container_rebuild_required && !empty($module_groups[$index])) {

        $index++;

      }

core/modules/announcements_feed/announcements_feed.info.yml

+0 −1
Original line number Diff line number Diff line
@@ -2,5 +2,4 @@ name: Announcements 
type: module

description: Displays announcements from the Drupal community.

version: VERSION

container_rebuild_required: false

package: Core

core/modules/automated_cron/automated_cron.info.yml

+0 −1
Original line number Diff line number Diff line
@@ -3,5 +3,4 @@ type: module 
description: 'Provides an automated way to run cron jobs, by executing them at the end of a server response.'

package: Core

version: VERSION

container_rebuild_required: false

configure: system.cron_settings

core/modules/ban/ban.info.yml

+0 −1
Original line number Diff line number Diff line
@@ -3,5 +3,4 @@ type: module 
description: 'Allows banning visits from specific IP addresses.'

package: Core

version: VERSION

container_rebuild_required: false

configure: ban.admin_page