Verified Commit 580555e0 authored by Jess's avatar Jess
Browse files

Issue #3327018 by Spokje, longwave, xjm: Update PHPStan to 1.9.3 and make... 

Issue #3327018 by Spokje, longwave, xjm: Update PHPStan to 1.9.3 and make daily "updated deps" QA jobs pass
parent 354f9520

composer.lock

+6 −6
Original line number Diff line number Diff line
@@ -5860,16 +5860,16 @@ 
        },

        {

            "name": "phpstan/phpstan",

            "version": "1.9.2",

            "version": "1.9.3",

            "source": {

                "type": "git",

                "url": "https://github.com/phpstan/phpstan.git",

                "reference": "d6fdf01c53978b6429f1393ba4afeca39cc68afa"

                "reference": "709999b91448d4f2bb07daffffedc889b33e461c"

            },

            "dist": {

                "type": "zip",

                "url": "https://api.github.com/repos/phpstan/phpstan/zipball/d6fdf01c53978b6429f1393ba4afeca39cc68afa",

                "reference": "d6fdf01c53978b6429f1393ba4afeca39cc68afa",

                "url": "https://api.github.com/repos/phpstan/phpstan/zipball/709999b91448d4f2bb07daffffedc889b33e461c",

                "reference": "709999b91448d4f2bb07daffffedc889b33e461c",

                "shasum": ""

            },

            "require": {
@@ -5899,7 +5899,7 @@ 
            ],

            "support": {

                "issues": "https://github.com/phpstan/phpstan/issues",

                "source": "https://github.com/phpstan/phpstan/tree/1.9.2"

                "source": "https://github.com/phpstan/phpstan/tree/1.9.3"

            },

            "funding": [

                {
@@ -5915,7 +5915,7 @@ 
                    "type": "tidelift"

                }

            ],

            "time": "2022-11-10T09:56:11+00:00"

            "time": "2022-12-13T10:28:10+00:00"

        },

        {

            "name": "phpunit/php-code-coverage",

composer/Metapackage/PinnedDevDependencies/composer.json

+1 −1
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ 
        "phpspec/prophecy-phpunit": "v2.0.1",

        "phpstan/extension-installer": "1.2.0",

        "phpstan/phpdoc-parser": "1.13.1",

        "phpstan/phpstan": "1.9.2",

        "phpstan/phpstan": "1.9.3",

        "phpunit/php-code-coverage": "9.2.19",

        "phpunit/php-file-iterator": "3.0.6",

        "phpunit/php-invoker": "3.1.1",

core/phpstan-baseline.neon

+16 −61
Original line number Diff line number Diff line
@@ -330,16 +330,6 @@ parameters: 
			count: 1

			path: lib/Drupal/Core/Database/Query/Upsert.php



		-

			message: "#^Variable \\$query_start might not be defined\\.$#"

			count: 2

			path: lib/Drupal/Core/Database/StatementPrefetch.php



		-

			message: "#^Variable \\$query_start might not be defined\\.$#"

			count: 2

			path: lib/Drupal/Core/Database/StatementWrapper.php



		-

			message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#"

			count: 2
@@ -432,7 +422,7 @@ parameters: 


		-

			message: "#^Variable \\$selected_bundles might not be defined\\.$#"

			count: 3

			count: 2

			path: lib/Drupal/Core/Entity/Plugin/EntityReferenceSelection/DefaultSelection.php



		-
@@ -660,16 +650,6 @@ parameters: 
			count: 1

			path: lib/Drupal/Core/Menu/MenuLinkManager.php



		-

			message: "#^Variable \\$fields might not be defined\\.$#"

			count: 3

			path: lib/Drupal/Core/Menu/MenuTreeStorage.php



		-

			message: "#^Variable \\$root might not be defined\\.$#"

			count: 1

			path: lib/Drupal/Core/Menu/MenuTreeStorage.php



		-

			message: "#^Variable \\$transaction in isset\\(\\) always exists and is not nullable\\.$#"

			count: 1
@@ -710,11 +690,6 @@ parameters: 
			count: 1

			path: lib/Drupal/Core/Render/Renderer.php



		-

			message: "#^Variable \\$render_start might not be defined\\.$#"

			count: 1

			path: lib/Drupal/Core/Render/Renderer.php



		-

			message: "#^Variable \\$transaction in isset\\(\\) always exists and is not nullable\\.$#"

			count: 1
@@ -730,11 +705,6 @@ parameters: 
			count: 1

			path: lib/Drupal/Core/Session/SessionManager.php



		-

			message: "#^Variable \\$session_data might not be defined\\.$#"

			count: 1

			path: lib/Drupal/Core/Session/SessionManager.php



		-

			message: "#^Method Drupal\\\\Core\\\\Template\\\\AttributeValueBase\\:\\:render\\(\\) should return string but return statement is missing\\.$#"

			count: 1
@@ -1660,11 +1630,6 @@ parameters: 
			count: 1

			path: modules/migrate/src/Plugin/migrate/destination/EntityConfigBase.php



		-

			message: "#^Variable \\$id_keys might not be defined\\.$#"

			count: 1

			path: modules/migrate/src/Plugin/migrate/destination/EntityConfigBase.php



		-

			message: "#^Method Drupal\\\\migrate\\\\Plugin\\\\migrate\\\\destination\\\\NullDestination\\:\\:import\\(\\) should return array\\|bool but return statement is missing\\.$#"

			count: 1
@@ -1980,11 +1945,6 @@ parameters: 
			count: 1

			path: modules/search/search.module



		-

			message: "#^Variable \\$keys might not be defined\\.$#"

			count: 1

			path: modules/search/src/Controller/SearchController.php



		-

			message: "#^Method Drupal\\\\search\\\\Form\\\\SearchPageAddForm\\:\\:save\\(\\) should return int but return statement is missing\\.$#"

			count: 1
@@ -2090,11 +2050,6 @@ parameters: 
			count: 1

			path: modules/system/src/Form/ThemeSettingsForm.php



		-

			message: "#^Variable \\$features might not be defined\\.$#"

			count: 3

			path: modules/system/src/Form/ThemeSettingsForm.php



		-

			message: "#^Variable \\$theme_settings in isset\\(\\) always exists and is not nullable\\.$#"

			count: 1
@@ -2290,11 +2245,6 @@ parameters: 
			count: 4

			path: modules/taxonomy/tests/src/Kernel/TermKernelTest.php



		-

			message: "#^Variable \\$filters might not be defined\\.$#"

			count: 1

			path: modules/text/text.module



		-

			message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#"

			count: 1
@@ -2625,11 +2575,6 @@ parameters: 
			count: 1

			path: modules/views/src/Plugin/views/filter/InOperator.php



		-

			message: "#^Variable \\$identifier might not be defined\\.$#"

			count: 4

			path: modules/views/src/Plugin/views/filter/NumericFilter.php



		-

			message: "#^Variable \\$source might not be defined\\.$#"

			count: 2
@@ -2786,14 +2731,24 @@ parameters: 
			path: modules/views/tests/src/Kernel/Handler/FieldFieldTest.php



		-

			message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#"

			message: "#^Variable \\$rand1 might not be defined\\.$#"

			count: 2

			path: modules/views/tests/src/Kernel/RenderCacheIntegrationTest.php

			path: modules/views/tests/src/Kernel/Plugin/StyleTest.php



		-

			message: "#^Variable \\$entity_revision_data_table might not be defined\\.$#"

			count: 1

			path: modules/views/views.views.inc

			message: "#^Variable \\$rand2 might not be defined\\.$#"

			count: 2

			path: modules/views/tests/src/Kernel/Plugin/StyleTest.php



		-

			message: "#^Variable \\$rand3 might not be defined\\.$#"

			count: 2

			path: modules/views/tests/src/Kernel/Plugin/StyleTest.php



		-

			message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#"

			count: 2

			path: modules/views/tests/src/Kernel/RenderCacheIntegrationTest.php



		-

			message: "#^Variable \\$relationship_handler in empty\\(\\) always exists and is not falsy\\.$#"