Verified Commit 54d8b195 authored by Lee Rowlands's avatar Lee Rowlands
Browse files

Issue #3180696 by Spokje, Nikolay Shapovalov, adamzimmermann, quietone,... 

Issue #3180696 by Spokje, Nikolay Shapovalov, adamzimmermann, quietone, manish-31, xjm, SuperfluousApostrophe, smustgrave, jonathan1055, longwave: Fix 'Drupal.Commenting.TodoComment' coding standard

(cherry picked from commit df2dfa91)
parent 3552c87a

core/includes/install.core.inc

+1 −1
Original line number Diff line number Diff line
@@ -1941,7 +1941,7 @@ function install_check_translations($langcode, $server_pattern) { 


  $readable = FALSE;

  $writable = FALSE;

  // @todo: Make this configurable.

  // @todo Make this configurable.

  $site_path = \Drupal::getContainer()->getParameter('site.path');

  $files_directory = $site_path . '/files';

  $translations_directory = $site_path . '/files/translations';

core/includes/update.inc

+3 −3
Original line number Diff line number Diff line
@@ -65,7 +65,7 @@ function update_check_requirements() { 
 * system would detect and attempt to run all historical updates for a

 * module.

 *

 * @todo: remove in a major version after

 * @todo remove in a major version after

 * https://www.drupal.org/project/drupal/issues/3130037 has been fixed.

 */

function _update_fix_missing_schema() {
@@ -171,7 +171,7 @@ function update_do_one($module, $number, $dependency_map, &$context) { 
      $ret['results']['query'] = $function($context['sandbox']);

      $ret['results']['success'] = TRUE;

    }

    // @TODO We may want to do different error handling for different

    // @todo We may want to do different error handling for different

    // exception types, but for now we'll just log the exception and

    // return the message for printing.

    // @see https://www.drupal.org/node/2564311
@@ -240,7 +240,7 @@ function update_invoke_post_update($function, &$context) { 
        \Drupal::service('update.post_update_registry')->registerInvokedUpdates([$function]);

      }

    }

    // @TODO We may want to do different error handling for different exception

    // @todo We may want to do different error handling for different exception

    // types, but for now we'll just log the exception and return the message

    // for printing.

    // @see https://www.drupal.org/node/2564311

core/lib/Drupal/Component/Gettext/PoItem.php

+1 −1
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ 
/**

 * PoItem handles one translation.

 *

 * @todo: This class contains some really old legacy code.

 * @todo This class contains some really old legacy code.

 * @see https://www.drupal.org/node/1637662

 */

class PoItem {

core/lib/Drupal/Core/Asset/AssetResolver.php

+1 −1
Original line number Diff line number Diff line
@@ -107,7 +107,7 @@ protected function getLibrariesToLoad(AttachedAssetsInterface $assets) { 
    // representative set before then expanding the list to include all

    // dependencies.

    // @see Drupal\FunctionalTests\Core\Asset\AssetOptimizationTestUmami

    // @todo: https://www.drupal.org/project/drupal/issues/1945262

    // @todo https://www.drupal.org/project/drupal/issues/1945262

    $libraries = $assets->getLibraries();

    if ($libraries) {

      $libraries = $this->libraryDependencyResolver->getMinimalRepresentativeSubset($libraries);

core/lib/Drupal/Core/Config/Schema/Sequence.php

+1 −1
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ class Sequence extends ArrayElement { 
   */

  protected function getElementDefinition($key) {

    $value = $this->value[$key] ?? NULL;

    // @todo: Remove BC layer for sequence with hyphen in front. https://www.drupal.org/node/2444979

    // @todo Remove BC layer for sequence with hyphen in front. https://www.drupal.org/node/2444979

    $definition = [];

    if (isset($this->definition['sequence'][0])) {

      $definition = $this->definition['sequence'][0];