Commit 50ea22de authored Dec 16, 2020 by catch

Issue #3187433 by alexpott, quietone, Pooja Ganjage, huzooka, daffie:...

Issue #3187433 by alexpott, quietone, Pooja Ganjage, huzooka, daffie: Eliminate parent::prepareRow() calls with ignored return value from all migrate source plugins

(cherry picked from commit 8a57d1e8)

parent 34516495

core/modules/action/src/Plugin/migrate/source/Action.php

+1 −0

Original line number	Diff line number	Diff line
		@@ -64,6 +64,7 @@ public function prepareRow(Row $row) {
		}
		$row->setSourceProperty('aid', $label);
		}
		return parent::prepareRow($row);
		}

		}

core/modules/block_content/src/Plugin/migrate/source/d7/BlockCustomTranslation.php

+3 −1

Original line number	Diff line number	Diff line
		@@ -56,7 +56,9 @@ public function query() {
		* {@inheritdoc}
		*/
		public function prepareRow(Row $row) {
		parent::prepareRow($row);
		if (!parent::prepareRow($row)) {
		return FALSE;
		}
		// Set the i18n string table for use in I18nQueryTrait.
		$this->i18nStringTable = static::I18N_STRING_TABLE;
		// Save the translation for this property.

core/modules/menu_link_content/src/Plugin/migrate/source/d6/MenuLinkTranslation.php

+3 −1

Original line number	Diff line number	Diff line
		@@ -55,7 +55,9 @@ public function query() {
		* {@inheritdoc}
		*/
		public function prepareRow(Row $row) {
		parent::prepareRow($row);
		if (!parent::prepareRow($row)) {
		return FALSE;
		}

		// Save the translation for this property.
		$property_in_row = $row->getSourceProperty('property');

core/modules/menu_link_content/src/Plugin/migrate/source/d7/MenuLinkTranslation.php

+3 −1

Original line number	Diff line number	Diff line
		@@ -44,7 +44,9 @@ public function query() {
		* {@inheritdoc}
		*/
		public function prepareRow(Row $row) {
		parent::prepareRow($row);
		if (!parent::prepareRow($row)) {
		return FALSE;
		}

		// Put the language on the row as 'language'.
		$row->setSourceProperty('language', $row->getSourceProperty('lt_language'));

core/modules/migrate/tests/modules/migrate_skip_all_rows_test/migrate_skip_all_rows_test.info.yml

0 → 100644

+5 −0

Original line number	Diff line number	Diff line
		name: 'Migrate module prepareRow tests'
		type: module
		description: 'Support module for source plugin prepareRow testing.'
		package: Testing
		version: VERSION