Issue #3490954 by nexusnovaz, mstrelan: Add return types to hook_update_N implementations (4e64f397) · Commits · project / drupal

core/.phpstan-baseline.php

+0 −120

Original line number	Diff line number	Diff line
		@@ -25180,12 +25180,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/locale/locale.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function locale_update_10300\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/locale/locale.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function _locale_parse_js_file\$\$ has no return type specified\\.$#',
		@@ -37790,30 +37784,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/entity_test/tests/src/Functional/Rest/EntityTestXmlCookieTest.php',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function entity_test_update_8001\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/entity_test/update/entity_definition_updates_8001.inc',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function entity_test_update_8002\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/entity_test/update/entity_definition_updates_8002.inc',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function entity_test_update_8001\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/entity_test/update/status_report_8001.inc',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function entity_test_update_8002\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/entity_test/update/status_report_8002.inc',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Method Drupal\\\\entity_test_bundle_class\\\\Entity\\\\EntityTestBundleClass\\:\\:postCreate\$\$ has no return type specified\\.$#',
		@@ -37940,72 +37910,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/entity_test_update/src/Hook/EntityTestUpdateHooks.php',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function equivalent_update_test_update_100000\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/equivalent_update_test/equivalent_update_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function equivalent_update_test_update_100001\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/equivalent_update_test/equivalent_update_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function equivalent_update_test_update_100002\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/equivalent_update_test/equivalent_update_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function equivalent_update_test_update_100101\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/equivalent_update_test/equivalent_update_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function equivalent_update_test_update_100201\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/equivalent_update_test/equivalent_update_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function equivalent_update_test_update_100301\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/equivalent_update_test/equivalent_update_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function equivalent_update_test_update_100302\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/equivalent_update_test/equivalent_update_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function equivalent_update_test_update_100400\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/equivalent_update_test/equivalent_update_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function equivalent_update_test_update_100401\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/equivalent_update_test/equivalent_update_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function equivalent_update_test_update_100402\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/equivalent_update_test/equivalent_update_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function equivalent_update_test_update_100501\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/equivalent_update_test/equivalent_update_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Method Drupal\\\\error_service_test\\\\Controller\\\\LonelyMonkeyController\\:\\:testBrokenClass\$\$ has no return type specified\\.$#',
		@@ -38904,12 +38808,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/module_test/src/PluginManagerCacheClearer.php',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function new_dependency_test_update_8001\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/new_dependency_test/new_dependency_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Method Drupal\\\\new_dependency_test\\\\SetterInjection\\:\\:setter\$\$ has no return type specified\\.$#',
		@@ -39867,24 +39765,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/update_script_test/update_script_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function update_script_test_update_7200\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/update_script_test/update_script_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function update_script_test_update_7201\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/update_script_test/update_script_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function update_script_test_update_8001\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/update_script_test/update_script_test.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Method Drupal\\\\Tests\\\\system\\\\Functional\\\\Batch\\\\ProcessingTest\\:\\:_resultMessages\$\$ has no return type specified\\.$#',

core/modules/locale/locale.install

+1 −1

Original line number	Diff line number	Diff line
		@@ -326,7 +326,7 @@ function locale_update_last_removed(): int {
		/**
		* Add an index on locales_location on type and name.
		*/
		function locale_update_10300() {
		function locale_update_10300(): void {
		$spec = [];
		$spec['locales_location'] = [
		'description' => 'Location information for source strings.',

core/modules/system/tests/modules/entity_test/update/entity_definition_updates_8001.inc

+1 −1

Original line number	Diff line number	Diff line
		@@ -12,7 +12,7 @@
		/**
		* Makes the 'user_id' field multiple and migrate its data.
		*/
		function entity_test_update_8001() {
		function entity_test_update_8001(): void {
		// To update the field schema we need to have no field data in the storage,
		// thus we retrieve it, delete it from storage, and write it back to the
		// storage after updating the schema.

core/modules/system/tests/modules/entity_test/update/entity_definition_updates_8002.inc

+1 −1

Original line number	Diff line number	Diff line
		@@ -12,7 +12,7 @@
		/**
		* Makes the 'user_id' field single and migrate its data.
		*/
		function entity_test_update_8002() {
		function entity_test_update_8002(): void {
		// To update the field schema we need to have no field data in the storage,
		// thus we retrieve it, delete it from storage, and write it back to the
		// storage after updating the schema.

core/modules/system/tests/modules/entity_test/update/status_report_8001.inc

+1 −1

Original line number	Diff line number	Diff line
		@@ -10,6 +10,6 @@
		/**
		* Test update.
		*/
		function entity_test_update_8001() {
		function entity_test_update_8001(): void {
		// Empty update, we just want to trigger an error in the status report.
		}