Issue #3355137 by Spokje: Update mglaman/phpstan-drupal and make daily "updated deps" QA jobs pass (46353b6b) · Commits · project / drupal

composer.json

+1 −1

Original line number	Diff line number	Diff line
		@@ -22,7 +22,7 @@
		"drupal/coder": "^8.3.10",
		"instaclick/php-webdriver": "^1.4.1",
		"justinrainbow/json-schema": "^5.2",
		"mglaman/phpstan-drupal": "^1.1.29",
		"mglaman/phpstan-drupal": "^1.1.30",
		"mikey179/vfsstream": "^1.6.11",
		"phpspec/prophecy-phpunit": "^2",
		"phpstan/extension-installer": "^1.1",

composer.lock

+7 −7

Original line number	Diff line number	Diff line
		@@ -4,7 +4,7 @@
		"Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
		"This file is @generated automatically"
		],
		"content-hash": "31ed43e991e91dae14239ba7578c8320",
		"content-hash": "57d04c089c6f7fc0c3f53136521d2f90",
		"packages": [
		{
		"name": "asm89/stack-cors",
		@@ -5106,16 +5106,16 @@
		},
		{
		"name": "mglaman/phpstan-drupal",
		"version": "1.1.29",
		"version": "1.1.30",
		"source": {
		"type": "git",
		"url": "https://github.com/mglaman/phpstan-drupal.git",
		"reference": "e6f6191c53b159013fcbd186d7f85511f3f96ff8"
		"reference": "21b62499bb1233667f4d2bc6ce11db73500734fe"
		},
		"dist": {
		"type": "zip",
		"url": "https://api.github.com/repos/mglaman/phpstan-drupal/zipball/e6f6191c53b159013fcbd186d7f85511f3f96ff8",
		"reference": "e6f6191c53b159013fcbd186d7f85511f3f96ff8",
		"url": "https://api.github.com/repos/mglaman/phpstan-drupal/zipball/21b62499bb1233667f4d2bc6ce11db73500734fe",
		"reference": "21b62499bb1233667f4d2bc6ce11db73500734fe",
		"shasum": ""
		},
		"require": {
		@@ -5190,7 +5190,7 @@
		"description": "Drupal extension and rules for PHPStan",
		"support": {
		"issues": "https://github.com/mglaman/phpstan-drupal/issues",
		"source": "https://github.com/mglaman/phpstan-drupal/tree/1.1.29"
		"source": "https://github.com/mglaman/phpstan-drupal/tree/1.1.30"
		},
		"funding": [
		{
		@@ -5206,7 +5206,7 @@
		"type": "tidelift"
		}
		],
		"time": "2023-02-08T21:44:03+00:00"
		"time": "2023-04-07T13:36:19+00:00"
		},
		{
		"name": "mikey179/vfsstream",

composer/Metapackage/DevDependencies/composer.json

+1 −1

Original line number	Diff line number	Diff line
		@@ -14,7 +14,7 @@
		"drupal/coder": "^8.3.10",
		"instaclick/php-webdriver": "^1.4.1",
		"justinrainbow/json-schema": "^5.2",
		"mglaman/phpstan-drupal": "^1.1.29",
		"mglaman/phpstan-drupal": "^1.1.30",
		"mikey179/vfsstream": "^1.6.11",
		"phpspec/prophecy-phpunit": "^2",
		"phpstan/extension-installer": "^1.1",

composer/Metapackage/PinnedDevDependencies/composer.json

+1 −1

Original line number	Diff line number	Diff line
		@@ -23,7 +23,7 @@
		"drupal/coder": "8.3.16",
		"instaclick/php-webdriver": "1.4.16",
		"justinrainbow/json-schema": "5.2.12",
		"mglaman/phpstan-drupal": "1.1.29",
		"mglaman/phpstan-drupal": "1.1.30",
		"mikey179/vfsstream": "v1.6.11",
		"myclabs/deep-copy": "1.11.0",
		"nikic/php-parser": "v4.15.2",

core/phpstan-baseline.neon

+0 −110

Original line number	Diff line number	Diff line
		@@ -65,11 +65,6 @@ parameters:
		count: 1
		path: includes/theme.maintenance.inc

		-
		message: "#^A file could not be loaded from Drupal\\\\Core\\\\Extension\\\\ModuleHandlerInterface\\:\\:loadInclude$#"
		count: 1
		path: includes/update.inc

		-
		message: "#^Call to an undefined method Drupal\\\\Component\\\\Datetime\\\\DateTimePlus\\:\\:getTimeZone\$\$\\.$#"
		count: 1
		@@ -385,21 +380,11 @@ parameters:
		count: 1
		path: lib/Drupal/Core/Entity/Controller/EntityController.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 1
		path: lib/Drupal/Core/Entity/Entity/EntityFormDisplay.php

		-
		message: "#^Variable \\$candidate_ids might not be defined\\.$#"
		count: 2
		path: lib/Drupal/Core/Entity/Entity/EntityFormDisplay.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 1
		path: lib/Drupal/Core/Entity/Entity/EntityViewDisplay.php

		-
		message: "#^Variable \\$string in isset\$\$ always exists and is not nullable\\.$#"
		count: 1
		@@ -835,11 +820,6 @@ parameters:
		count: 1
		path: modules/block/tests/src/Functional/BlockUiTest.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 3
		path: modules/block/tests/src/Kernel/NewDefaultThemeBlocksTest.php

		-
		message: "#^Variable \\$row in empty\$\$ is never defined\\.$#"
		count: 1
		@@ -930,11 +910,6 @@ parameters:
		count: 2
		path: modules/ckeditor5/ckeditor5.module

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 1
		path: modules/ckeditor5/src/Plugin/CKEditor5Plugin/MediaLibrary.php

		-
		message: "#^Variable \\$ghs_config_classes in empty\$\$ always exists and is always falsy\\.$#"
		count: 1
		@@ -1025,11 +1000,6 @@ parameters:
		count: 1
		path: modules/config/tests/config_test/src/ConfigTestForm.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 1
		path: modules/config_translation/src/Controller/ConfigTranslationFieldListBuilder.php

		-
		message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:11\\.0\\.0\\. Use \\\\Drupal\\:\\:time\$\$\\-\\>getRequestTime\$\$; $#"
		count: 1
		@@ -1195,16 +1165,6 @@ parameters:
		count: 1
		path: modules/dblog/tests/src/Kernel/DbLogTest.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 2
		path: modules/field/field.module

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 1
		path: modules/field/src/ConfigImporterFieldPurger.php

		-
		message: "#^Variable \\$items in empty\$\$ always exists and is not falsy\\.$#"
		count: 1
		@@ -1225,11 +1185,6 @@ parameters:
		count: 1
		path: modules/field/tests/src/Kernel/FieldAttachStorageTest.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 2
		path: modules/field/tests/src/Kernel/FieldImportCreateTest.php

		-
		message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:11\\.0\\.0\\. Use \\\\Drupal\\:\\:time\$\$\\-\\>getRequestTime\$\$; $#"
		count: 1
		@@ -1275,11 +1230,6 @@ parameters:
		count: 1
		path: modules/field_ui/src/Form/FieldConfigEditForm.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 1
		path: modules/field_ui/src/Form/FieldStorageAddForm.php

		-
		message: "#^Method Drupal\\\\field_ui\\\\Form\\\\FieldStorageConfigEditForm\\:\\:save\$\$ should return int but return statement is missing\\.$#"
		count: 1
		@@ -1355,11 +1305,6 @@ parameters:
		count: 2
		path: modules/file/tests/src/Kernel/UsageTest.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 2
		path: modules/filter/src/FilterFormatFormBase.php

		-
		message: "#^Variable \\$rows might not be defined\\.$#"
		count: 1
		@@ -1625,11 +1570,6 @@ parameters:
		count: 1
		path: modules/media/src/OEmbed/UrlResolver.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 1
		path: modules/media_library/src/Plugin/Field/FieldWidget/MediaLibraryWidget.php

		-
		message: "#^Variable \\$jpg_image might not be defined\\.$#"
		count: 1
		@@ -2045,11 +1985,6 @@ parameters:
		count: 1
		path: modules/search/src/Form/SearchPageFormBase.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 2
		path: modules/search/src/Form/SearchPageFormBase.php

		-
		message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:11\\.0\\.0\\. Use \\\\Drupal\\:\\:time\$\$\\-\\>getRequestTime\$\$; $#"
		count: 1
		@@ -2095,11 +2030,6 @@ parameters:
		count: 1
		path: modules/shortcut/src/Form/SetCustomize.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 1
		path: modules/shortcut/src/Form/SwitchShortcutSet.php

		-
		message: "#^Method Drupal\\\\shortcut\\\\ShortcutForm\\:\\:save\$\$ should return int but return statement is missing\\.$#"
		count: 1
		@@ -2145,11 +2075,6 @@ parameters:
		count: 1
		path: modules/system/src/Form/DateFormatFormBase.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 1
		path: modules/system/src/Form/DateFormatFormBase.php

		-
		message: "#^Method Drupal\\\\system\\\\Form\\\\ModulesListNonStableConfirmForm\\:\\:getQuestion\$\$ should return Drupal\\\\Core\\\\StringTranslation\\\\TranslatableMarkup but return statement is missing\\.$#"
		count: 1
		@@ -2350,11 +2275,6 @@ parameters:
		count: 1
		path: modules/tour/src/TipPluginBase.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 1
		path: modules/tour/tour.module

		-
		message: "#^Variable \\$violation_messages might not be defined\\.$#"
		count: 1
		@@ -2380,11 +2300,6 @@ parameters:
		count: 2
		path: modules/user/src/EventSubscriber/UserRequestSubscriber.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 2
		path: modules/user/src/Form/RoleSettingsForm.php

		-
		message: "#^Variable \\$route_object might not be defined\\.$#"
		count: 1
		@@ -2650,11 +2565,6 @@ parameters:
		count: 1
		path: modules/views/src/Plugin/views/field/PrerenderList.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 1
		path: modules/views/src/Plugin/views/field/RenderedEntity.php

		-
		message: "#^Variable \\$entity in isset\$\$ always exists and is not nullable\\.$#"
		count: 1
		@@ -2765,11 +2675,6 @@ parameters:
		count: 1
		path: modules/views/src/ViewExecutable.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 3
		path: modules/views/src/Views.php

		-
		message: "#^Configuration entity must define a `config_export` key\\. See https\\://www\\.drupal\\.org/node/2481909$#"
		count: 1
		@@ -2905,11 +2810,6 @@ parameters:
		count: 1
		path: modules/views_ui/tests/src/FunctionalJavascript/PreviewTest.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 1
		path: modules/workflows/src/Entity/Workflow.php

		-
		message: "#^Method Drupal\\\\workflows\\\\Form\\\\WorkflowEditForm\\:\\:save\$\$ should return int but return statement is missing\\.$#"
		count: 1
		@@ -2975,11 +2875,6 @@ parameters:
		count: 1
		path: modules/workspaces/src/WorkspacePublisher.php

		-
		message: "#^Relying on entity queries to check access by default is deprecated in drupal\\:9\\.2\\.0 and an error will be thrown from drupal\\:10\\.0\\.0\\. Call \\\\Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:accessCheck\$\$ with TRUE or FALSE to specify whether access should be checked\\.$#"
		count: 1
		path: modules/workspaces/workspaces.install

		-
		message: "#^Variable \\$keyed_content might not be defined\\.$#"
		count: 1
		@@ -3130,11 +3025,6 @@ parameters:
		count: 1
		path: tests/Drupal/TestSite/Commands/TestSiteInstallCommand.php

		-
		message: "#^A file could not be loaded from Drupal\\\\Core\\\\Extension\\\\ModuleHandlerInterface\\:\\:loadInclude$#"
		count: 1
		path: tests/Drupal/TestTools/Extension/SchemaInspector.php

		-
		message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:11\\.0\\.0\\. Use \\\\Drupal\\:\\:time\$\$\\-\\>getRequestTime\$\$; $#"
		count: 1