Verified Commit 4630029b authored by Théodore Biadala's avatar Théodore Biadala
Browse files

Issue #3469580 by catch, smustgrave: Speed up UpdateSemverTestSecurityAvailabilityTrait 

(cherry picked from commit 0066ab0f)
parent 948c9327

core/modules/update/tests/src/Functional/UpdateSemverContribSecurityAvailabilityTest.php

+0 −1
Original line number Diff line number Diff line
@@ -8,7 +8,6 @@ 
 * Tests Update Manager with a security update available for a contrib project.

 *

 * @group update

 * @group #slow

 */

class UpdateSemverContribSecurityAvailabilityTest extends UpdateSemverContribTestBase {

core/modules/update/tests/src/Functional/UpdateSemverCoreSecurityAvailabilityTest.php

+0 −1
Original line number Diff line number Diff line
@@ -8,7 +8,6 @@ 
 * Tests Update Manager with a security update available for Drupal core.

 *

 * @group update

 * @group #slow

 */

class UpdateSemverCoreSecurityAvailabilityTest extends UpdateSemverCoreTestBase {

core/modules/update/tests/src/Functional/UpdateSemverTestSecurityAvailabilityTrait.php

+10 −3
Original line number Diff line number Diff line
@@ -9,6 +9,15 @@ 
 */

trait UpdateSemverTestSecurityAvailabilityTrait {



  /**

   * Tests the update manager when a security update is available.

   */

  public function testSecurityUpdateAvailability(): void {

    foreach (static::securityUpdateAvailabilityProvider() as $case) {

      $this->doTestSecurityUpdateAvailability($case['site_patch_version'], $case['expected_security_releases'], $case['expected_update_message_type'], $case['fixture']);

    }

  }



  /**

   * Tests the Update Manager module when a security update is available.

   *
@@ -20,10 +29,8 @@ trait UpdateSemverTestSecurityAvailabilityTrait { 
   *   The type of update message expected.

   * @param string $fixture

   *   The test fixture that contains the test XML.

   *

   * @dataProvider securityUpdateAvailabilityProvider

   */

  public function testSecurityUpdateAvailability($site_patch_version, array $expected_security_releases, $expected_update_message_type, $fixture): void {

  protected function doTestSecurityUpdateAvailability($site_patch_version, array $expected_security_releases, $expected_update_message_type, $fixture): void {

    $this->setProjectInstalledVersion("8.$site_patch_version");

    $this->refreshUpdateStatus([$this->updateProject => $fixture]);

    $this->assertSecurityUpdates("{$this->updateProject}-8", $expected_security_releases, $expected_update_message_type, $this->updateTableLocator);