Unverified Commit 44b86a44 authored by alexpott's avatar alexpott

Issue #3004428 by mikelutz, alexpott, Mile23: Remove references to...

Issue #3004428 by mikelutz, alexpott, Mile23: Remove references to i18nVariable, CommentType, CommentVariable and CommentVariablePerCommentType from the global deprecation listener list
parent 0991d759
......@@ -9,6 +9,7 @@
*
* @covers \Drupal\comment\Plugin\migrate\source\d6\CommentVariablePerCommentType
* @group comment
* @group legacy
*/
class CommentVariablePerCommentTypeTest extends MigrateSqlSourceTestBase {
......@@ -17,6 +18,18 @@ class CommentVariablePerCommentTypeTest extends MigrateSqlSourceTestBase {
*/
public static $modules = ['comment', 'migrate_drupal'];
/**
* {@inheritdoc}
*
* @dataProvider providerSource
* @requires extension pdo_sqlite
* @expectedDeprecation CommentVariablePerCommentType is deprecated in Drupal 8.4.x and will be removed before Drupal 9.0.x. Use \Drupal\node\Plugin\migrate\source\d6\NodeType instead.
* @expectedDeprecation CommentVariable is deprecated in Drupal 8.4.x and will be removed before Drupal 9.0.x. Use \Drupal\node\Plugin\migrate\source\d6\NodeType instead.
*/
public function testSource(array $source_data, array $expected_data, $expected_count = NULL, array $configuration = [], $high_water = NULL) {
parent::testSource($source_data, $expected_data, $expected_count, $configuration, $high_water);
}
/**
* {@inheritdoc}
*/
......
......@@ -9,6 +9,7 @@
*
* @covers \Drupal\comment\Plugin\migrate\source\d6\CommentVariable
* @group comment
* @group legacy
*/
class CommentVariableTest extends MigrateSqlSourceTestBase {
......@@ -17,6 +18,17 @@ class CommentVariableTest extends MigrateSqlSourceTestBase {
*/
public static $modules = ['comment', 'migrate_drupal'];
/**
* {@inheritdoc}
*
* @dataProvider providerSource
* @requires extension pdo_sqlite
* @expectedDeprecation CommentVariable is deprecated in Drupal 8.4.x and will be removed before Drupal 9.0.x. Use \Drupal\node\Plugin\migrate\source\d6\NodeType instead.
*/
public function testSource(array $source_data, array $expected_data, $expected_count = NULL, array $configuration = [], $high_water = NULL) {
parent::testSource($source_data, $expected_data, $expected_count, $configuration, $high_water);
}
/**
* {@inheritdoc}
*/
......
......@@ -9,6 +9,7 @@
*
* @covers \Drupal\comment\Plugin\migrate\source\d7\CommentType
* @group comment
* @group legacy
*/
class CommentTypeTest extends MigrateSqlSourceTestBase {
......@@ -17,6 +18,17 @@ class CommentTypeTest extends MigrateSqlSourceTestBase {
*/
public static $modules = ['comment', 'migrate_drupal'];
/**
* {@inheritdoc}
*
* @dataProvider providerSource
* @requires extension pdo_sqlite
* @expectedDeprecation CommentType is deprecated in Drupal 8.4.x and will be removed before Drupal 9.0.x. Use \Drupal\node\Plugin\migrate\source\d7\NodeType instead.
*/
public function testSource(array $source_data, array $expected_data, $expected_count = NULL, array $configuration = [], $high_water = NULL) {
parent::testSource($source_data, $expected_data, $expected_count, $configuration, $high_water);
}
/**
* {@inheritdoc}
*/
......
<?php
namespace Drupal\Tests\migrate_drupal\Kernel\Plugin\migrate\source\d6;
use Drupal\Tests\migrate\Kernel\MigrateSqlSourceTestBase;
/**
* Tests the variable source plugin.
*
* @covers \Drupal\migrate_drupal\Plugin\migrate\source\d6\VariableTranslation
*
* @group migrate_drupal
*/
class VariableTranslationTest extends MigrateSqlSourceTestBase {
/**
* {@inheritdoc}
*/
public static $modules = ['migrate_drupal'];
/**
* {@inheritdoc}
*/
public function providerSource() {
$tests = [];
// The source data.
$tests[0]['source_data']['i18n_variable'] = [
[
'name' => 'site_slogan',
'language' => 'fr',
'value' => 's:19:"Migrate est génial";',
],
[
'name' => 'site_name',
'language' => 'fr',
'value' => 's:11:"nom de site";',
],
[
'name' => 'site_slogan',
'language' => 'mi',
'value' => 's:19:"Ko whakamataku heke";',
],
[
'name' => 'site_name',
'language' => 'mi',
'value' => 's:9:"ingoa_pae";',
],
];
// The expected results.
$tests[0]['expected_data'] = [
[
'language' => 'fr',
'site_slogan' => 'Migrate est génial',
'site_name' => 'nom de site',
],
[
'language' => 'mi',
'site_slogan' => 'Ko whakamataku heke',
'site_name' => 'ingoa_pae',
],
];
// The expected count.
$tests[0]['expected_count'] = NULL;
// The migration configuration.
$tests[0]['configuration']['variables'] = [
'site_slogan',
'site_name',
];
return $tests;
}
}
......@@ -19,6 +19,17 @@ class i18nVariableTest extends MigrateSqlSourceTestBase {
*/
public static $modules = ['migrate_drupal'];
/**
* {@inheritdoc}
*
* @dataProvider providerSource
* @requires extension pdo_sqlite
* @expectedDeprecation The Drupal\migrate_drupal\Plugin\migrate\source\d6\i18nVariable is deprecated in Drupal 8.4.0 and will be removed before Drupal 9.0.0. Instead, use Drupal\migrate_drupal\Plugin\migrate\source\d6\VariableTranslation
*/
public function testSource(array $source_data, array $expected_data, $expected_count = NULL, array $configuration = [], $high_water = NULL) {
parent::testSource($source_data, $expected_data, $expected_count, $configuration, $high_water);
}
/**
* {@inheritdoc}
*/
......
......@@ -125,10 +125,6 @@ public static function getSkippedDeprecations() {
'Passing in arguments the legacy way is deprecated in Drupal 8.4.0 and will be removed before Drupal 9.0.0. Provide the right parameter names in the method, similar to controllers. See https://www.drupal.org/node/2894819',
'DateField is deprecated in Drupal 8.4.x and will be removed before Drupal 9.0.x. Use \Drupal\datetime\Plugin\migrate\field\DateField instead.',
'The Drupal\editor\Plugin\EditorBase::settingsFormSubmit method is deprecated since version 8.3.x and will be removed in 9.0.0.',
'CommentVariable is deprecated in Drupal 8.4.x and will be removed before Drupal 9.0.x. Use \Drupal\node\Plugin\migrate\source\d6\NodeType instead.',
'CommentType is deprecated in Drupal 8.4.x and will be removed before Drupal 9.0.x. Use \Drupal\node\Plugin\migrate\source\d7\NodeType instead.',
'CommentVariablePerCommentType is deprecated in Drupal 8.4.x and will be removed before Drupal 9.0.x. Use \Drupal\node\Plugin\migrate\source\d6\NodeType instead.',
'The Drupal\migrate_drupal\Plugin\migrate\source\d6\i18nVariable is deprecated in Drupal 8.4.0 and will be removed before Drupal 9.0.0. Instead, use Drupal\migrate_drupal\Plugin\migrate\source\d6\VariableTranslation',
'The "serializer.normalizer.file_entity.hal" normalizer service is deprecated: it is obsolete, it only remains available for backwards compatibility.',
'The Symfony\Component\ClassLoader\ApcClassLoader class is deprecated since Symfony 3.3 and will be removed in 4.0. Use `composer install --apcu-autoloader` instead.',
// The following deprecation is not triggered by DrupalCI testing since it
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment