Commit 3fb0eded authored by catch's avatar catch
Browse files

Issue #2560447 by bojanz, longwave: Remove the undocumented, untested views_form_callback API

parent cd796b6d

core/modules/views/src/Form/ViewsFormMainForm.php

+1 −6
Original line number Diff line number Diff line
@@ -107,12 +107,7 @@ public function buildForm(array $form, FormStateInterface $form_state, ViewExecu 


      // If the field provides a views form, allow it to modify the $form array.

      $has_form = FALSE;

      if (property_exists($field, 'views_form_callback')) {

        $callback = $field->views_form_callback;

        $callback($view, $field, $form, $form_state);

        $has_form = TRUE;

      }

      elseif (method_exists($field, 'viewsForm')) {

      if (method_exists($field, 'viewsForm')) {

        $field->viewsForm($form, $form_state);

        $has_form = TRUE;

      }

core/modules/views/src/ViewExecutable.php

+1 −1
Original line number Diff line number Diff line
@@ -2451,7 +2451,7 @@ public function buildThemeFunctions($hook) { 
   */

  public function hasFormElements() {

    foreach ($this->field as $field) {

      if (property_exists($field, 'views_form_callback') || method_exists($field, 'viewsForm')) {

      if (method_exists($field, 'viewsForm')) {

        return TRUE;

      }

    }