Commit 3ab889a1 authored by catch's avatar catch
Browse files

Issue #3153150 by Suresh Prabhu Parkala, paulocs, ravi.shankar, Deepak Goyal,... 

Issue #3153150 by Suresh Prabhu Parkala, paulocs, ravi.shankar, Deepak Goyal, Hardik_Patel_12, longwave: Remove uses of t() in assertTrue() and assertFalse() calls
parent b7f992cf

core/modules/comment/tests/src/Functional/CommentInterfaceTest.php

+2 −1
Changes for core/modules/comment/tests/src/Functional/CommentInterfaceTest.php: 2 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -101,7 +101,8 @@ public function testCommentInterface() { 


    // Test changing the comment author to "Anonymous".

    $comment = $this->postComment(NULL, $comment->comment_body->value, $comment->getSubject(), ['uid' => '']);

    $this->assertTrue($comment->getAuthorName() == t('Anonymous') && $comment->getOwnerId() == 0, 'Comment author successfully changed to anonymous.');

    $this->assertTrue($comment->getAuthorName() == 'Anonymous', 'Comment author successfully changed to anonymous.');

    $this->assertTrue($comment->getOwnerId() == 0, 'Comment author successfully changed to anonymous.');



    // Test changing the comment author to an unverified user.

    $random_name = $this->randomMachineName();

core/modules/field/tests/src/Functional/FormTest.php

+1 −1
Changes for core/modules/field/tests/src/Functional/FormTest.php: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -272,7 +272,7 @@ public function testFieldFormUnlimited() { 


    // Check if aria-describedby attribute is placed on multiple value widgets.

    $elements = $this->xpath('//table[@id="field-unlimited-values" and @aria-describedby="edit-field-unlimited--description"]');

    $this->assertTrue(isset($elements[0]), t('aria-describedby attribute is properly placed on multiple value widgets.'));

    $this->assertTrue(isset($elements[0]), 'aria-describedby attribute is properly placed on multiple value widgets.');



    // Press 'add more' button -> 2 widgets.

    $this->drupalPostForm(NULL, [], t('Add another item'));

core/modules/language/tests/src/Functional/LanguageSwitchingTest.php

+14 −14
Changes for core/modules/language/tests/src/Functional/LanguageSwitchingTest.php: 14 added lines, 14 removed lines.
Original line number Diff line number Diff line
@@ -276,12 +276,12 @@ public function testLanguageBodyClass() { 
    // Check if the default (English) admin/config page has the right class.

    $this->drupalGet('admin/config');

    $class = $this->xpath('//body[contains(@class, :class)]', [':class' => $searched_class]);

    $this->assertTrue(isset($class[0]), t('The path-admin class appears on default language.'));

    $this->assertTrue(isset($class[0]), 'The path-admin class appears on default language.');



    // Check if the French admin/config page has the right class.

    $this->drupalGet('fr/admin/config');

    $class = $this->xpath('//body[contains(@class, :class)]', [':class' => $searched_class]);

    $this->assertTrue(isset($class[0]), t('The path-admin class same as on default language.'));

    $this->assertTrue(isset($class[0]), 'The path-admin class same as on default language.');



    // The testing profile sets the user/login page as the frontpage. That

    // redirects authenticated users to their profile page, so check with an
@@ -316,17 +316,17 @@ protected function doTestLanguageLinkActiveClassAuthenticated() { 
    // Language code 'none' link should be active.

    $langcode = 'none';

    $links = $this->xpath('//a[@id = :id and @data-drupal-link-system-path = :path]', [':id' => 'no_lang_link', ':path' => $path]);

    $this->assertTrue(isset($links[0]), t('A link generated by :function to the current :language page with langcode :langcode has the correct attributes that will allow the drupal.active-link library to mark it as active.', [':function' => $function_name, ':language' => $current_language, ':langcode' => $langcode]));

    $this->assertTrue(isset($links[0]), 'A link generated by $function_name to the current $current_language page with langcode $langcode has the correct attributes that will allow the drupal.active-link library to mark it as active.');



    // Language code 'en' link should be active.

    $langcode = 'en';

    $links = $this->xpath('//a[@id = :id and @hreflang = :lang and @data-drupal-link-system-path = :path]', [':id' => 'en_link', ':lang' => 'en', ':path' => $path]);

    $this->assertTrue(isset($links[0]), t('A link generated by :function to the current :language page with langcode :langcode has the correct attributes that will allow the drupal.active-link library to mark it as active.', [':function' => $function_name, ':language' => $current_language, ':langcode' => $langcode]));

    $this->assertTrue(isset($links[0]), 'A link generated by $function_name to the current $current_language page with langcode $langcode has the correct attributes that will allow the drupal.active-link library to mark it as active.');



    // Language code 'fr' link should not be active.

    $langcode = 'fr';

    $links = $this->xpath('//a[@id = :id and @hreflang = :lang and @data-drupal-link-system-path = :path]', [':id' => 'fr_link', ':lang' => 'fr', ':path' => $path]);

    $this->assertTrue(isset($links[0]), t('A link generated by :function to the current :language page with langcode :langcode has the correct attributes that will allow the drupal.active-link library to NOT mark it as active.', [':function' => $function_name, ':language' => $current_language, ':langcode' => $langcode]));

    $this->assertTrue(isset($links[0]), 'A link generated by $function_name to the current $current_language page with langcode $langcode has the correct attributes that will allow the drupal.active-link library to NOT mark it as active.');



    // Verify that drupalSettings contains the correct values.

    $settings = $this->getDrupalSettings();
@@ -341,17 +341,17 @@ protected function doTestLanguageLinkActiveClassAuthenticated() { 
    // Language code 'none' link should be active.

    $langcode = 'none';

    $links = $this->xpath('//a[@id = :id and @data-drupal-link-system-path = :path]', [':id' => 'no_lang_link', ':path' => $path]);

    $this->assertTrue(isset($links[0]), t('A link generated by :function to the current :language page with langcode :langcode has the correct attributes that will allow the drupal.active-link library to mark it as active.', [':function' => $function_name, ':language' => $current_language, ':langcode' => $langcode]));

    $this->assertTrue(isset($links[0]), 'A link generated by $function_name to the current $current_language page with langcode $langcode has the correct attributes that will allow the drupal.active-link library to mark it as active.');



    // Language code 'en' link should not be active.

    $langcode = 'en';

    $links = $this->xpath('//a[@id = :id and @hreflang = :lang and @data-drupal-link-system-path = :path]', [':id' => 'en_link', ':lang' => 'en', ':path' => $path]);

    $this->assertTrue(isset($links[0]), t('A link generated by :function to the current :language page with langcode :langcode has the correct attributes that will allow the drupal.active-link library to NOT mark it as active.', [':function' => $function_name, ':language' => $current_language, ':langcode' => $langcode]));

    $this->assertTrue(isset($links[0]), 'A link generated by $function_name to the current $current_language page with langcode $langcode has the correct attributes that will allow the drupal.active-link library to NOT mark it as active.');



    // Language code 'fr' link should be active.

    $langcode = 'fr';

    $links = $this->xpath('//a[@id = :id and @hreflang = :lang and @data-drupal-link-system-path = :path]', [':id' => 'fr_link', ':lang' => 'fr', ':path' => $path]);

    $this->assertTrue(isset($links[0]), t('A link generated by :function to the current :language page with langcode :langcode has the correct attributes that will allow the drupal.active-link library to mark it as active.', [':function' => $function_name, ':language' => $current_language, ':langcode' => $langcode]));

    $this->assertTrue(isset($links[0]), 'A link generated by $function_name to the current $current_language page with langcode $langcode has the correct attributes that will allow the drupal.active-link library to mark it as active.');



    // Verify that drupalSettings contains the correct values.

    $settings = $this->getDrupalSettings();
@@ -377,17 +377,17 @@ protected function doTestLanguageLinkActiveClassAnonymous() { 
    // Language code 'none' link should be active.

    $langcode = 'none';

    $links = $this->xpath('//a[@id = :id and contains(@class, :class)]', [':id' => 'no_lang_link', ':class' => 'is-active']);

    $this->assertTrue(isset($links[0]), t('A link generated by :function to the current :language page with langcode :langcode is marked active.', [':function' => $function_name, ':language' => $current_language, ':langcode' => $langcode]));

    $this->assertTrue(isset($links[0]), 'A link generated by $function_name to the current $current_language page with langcode $langcode is marked active.');



    // Language code 'en' link should be active.

    $langcode = 'en';

    $links = $this->xpath('//a[@id = :id and contains(@class, :class)]', [':id' => 'en_link', ':class' => 'is-active']);

    $this->assertTrue(isset($links[0]), t('A link generated by :function to the current :language page with langcode :langcode is marked active.', [':function' => $function_name, ':language' => $current_language, ':langcode' => $langcode]));

    $this->assertTrue(isset($links[0]), 'A link generated by $function_name to the current $current_language page with langcode $langcode is marked active.');



    // Language code 'fr' link should not be active.

    $langcode = 'fr';

    $links = $this->xpath('//a[@id = :id and not(contains(@class, :class))]', [':id' => 'fr_link', ':class' => 'is-active']);

    $this->assertTrue(isset($links[0]), t('A link generated by :function to the current :language page with langcode :langcode is NOT marked active.', [':function' => $function_name, ':language' => $current_language, ':langcode' => $langcode]));

    $this->assertTrue(isset($links[0]), 'A link generated by $function_name to the current $current_language page with langcode $langcode is NOT marked active.');



    // Test links generated by the link generator on a French page.

    $current_language = 'French';
@@ -396,17 +396,17 @@ protected function doTestLanguageLinkActiveClassAnonymous() { 
    // Language code 'none' link should be active.

    $langcode = 'none';

    $links = $this->xpath('//a[@id = :id and contains(@class, :class)]', [':id' => 'no_lang_link', ':class' => 'is-active']);

    $this->assertTrue(isset($links[0]), t('A link generated by :function to the current :language page with langcode :langcode is marked active.', [':function' => $function_name, ':language' => $current_language, ':langcode' => $langcode]));

    $this->assertTrue(isset($links[0]), 'A link generated by $function_name to the current $current_language page with langcode $langcode is marked active.');



    // Language code 'en' link should not be active.

    $langcode = 'en';

    $links = $this->xpath('//a[@id = :id and not(contains(@class, :class))]', [':id' => 'en_link', ':class' => 'is-active']);

    $this->assertTrue(isset($links[0]), t('A link generated by :function to the current :language page with langcode :langcode is NOT marked active.', [':function' => $function_name, ':language' => $current_language, ':langcode' => $langcode]));

    $this->assertTrue(isset($links[0]), 'A link generated by $function_name to the current $current_language page with langcode $langcode is NOT marked active.');



    // Language code 'fr' link should be active.

    $langcode = 'fr';

    $links = $this->xpath('//a[@id = :id and contains(@class, :class)]', [':id' => 'fr_link', ':class' => 'is-active']);

    $this->assertTrue(isset($links[0]), t('A link generated by :function to the current :language page with langcode :langcode is marked active.', [':function' => $function_name, ':language' => $current_language, ':langcode' => $langcode]));

    $this->assertTrue(isset($links[0]), 'A link generated by $function_name to the current $current_language page with langcode $langcode is marked active.');

  }



  /**

core/modules/search/tests/src/Functional/SearchNodeUpdateAndDeletionTest.php

+1 −1
Changes for core/modules/search/tests/src/Functional/SearchNodeUpdateAndDeletionTest.php: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -118,7 +118,7 @@ public function testSearchIndexUpdateOnNodeDeletion() { 
      ->condition('word', 'dragons')

      ->execute()

      ->fetchField();

    $this->assertFalse($search_index_dataset, t('Node info successfully removed from search_index'));

    $this->assertFalse($search_index_dataset, 'Node info successfully removed from search_index');



    // Search again to verify the node doesn't appear anymore.

    $this->drupalPostForm('search/node', $edit, t('Search'));

core/modules/system/tests/src/Functional/Form/ElementsLabelsTest.php

+3 −3
Changes for core/modules/system/tests/src/Functional/Form/ElementsLabelsTest.php: 3 added lines, 3 removed lines.
Original line number Diff line number Diff line
@@ -123,13 +123,13 @@ public function testFormDescriptions() { 
    $field_id = 'edit-form-textfield-test-description-after';

    $description_id = $field_id . '--description';

    $elements = $this->xpath('//input[@id="' . $field_id . '" and @aria-describedby="' . $description_id . '"]/following-sibling::div[@id="' . $description_id . '"]');

    $this->assertTrue(isset($elements[0]), t('Properly places the #description element after the form item.'));

    $this->assertTrue(isset($elements[0]), 'Properly places the #description element after the form item.');



    // Check #description placement with #description_display='before'.

    $field_id = 'edit-form-textfield-test-description-before';

    $description_id = $field_id . '--description';

    $elements = $this->xpath('//input[@id="' . $field_id . '" and @aria-describedby="' . $description_id . '"]/preceding-sibling::div[@id="' . $description_id . '"]');

    $this->assertTrue(isset($elements[0]), t('Properly places the #description element before the form item.'));

    $this->assertTrue(isset($elements[0]), 'Properly places the #description element before the form item.');



    // Check if the class is 'visually-hidden' on the form element description

    // for the option with #description_display='invisible' and also check that
@@ -137,7 +137,7 @@ public function testFormDescriptions() { 
    $field_id = 'edit-form-textfield-test-description-invisible';

    $description_id = $field_id . '--description';

    $elements = $this->xpath('//input[@id="' . $field_id . '" and @aria-describedby="' . $description_id . '"]/following-sibling::div[contains(@class, "visually-hidden")]');

    $this->assertTrue(isset($elements[0]), t('Properly renders the #description element visually-hidden.'));

    $this->assertTrue(isset($elements[0]), 'Properly renders the #description element visually-hidden.');

  }



  /**