Skip to content
Snippets Groups Projects
Commit 37dd50f5 authored by catch's avatar catch
Browse files

Issue #3373867 by lauriii, Eric_A, smustgrave: [regression] "Comments field is...

Issue #3373867 by lauriii, Eric_A, smustgrave: [regression] "Comments field is required" when creating content for types with a comment field configured as hidden

(cherry picked from commit 9028e6c0)
parent 9ae6dbd4
No related branches found
No related tags found
20 merge requests!11628Update file MediaLibraryWidget.php,!7564Revert "Issue #3364773 by roshnichordiya, Chris Matthews, thakurnishant_06,...,!5752Issue #3275828 by joachim, quietone, bradjones1, Berdir: document the reason...,!5627Issue #3261805: Field not saved when change of 0 on string start,!5427Issue #3338518: send credentials in ajax if configured in CORS settings.,!5395Issue #3387916 by fjgarlin, Spokje: Each GitLab job exposes user email,!5217Issue #3386607 by alexpott: Improve spell checking in commit-code-check.sh,!5064Issue #3379522 by finnsky, Gauravvvv, kostyashupenko, smustgrave, Chi: Revert...,!5040SDC ComponentElement: Transform slots scalar values to #plain_text instead of throwing an exception,!4958Issue #3392147: Whitelist IP for a Ban module.,!4894Issue #3280279: Add API to allow sites to opt in to upload SVG images in CKEditor 5,!4857Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!4856Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!4788Issue #3272985: RSS Feed header reverts to text/html when cached,!4716Issue #3362929: Improve 400 responses for broken/invalid image style routes,!4553Draft: Issue #2980951: Permission to see own unpublished comments in comment thread,!3679Issue #115801: Allow password on registration without disabling e-mail verification,!3106Issue #3017548: "Filtered HTML" text format does not support manual teaser break (<!--break-->),!925Issue #2339235: Remove taxonomy hard dependency on node module,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links
......@@ -32,7 +32,6 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen
'#title' => $this->t('Comments'),
'#title_display' => 'invisible',
'#default_value' => $items->status,
'#required' => TRUE,
'#options' => [
CommentItemInterface::OPEN => $this->t('Open'),
CommentItemInterface::CLOSED => $this->t('Closed'),
......@@ -48,6 +47,12 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen
'#description' => $this->t('Comments are hidden from view.'),
],
];
// Setting a value in the default value widget is required.
if ($this->isDefaultValueWidget($form_state)) {
$element['status']['#required'] = TRUE;
}
// If the entity doesn't have any comments, the "hidden" option makes no
// sense, so don't even bother presenting it to the user unless this is the
// default value widget on the field settings form.
......
......@@ -523,4 +523,32 @@ public function testsNonIntegerIdEntities() {
$this->assertSession()->optionExists('edit-new-storage-type', 'boolean');
}
/**
* Ensures that comment settings are not required.
*/
public function testCommentSettingsNotRequired() {
$limited_user = $this->drupalCreateUser([
'administer entity_test fields',
]);
$this->drupalLogin($limited_user);
$this->drupalGet('entity_test/structure/entity_test/fields/entity_test.entity_test.comment');
// Change the comments to be displayed as hidden by default.
$edit = [
'default_value_input[comment][0][status]' => CommentItemInterface::HIDDEN,
'settings[anonymous]' => CommentInterface::ANONYMOUS_MAY_CONTACT,
];
$this->submitForm($edit, 'Save settings');
// Ensure that the comment settings field is not required and can be saved
// with the default value.
$this->drupalLogin($this->adminUser);
$this->drupalGet('/entity_test/add');
$edit = [
"name[0][value]" => 'Comment test',
];
$this->submitForm($edit, 'Save');
$this->assertSession()->pageTextContains('entity_test 2 has been created.');
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment