Unverified Commit 31e1980b authored Apr 30, 2026 by Alex Pott

task: #3533299 Deprecate node access rebuild functions

By: acbramley
By: virag.jain
By: mstrelan
By: dcam
By: nicxvan
By: alexpott

parent 51366e68

core/modules/comment/tests/src/Functional/CommentNodeAccessTest.php

+2 −1

Original line number	Diff line number	Diff line
		@@ -6,6 +6,7 @@

		use Drupal\comment\CommentManagerInterface;
		use Drupal\comment\CommentPreviewMode;
		use Drupal\node\NodeAccessRebuild;
		use PHPUnit\Framework\Attributes\Group;
		use PHPUnit\Framework\Attributes\RunTestsInSeparateProcesses;

		@@ -35,7 +36,7 @@ class CommentNodeAccessTest extends CommentTestBase {
		protected function setUp(): void {
		parent::setUp();

		node_access_rebuild();
		\Drupal::service(NodeAccessRebuild::class)->rebuild();

		// Re-create user.
		$this->webUser = $this->drupalCreateUser([

core/modules/content_moderation/tests/src/Functional/NodeAccessTest.php

+2 −1

Original line number	Diff line number	Diff line
		@@ -6,6 +6,7 @@

		use Drupal\node\Entity\NodeType;
		use Drupal\Tests\node\Traits\NodeAccessTrait;
		use Drupal\node\NodeAccessRebuild;
		use PHPUnit\Framework\Attributes\Group;
		use PHPUnit\Framework\Attributes\RunTestsInSeparateProcesses;

		@@ -69,7 +70,7 @@ protected function setUp(): void {

		// Rebuild permissions because hook_node_grants() is implemented by the
		// node_access_test_empty module.
		node_access_rebuild();
		\Drupal::service(NodeAccessRebuild::class)->rebuild();
		}

		/**

core/modules/field_ui/tests/src/Functional/ManageFieldsFunctionalTestBase.php

+2 −1

Original line number	Diff line number	Diff line
		@@ -11,6 +11,7 @@
		use Drupal\Tests\BrowserTestBase;
		use Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait;
		use Drupal\Tests\field_ui\Traits\FieldUiTestTrait;
		use Drupal\node\NodeAccessRebuild;

		/**
		* Tests the Field UI "Manage fields" screen.
		@@ -137,7 +138,7 @@ protected function setUp(): void {
		->save();

		// Setup node access testing.
		node_access_rebuild();
		\Drupal::service(NodeAccessRebuild::class)->rebuild();
		$this->addPrivateField(NodeType::load('article'));
		\Drupal::state()->set('node_access_test.private', TRUE);

core/modules/file/tests/src/Functional/FilePrivateTest.php

+2 −1

Original line number	Diff line number	Diff line
		@@ -8,6 +8,7 @@
		use Drupal\node\Entity\NodeType;
		use Drupal\Tests\node\Traits\NodeAccessTrait;
		use Drupal\user\RoleInterface;
		use Drupal\node\NodeAccessRebuild;
		use PHPUnit\Framework\Attributes\Group;
		use PHPUnit\Framework\Attributes\RunTestsInSeparateProcesses;

		@@ -36,7 +37,7 @@ class FilePrivateTest extends FileFieldTestBase {
		protected function setUp(): void {
		parent::setUp();
		$this->addPrivateField(NodeType::load('article'));
		node_access_rebuild();
		\Drupal::service(NodeAccessRebuild::class)->rebuild();
		\Drupal::state()->set('node_access_test.private', TRUE);
		// This test expects unused managed files to be marked as a temporary file.
		$this->config('file.settings')

core/modules/jsonapi/tests/src/Functional/JsonApiRegressionTest.php

+2 −1

Original line number	Diff line number	Diff line
		@@ -22,6 +22,7 @@
		use Drupal\user\Entity\User;
		use Drupal\user\RoleInterface;
		use GuzzleHttp\RequestOptions;
		use Drupal\node\NodeAccessRebuild;
		use PHPUnit\Framework\Attributes\Group;
		use PHPUnit\Framework\Attributes\RunTestsInSeparateProcesses;

		@@ -156,7 +157,7 @@ public function testGetTermWhenMultipleVocabulariesExistFromIssue2977879(): void
		public function testGetNodeCollectionWithHookNodeGrantsImplementationsFromIssue2984964(): void {
		// Set up data model.
		$this->assertTrue($this->container->get('module_installer')->install(['node_access_test'], TRUE), 'Installed modules.');
		node_access_rebuild();
		\Drupal::service(NodeAccessRebuild::class)->rebuild();
		$this->rebuildAll();

		// Create data.