Issue #3308987 by lauriii, Spokje, quietone, bnjmnm: Remove references to Stable

(cherry picked from commit 6c087ced)

core/lib/Drupal/Core/Theme/ThemeInitialization.php

@@ -112,13 +112,6 @@ public function getActiveThemeByName($theme_name) {
     while ($ancestor && isset($themes[$ancestor]->base_theme)) {
       $ancestor = $themes[$ancestor]->base_theme;
       if (!$this->themeHandler->themeExists($ancestor)) {
-        if ($ancestor == 'stable') {
-          // Themes that depend on Stable will be fixed by system_update_8014().
-          // There is no harm in not adding it as an ancestor since at worst
-          // some people might experience slight visual regressions on
-          // update.php.
-          continue;
-        }
         throw new MissingThemeDependencyException(sprintf('Base theme %s has not been installed.', $ancestor), $ancestor);
       }
       $base_themes[] = $themes[$ancestor];

core/modules/big_pipe/tests/themes/big_pipe_test_theme/big_pipe_test_theme.info.yml

 name: 'BigPipe test theme'
 type: theme
-base theme: stable
+base theme: stable9
 description: 'Theme for testing BigPipe edge cases.'
 version: VERSION

core/modules/block/tests/modules/block_test/themes/block_test_specialchars_theme/block_test_specialchars_theme.info.yml

 name: '<"Cat" & ''Mouse''>'
 type: theme
-base theme: stable
+base theme: stable9
 description: 'Theme for testing special characters in block admin.'
 regions:
   content: Content

core/modules/block/tests/modules/block_test/themes/block_test_theme/block_test_theme.info.yml

 name: 'Block test theme'
 type: theme
-base theme: stable
+base theme: stable9
 description: 'Theme for testing the block system'
 version: VERSION
 regions:

core/modules/block/tests/src/Functional/BlockUiTest.php

@@ -101,8 +101,8 @@ public function testBlockDemoUiPage() {
     $this->assertSession()->assertEscaped('<strong>Test theme</strong>');
 
     // Ensure that a hidden theme cannot use the block demo page.
-    \Drupal::service('theme_installer')->install(['stable']);
-    $this->drupalGet('admin/structure/block/demo/stable');
+    \Drupal::service('theme_installer')->install(['stable9']);
+    $this->drupalGet('admin/structure/block/demo/stable9');
     $this->assertSession()->statusCodeEquals(404);
   }
 
@@ -150,25 +150,25 @@ public function testBlockAdminUiPage() {
     $this->drupalPlaceBlock('local_tasks_block', ['region' => 'header', 'theme' => 'stark']);
     // We have to enable at least one extra theme that is not hidden so that
     // local tasks will show up. That's why we enable test_theme_theme.
-    \Drupal::service('theme_installer')->install(['stable', 'test_theme_theme']);
+    \Drupal::service('theme_installer')->install(['stable9', 'test_theme_theme']);
     $this->drupalGet('admin/structure/block');
     $theme_handler = \Drupal::service('theme_handler');
     $this->assertSession()->linkExists($theme_handler->getName('stark'));
     $this->assertSession()->linkExists($theme_handler->getName('test_theme_theme'));
-    $this->assertSession()->linkNotExists($theme_handler->getName('stable'));
+    $this->assertSession()->linkNotExists($theme_handler->getName('stable9'));
 
     // Ensure that a hidden theme cannot use the block demo page.
-    $this->drupalGet('admin/structure/block/list/stable');
+    $this->drupalGet('admin/structure/block/list/stable9');
     $this->assertSession()->statusCodeEquals(404);
 
     // Ensure that a hidden theme set as the admin theme can use the block demo
     // page.
-    \Drupal::configFactory()->getEditable('system.theme')->set('admin', 'stable')->save();
+    \Drupal::configFactory()->getEditable('system.theme')->set('admin', 'stable9')->save();
     \Drupal::service('router.builder')->rebuildIfNeeded();
-    $this->drupalPlaceBlock('local_tasks_block', ['region' => 'header', 'theme' => 'stable']);
+    $this->drupalPlaceBlock('local_tasks_block', ['region' => 'header', 'theme' => 'stable9']);
     $this->drupalGet('admin/structure/block');
-    $this->assertSession()->linkExists($theme_handler->getName('stable'));
-    $this->drupalGet('admin/structure/block/list/stable');
+    $this->assertSession()->linkExists($theme_handler->getName('stable9'));
+    $this->drupalGet('admin/structure/block/list/stable9');
     $this->assertSession()->statusCodeEquals(200);
   }
 

core/modules/config_translation/tests/themes/config_translation_test_theme/config_translation_test_theme.info.yml

 name: 'Configuration Translation Test Theme'
 type: theme
-base theme: stable
+base theme: stable9
 description: 'Theme for testing the configuration translation mapper system'
 version: VERSION

core/modules/help_topics/tests/themes/help_topics_test_theme/help_topics_test_theme.info.yml

 name: Test Help Topics
 type: theme
-base theme: stable
+base theme: stable9
 description: A theme to test help topics.
 version: VERSION

core/modules/statistics/tests/themes/statistics_test_attached/statistics_test_attached.info.yml

 name: 'Statistics test attached theme'
 type: theme
-base theme: stable
+base theme: stable9
 description: 'Theme for testing attached library'
 version: VERSION

core/modules/system/tests/src/Functional/System/ThemeTest.php

@@ -74,8 +74,8 @@ public function testThemeSettings() {
     $this->drupalGet('admin/appearance/settings/' . $this->randomMachineName());
     $this->assertSession()->statusCodeEquals(404);
     // Ensure a hidden theme settings form URL returns 404.
-    $this->assertTrue(\Drupal::service('theme_installer')->install(['stable']));
-    $this->drupalGet('admin/appearance/settings/stable');
+    $this->assertTrue(\Drupal::service('theme_installer')->install(['stable9']));
+    $this->drupalGet('admin/appearance/settings/stable9');
     $this->assertSession()->statusCodeEquals(404);
 
     // Specify a filesystem path to be used for the logo.
@@ -210,15 +210,15 @@ public function testThemeSettings() {
     $theme_handler = \Drupal::service('theme_handler');
     $this->assertSession()->linkExists($theme_handler->getName('starterkit_theme'));
     $this->assertSession()->linkExists($theme_handler->getName('olivero'));
-    $this->assertSession()->linkNotExists($theme_handler->getName('stable'));
+    $this->assertSession()->linkNotExists($theme_handler->getName('stable9'));
 
     // If a hidden theme is an admin theme it should be viewable.
-    \Drupal::configFactory()->getEditable('system.theme')->set('admin', 'stable')->save();
+    \Drupal::configFactory()->getEditable('system.theme')->set('admin', 'stable9')->save();
     \Drupal::service('router.builder')->rebuildIfNeeded();
-    $this->drupalPlaceBlock('local_tasks_block', ['region' => 'header', 'theme' => 'stable']);
+    $this->drupalPlaceBlock('local_tasks_block', ['region' => 'header', 'theme' => 'stable9']);
     $this->drupalGet('admin/appearance/settings');
-    $this->assertSession()->linkExists($theme_handler->getName('stable'));
-    $this->drupalGet('admin/appearance/settings/stable');
+    $this->assertSession()->linkExists($theme_handler->getName('stable9'));
+    $this->drupalGet('admin/appearance/settings/stable9');
     $this->assertSession()->statusCodeEquals(200);
 
     // Ensure default logo and favicons are not triggering custom path

core/modules/system/tests/src/FunctionalJavascript/OffCanvasTestBase.php

@@ -109,7 +109,7 @@ protected function getOffCanvasDialog() {
    *   Theme names to test.
    */
   protected function getTestThemes() {
-    return ['claro', 'olivero', 'stable', 'stark'];
+    return ['claro', 'olivero', 'stable9', 'stark'];
   }
 
   /**

core/modules/system/tests/themes/test_core_semver/test_core_semver.info.yml

 name: 'Theme test with semver core version'
 type: theme
-base theme: stable
+base theme: stable9
 description: 'Test theme which has semver core version.'
 version: VERSION
 core_version_requirement: ^8 || ^9 || ^10

core/modules/system/tests/themes/test_invalid_core_semver/test_invalid_core_semver.info.yml

 name: 'Theme test with invalid semver core version'
 type: theme
-base theme: stable
+base theme: stable9
 description: 'Test theme which has an invalid semver core version.'
 version: VERSION
 core_version_requirement: ^7

core/modules/system/tests/themes/test_invalid_region/test_invalid_region.info.yml

 name: 'Theme test with missing content region'
 type: theme
-base theme: stable
+base theme: stable9
 description: 'Test theme which has a non-existent content region.'
 version: VERSION
 regions:

core/modules/system/tests/themes/test_theme_depending_on_stable/test_theme_depending_on_stable.info.yml

-type: theme
-base theme: stable
-name: 'Test theme depending on Stable'
-version: VERSION

core/modules/system/tests/themes/test_theme_having_veery_long_name_which_is_too_long/test_theme_having_veery_long_name_which_is_too_long.info.yml

 type: theme
-base theme: stable
+base theme: stable9
 name: 'Test theme with a too long name'
 version: VERSION

core/modules/system/tests/themes/test_theme_settings_features/test_theme_settings_features.info.yml

 name: Test features
 type: theme
-base theme: stable
+base theme: stable9
 description: 'Test theme to test theme settings with limited features.'
 features:
   - node_user_picture

core/modules/system/tests/themes/test_theme_twig_registry_loader/test_theme_twig_registry_loader.info.yml

 name: 'Twig registry loader test'
 type: theme
-base theme: stable
+base theme: stable9
 description: 'Support module for Twig registry loader testing.'
 version: VERSION

core/modules/system/tests/themes/test_wild_west/test_wild_west.info.yml

 name: Test Wild West
 type: theme
-description: A theme that doesn't use Stable as its base. It tests the wild west instead.
+description: A theme that doesn't use Stable 9 as its base. It tests the wild west instead.
 version: VERSION
 base theme: false

core/modules/update/tests/themes/update_test_basetheme/update_test_basetheme.info.yml

 name: 'Update test base theme'
 type: theme
-base theme: stable
+base theme: stable9
 description: 'Test theme which acts as a base theme for other test subthemes.'
 version: VERSION

core/modules/user/tests/themes/user_test_theme/user_test_theme.info.yml

 name: 'User Test theme'
 type: theme
-base theme: stable
+base theme: stable9
 description: 'Theme for testing the available fields in user twig template'
 version: VERSION