Skip to content
Snippets Groups Projects
Commit 206d6ee6 authored by catch's avatar catch
Browse files

Issue #3192487 by andypost, murilohp, Gábor Hojtsy, daffie, pobster, apaderno:...

Issue #3192487 by andypost, murilohp, Gábor Hojtsy, daffie, pobster, apaderno: Warn about upcoming JSON database support requirement in Drupal 9
parent fe307a0f
Branches
Tags
38 merge requests!7471uncessary 5 files are moved from media-library folder to misc folder,!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!3630Issue #2815301 by Chi, DanielVeza, kostyashupenko, smustgrave: Allow to create...,!3291Issue #3336463: Rewrite rules for gzipped CSS and JavaScript aggregates never match,!3143Issue #3313342: [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1 LayoutBuilderUiCacheContext.php on line 28,!3102Issue #3164428 by DonAtt, longwave, sahil.goyal, Anchal_gupta, alexpott: Use...,!2853#3274419 Makes BaseFieldOverride inherit the internal property from the base field.,!2719Issue #3110137: Remove Classy from core.,!2437Issue #3238257 by hooroomoo, Wim Leers: Fragment link pointing to <textarea>...,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!2062Issue #3246454: Add weekly granularity to views date sort,!1974Issue #3036862 demonstration,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1254Issue #3238915: Refactor (if feasible) uses of the jQuery ready function to use VanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!873Issue #2875228: Site install not using batch API service,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!712Issue #2909128: Autocomplete intermittent on Chrome Android,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
......@@ -1849,4 +1849,19 @@ public function getPagerManager(): PagerManagerInterface {
return \Drupal::service('pager.manager');
}
/**
* Runs a simple query to validate json datatype support.
*
* @return bool
* Returns the query result.
*/
public function hasJson(): bool {
try {
return (bool) $this->query('SELECT JSON_TYPE(\'1\')');
}
catch (\Exception $e) {
return FALSE;
}
}
}
......@@ -353,6 +353,18 @@ public function rollbackSavepoint($savepoint_name = 'mimic_implicit_commit') {
}
}
/**
* {@inheritDoc}
*/
public function hasJson(): bool {
try {
return (bool) $this->query('SELECT JSON_TYPEOF(\'1\')');
}
catch (\Exception $e) {
return FALSE;
}
}
}
/**
......
......@@ -487,6 +487,22 @@ function system_requirements($phase) {
}
}
if ($phase == 'runtime') {
// Test JSON support. To be required from Drupal 10.0.
// @todo remove in https://www.drupal.org/project/drupal/issues/3203193
$requirements['database_support_json'] = [
'title' => t('Database support for JSON'),
'severity' => REQUIREMENT_OK,
'value' => t('Available'),
'description' => t('Is required in Drupal 10.0.'),
];
if (!Database::getConnection()->hasJson()) {
$requirements['database_support_json']['value'] = t('Not available');
$requirements['database_support_json']['severity'] = REQUIREMENT_WARNING;
}
}
// Test PHP memory_limit
$memory_limit = ini_get('memory_limit');
$requirements['php_memory_limit'] = [
......
......@@ -91,6 +91,14 @@ public function testStatusPage() {
$this->drupalGet('admin/reports/status');
$this->assertSession()->elementExists('xpath', '//details[contains(@class, "system-status-report__entry")]//div[contains(text(), "Cron has not run recently")]');
\Drupal::state()->set('system.cron_last', $cron_last_run);
// Check if JSON database support is enabled.
$this->assertSession()->pageTextContains('Database support for JSON');
$elements = $this->xpath('//details[@class="system-status-report__entry"]//div[contains(text(), :text)]', [
':text' => 'Is required in Drupal 10.0.',
]);
$this->assertCount(1, $elements);
$this->assertStringStartsWith('Available', $elements[0]->getParent()->getText());
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment