Verified Commit 1b74d431 authored by Dave Long's avatar Dave Long
Browse files

Issue #3516771 by mstrelan: Prevent setup tasks running for tests that are always skipped

parent a6a3415a

core/modules/announcements_feed/tests/src/FunctionalJavascript/AlertsJsonFeedTest.php

+4 −1
Changes for core/modules/announcements_feed/tests/src/FunctionalJavascript/AlertsJsonFeedTest.php: 4 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -41,6 +41,10 @@ class AlertsJsonFeedTest extends OffCanvasTestBase { 
   * {@inheritdoc}

   */

  public function setUp():void {

    if ($this->name() === 'testAnnounceFeedUpdatedAndRemoved') {

      $this->markTestSkipped('Skipped due to major version-specific logic. See https://www.drupal.org/project/drupal/issues/3359322');

    }



    parent::setUp();



    $this->user = $this->drupalCreateUser(
@@ -57,7 +61,6 @@ public function setUp():void { 
   * Check the status of the announcements when the feed is updated and removed.

   */

  public function testAnnounceFeedUpdatedAndRemoved(): void {

    $this->markTestSkipped('Skipped due to major version-specific logic. See https://www.drupal.org/project/drupal/issues/3359322');

    $this->drupalLogin($this->user);

    $this->drupalGet('<front>');

    $this->clickLink('Announcements');

core/modules/announcements_feed/tests/src/Kernel/AnnounceFetcherTest.php

+1 −2
Changes for core/modules/announcements_feed/tests/src/Kernel/AnnounceFetcherTest.php: 1 added line, 2 removed lines.
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ class AnnounceFetcherTest extends AnnounceTestBase { 
   * {@inheritdoc}

   */

  protected function setUp(): void {

    $this->markTestSkipped('Skipped due to major version-specific logic. See https://www.drupal.org/project/drupal/issues/3359322');

    parent::setUp();

    $this->installConfig(['announcements_feed']);

  }
@@ -31,7 +32,6 @@ protected function setUp(): void { 
   * @dataProvider providerShowAnnouncements

   */

  public function testShowAnnouncements(array $feed_item): void {

    $this->markTestSkipped('Skipped due to major version-specific logic. See https://www.drupal.org/project/drupal/issues/3359322');

    $this->setFeedItems([$feed_item]);

    $feeds = $this->fetchFeedItems();

    $this->assertCount(1, $feeds);
@@ -45,7 +45,6 @@ public function testShowAnnouncements(array $feed_item): void { 
   * Tests feed fields.

   */

  public function testFeedFields(): void {

    $this->markTestSkipped('Skipped due to major version-specific logic. See https://www.drupal.org/project/drupal/issues/3359322');

    $feed_item_1 = [

      'id' => '1001',

      'content_html' => 'Test teaser 1',

core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaLibraryTest.php

+4 −3
Changes for core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaLibraryTest.php: 4 added lines, 3 removed lines.
Original line number Diff line number Diff line
@@ -62,6 +62,10 @@ class MediaLibraryTest extends WebDriverTestBase { 
   * {@inheritdoc}

   */

  protected function setUp(): void {

    if ($this->name() === 'testButton') {

      $this->markTestSkipped('Skipped due to frequent random test failures. See https://www.drupal.org/i/3351597');

    }



    parent::setUp();



    FilterFormat::create([
@@ -156,9 +160,6 @@ function (ConstraintViolationInterface $v) { 
   * Tests using drupalMedia button to embed media into CKEditor 5.

   */

  public function testButton(): void {

    // Skipped due to frequent random test failures.

    // @todo Fix this and stop skipping it at https://www.drupal.org/i/3351597.

    $this->markTestSkipped();

    $media_preview_selector = '.ck-content .ck-widget.drupal-media .media';

    $this->drupalGet('/node/add/blog');

    $this->waitForEditor();

core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderUiTest.php

+4 −1
Changes for core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderUiTest.php: 4 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -48,6 +48,10 @@ class LayoutBuilderUiTest extends WebDriverTestBase { 
   * {@inheritdoc}

   */

  protected function setUp(): void {

    if ($this->name() === 'testAddHighlights') {

      $this->markTestSkipped("Skipped temporarily for random fails.");

    }



    parent::setUp();



    $this->createContentType(['type' => 'bundle_with_section_field']);
@@ -299,7 +303,6 @@ private function assertHighlightedElement(string $selector): void { 
   * Waits for the dialog to close and confirms no highlights are present.

   */

  private function assertHighlightNotExists(): void {

    $this->markTestSkipped("Skipped temporarily for random fails.");

    $assert_session = $this->assertSession();



    $assert_session->assertNoElementAfterWait('css', '#drupal-off-canvas');

core/modules/layout_builder/tests/src/FunctionalJavascript/MoveBlockFormTest.php

+2 −1
Changes for core/modules/layout_builder/tests/src/FunctionalJavascript/MoveBlockFormTest.php: 2 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -39,6 +39,8 @@ class MoveBlockFormTest extends WebDriverTestBase { 
   * {@inheritdoc}

   */

  protected function setUp(): void {

    $this->markTestSkipped("Skipped temporarily for random fails.");



    parent::setUp();

    $page = $this->getSession()->getPage();

    $assert_session = $this->assertSession();
@@ -66,7 +68,6 @@ protected function setUp(): void { 
      '.block-extra-field-blocknodebundle-with-section-fieldlinks',

      '.block-field-blocknodebundle-with-section-fieldbody',

    ];

    $this->markTestSkipped("Skipped temporarily for random fails.");

    $this->assertRegionBlocksOrder(0, 'content', $expected_block_order);



    // Add a top section using the Two column layout.