Commit 1ad1a2d9 authored by catch's avatar catch
Browse files

Issue #3257127 by bbrala, quietone, murilohp, Spokje, anabpv, catch, xjm,... 

Issue #3257127 by bbrala, quietone, murilohp, Spokje, anabpv, catch, xjm, Gábor Hojtsy, daffie, dww: Trigger a deprecation message when a deprecated module or theme is enabled
parent b74bb8fa

core/lib/Drupal/Core/Extension/ModuleInstaller.php

+3 −0
Original line number Diff line number Diff line
@@ -125,6 +125,9 @@ public function install(array $module_list, $enable_dependencies = TRUE) { 
      if ($module_data[$module]->info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] === ExtensionLifecycle::OBSOLETE) {

        throw new ObsoleteExtensionException("Unable to install modules: module '$module' is obsolete.");

      }

      if ($module_data[$module]->info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] === ExtensionLifecycle::DEPRECATED) {

        @trigger_error("The module '$module' is deprecated. See " . $module_data[$module]->info['lifecycle_link'], E_USER_DEPRECATED);

      }

    }

    if ($enable_dependencies) {

      $module_list = $module_list ? array_combine($module_list, $module_list) : [];

core/lib/Drupal/Core/Extension/ThemeInstaller.php

+4 −0
Original line number Diff line number Diff line
@@ -156,6 +156,10 @@ public function install(array $theme_list, $install_dependencies = TRUE) { 
        // machine names keys that are not in $installed_modules keys.

        $unmet_module_dependencies = array_diff_key($module_dependencies, $installed_modules);



        if ($theme_data[$theme]->info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] === ExtensionLifecycle::DEPRECATED) {

          @trigger_error("The theme '$theme' is deprecated. See " . $theme_data[$theme]->info['lifecycle_link'], E_USER_DEPRECATED);

        }



        // Prevent themes with unmet module dependencies from being installed.

        if (!empty($unmet_module_dependencies)) {

          $unmet_module_dependencies_list = implode(', ', array_keys($unmet_module_dependencies));

core/modules/config/tests/src/Functional/ConfigImportAllTest.php

+8 −3
Original line number Diff line number Diff line
@@ -4,6 +4,7 @@ 


use Drupal\Core\Config\StorageComparer;

use Drupal\Core\Entity\ContentEntityTypeInterface;

use Drupal\Core\Extension\ExtensionLifecycle;

use Drupal\Tests\SchemaCheckTestTrait;

use Drupal\Tests\system\Functional\Module\ModuleTestBase;
@@ -47,9 +48,13 @@ public function testInstallUninstall() { 
    // Get a list of modules to enable.

    $all_modules = $this->container->get('extension.list.module')->getList();

    $all_modules = array_filter($all_modules, function ($module) {

      // Filter contrib, hidden, already enabled modules and modules in the

      // Testing package.

      if ($module->origin !== 'core' || !empty($module->info['hidden']) || $module->status == TRUE || $module->info['package'] == 'Testing') {

      // Filter out contrib, hidden, testing, experimental, and deprecated

      // modules. We also don't need to enable modules that are already enabled.

      if ($module->origin !== 'core'

        || !empty($module->info['hidden'])

        || $module->status == TRUE

        || $module->info['package'] == 'Testing'

        || $module->info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] === ExtensionLifecycle::DEPRECATED) {

        return FALSE;

      }

      return TRUE;

core/modules/jsonapi/tests/src/Kernel/TestCoverageTest.php

+4 −3
Original line number Diff line number Diff line
@@ -35,13 +35,14 @@ protected function setUp(): void { 


    $all_modules = \Drupal::service('extension.list.module')->getList();

    $stable_core_modules = array_filter($all_modules, function ($module) {

      // Filter out contrib, hidden, testing, and experimental modules. We also

      // don't need to enable modules that are already enabled.

      // Filter out contrib, hidden, testing, experimental, and deprecated

      // modules. We also don't need to enable modules that are already enabled.

      return $module->origin === 'core'

        && empty($module->info['hidden'])

        && $module->status == FALSE

        && $module->info['package'] !== 'Testing'

        && $module->info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] !== ExtensionLifecycle::EXPERIMENTAL;

        && $module->info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] !== ExtensionLifecycle::EXPERIMENTAL

        && $module->info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] !== ExtensionLifecycle::DEPRECATED;

    });



    $this->container->get('module_installer')->install(array_keys($stable_core_modules));

core/modules/system/tests/src/Functional/Module/InstallUninstallTest.php

+7 −2
Original line number Diff line number Diff line
@@ -60,9 +60,14 @@ public function testInstallUninstall() { 


    $required_modules['help'] = $all_modules['help'];



    // Test uninstalling without hidden, required, and already enabled modules.

    // Filter out contrib, hidden, testing, experimental, and deprecated

    // modules. We also don't need to enable modules that are already enabled.

    $all_modules = array_filter($all_modules, function ($module) {

      if (!empty($module->info['hidden']) || !empty($module->info['required']) || $module->status == TRUE || $module->info['package'] == 'Testing') {

      if (!empty($module->info['hidden'])

        || !empty($module->info['required'])

        || $module->status == TRUE

        || $module->info['package'] === 'Testing'

        || $module->info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] === ExtensionLifecycle::DEPRECATED) {

        return FALSE;

      }

      return TRUE;