Verified Commit 13ffc8b3 authored by Dave Long's avatar Dave Long
Browse files

Issue #3546774 by mondrake: Remove class metadata from abstract test class ComposerBuildTestBase

parent 027156e5

core/.phpstan-baseline.php

+0 −6
Original line number Diff line number Diff line
@@ -45858,12 +45858,6 @@ 
	'count' => 1,

	'path' => __DIR__ . '/scripts/run-tests.sh',

];

$ignoreErrors[] = [

	'message' => '#^Abstract test class Drupal\\\\BuildTests\\\\Composer\\\\ComposerBuildTestBase must not add attribute PHPUnit\\\\Framework\\\\Attributes\\\\CoversNothing\\.$#',

	'identifier' => 'abstractTestClass.metadataForbidden',

	'count' => 1,

	'path' => __DIR__ . '/tests/Drupal/BuildTests/Composer/ComposerBuildTestBase.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\BuildTests\\\\Composer\\\\ComposerValidateTest\\:\\:provideComposerJson\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

core/tests/Drupal/BuildTests/Composer/ComposerBuildTestBase.php

+0 −2
Original line number Diff line number Diff line
@@ -5,13 +5,11 @@ 
namespace Drupal\BuildTests\Composer;



use Drupal\BuildTests\Framework\BuildTestBase;

use PHPUnit\Framework\Attributes\CoversNothing;

use Symfony\Component\Finder\Finder;



/**

 * Base class for Composer build tests.

 */

#[CoversNothing]

abstract class ComposerBuildTestBase extends BuildTestBase {



  /**

core/tests/Drupal/BuildTests/Composer/Template/ComposerProjectTemplatesTest.php

+2 −0
Original line number Diff line number Diff line
@@ -8,6 +8,7 @@ 
use Composer\Semver\VersionParser;

use Drupal\BuildTests\Composer\ComposerBuildTestBase;

use Drupal\Composer\Composer;

use PHPUnit\Framework\Attributes\CoversNothing;

use PHPUnit\Framework\Attributes\DataProvider;

use PHPUnit\Framework\Attributes\Group;
@@ -24,6 +25,7 @@ 
 * This is because Composer only uses the packages.json file to resolve the

 * project template and not any other dependencies.

 */

#[CoversNothing]

#[Group('Template')]

class ComposerProjectTemplatesTest extends ComposerBuildTestBase {