Verified Commit 11842ed3 authored by Lauri Timmanee's avatar Lauri Timmanee
Browse files

Issue #3374878 by Spokje: Fix PHPStan L1 errors "Offset 'foo' on array{} in... 

Issue #3374878 by Spokje: Fix PHPStan L1 errors "Offset 'foo' on array{} in isset() does not exist."

(cherry picked from commit 985b1efa)
parent 7ec47764

core/modules/views/tests/src/Kernel/Handler/AreaDisplayLinkTest.php

+3 −1
Original line number Diff line number Diff line
@@ -308,7 +308,9 @@ public function testAreaDisplayLink() { 
  protected function assertFormOptions(ViewExecutable $view, string $display_link_id): void {

    $form = [];

    $form_state = new FormState();

    $view->display_handler->getHandler('header', $display_link_id)->buildOptionsForm($form, $form_state);

    /** @var \Drupal\views\Plugin\views\area\DisplayLink $display_handler */

    $display_handler = $view->display_handler->getHandler('header', $display_link_id);

    $display_handler->buildOptionsForm($form, $form_state);

    $this->assertTrue(isset($form['display_id']['#options']['page_1']));

    $this->assertTrue(isset($form['display_id']['#options']['page_2']));

    $this->assertFalse(isset($form['display_id']['#options']['block_1']));

core/modules/views/tests/src/Kernel/Handler/AreaEntityTest.php

+3 −1
Original line number Diff line number Diff line
@@ -179,7 +179,9 @@ public function doTestRender($entities) { 
    $form = [];

    $form_state = (new FormState())

      ->set('type', 'header');

    $view->display_handler->getHandler('header', 'entity_entity_test')->buildOptionsForm($form, $form_state);

    /** @var \Drupal\views\Plugin\views\area\DisplayLink $display_handler */

    $display_handler = $view->display_handler->getHandler('header', 'entity_entity_test');

    $display_handler->buildOptionsForm($form, $form_state);

    $this->assertTrue(isset($form['view_mode']['#options']['test']), 'Ensure that the test view mode is available.');

    $this->assertTrue(isset($form['view_mode']['#options']['default']), 'Ensure that the default view mode is available.');

  }

core/phpstan-baseline.neon

+0 −10
Original line number Diff line number Diff line
@@ -2540,16 +2540,6 @@ parameters: 
			count: 2

			path: modules/views/tests/src/FunctionalJavascript/ClickSortingAJAXTest.php



		-

			message: "#^Offset 'display_id' on array\\{\\} in isset\\(\\) does not exist\\.$#"

			count: 1

			path: modules/views/tests/src/Kernel/Handler/AreaDisplayLinkTest.php



		-

			message: "#^Offset 'view_mode' on array\\{\\} in isset\\(\\) does not exist\\.$#"

			count: 1

			path: modules/views/tests/src/Kernel/Handler/AreaEntityTest.php



		-

			message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:11\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#"

			count: 3