Verified Commit 10466dba authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3420972 by quietone, andypost, smustgrave, catch, daffie: Add testing wtih SQLite 3.45

parent 41e2fd07

.gitlab-ci.yml

+7 −7
Original line number Diff line number Diff line
@@ -229,10 +229,10 @@ default: 
    _TARGET_PHP: "8.3"

    _TARGET_DB: "pgsql-16"



'PHP 8.3 SQLite 3':

'PHP 8.3 SQLite 3.45':

  <<: [ *default-stage, *run-on-mr ]

  variables:

    _TARGET_PHP: "8.3"

    _TARGET_PHP: "8.3-ubuntu"

    _TARGET_DB: "sqlite-3"



# Jobs running on commits.
@@ -247,8 +247,8 @@ default: 
  needs: [ '[Commit] PHP 8.3 MySQL 5.7' ]

  <<: [ *run-on-commit ]



'[Commit] PHP 8.3 SQLite 3':

  extends: 'PHP 8.3 SQLite 3'

'[Commit] PHP 8.3 SQLite 3.45':

  extends: 'PHP 8.3 SQLite 3.45'

  needs: [ '[Commit] PHP 8.3 PostgreSQL 16' ]

  <<: [ *run-on-commit ]
@@ -259,14 +259,14 @@ default: 
  needs: [ 'DEFAULT: PHP 8.3 MySQL 8' ]

  <<: [ *run-daily ]



'[Daily] PHP 8.3 SQLite 3':

  extends: 'PHP 8.3 SQLite 3'

'[Daily] PHP 8.3 SQLite 3.45':

  extends: 'PHP 8.3 SQLite 3.45'

  needs: [ '[Daily] PHP 8.3 PostgreSQL 16' ]

  <<: [ *run-daily ]



'[Daily] PHP 8.3 MariaDB 10.3.22':

  extends: 'PHP 8.3 MariaDB 10.3.22'

  needs: [ '[Daily] PHP 8.3 SQLite 3' ]

  needs: [ '[Daily] PHP 8.3 SQLite 3.45' ]

  <<: [ *run-daily ]



################

core/modules/sqlite/src/Driver/Database/sqlite/Install/Tasks.php

+1 −1
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ class Tasks extends InstallTasks { 
   * Use to build sqlite library with json1 option for JSON datatype support.

   * @see https://www.sqlite.org/json1.html

   */

  const SQLITE_MINIMUM_VERSION = '3.26';

  const SQLITE_MINIMUM_VERSION = '3.45';



  /**

   * {@inheritdoc}

core/tests/Drupal/BuildTests/TestSiteApplication/InstallTest.php

+5 −0
Original line number Diff line number Diff line
@@ -5,6 +5,7 @@ 
namespace Drupal\BuildTests\TestSiteApplication;



use Drupal\BuildTests\Framework\BuildTestBase;

use Drupal\sqlite\Driver\Database\sqlite\Install\Tasks;

use Symfony\Component\Filesystem\Filesystem;

use Symfony\Component\Process\PhpExecutableFinder;
@@ -15,6 +16,10 @@ 
class InstallTest extends BuildTestBase {



  public function testInstall() {

    $sqlite = (new \PDO('sqlite::memory:'))->query('select sqlite_version()')->fetch()[0];

    if (version_compare($sqlite, Tasks::SQLITE_MINIMUM_VERSION) < 0) {

      $this->markTestSkipped();

    }

    $this->copyCodebase();

    $fs = new Filesystem();

    $fs->chmod($this->getWorkspaceDirectory() . '/sites/default', 0700, 0000);