Issue #315302 by mstrelan, tacituseu, PaulMagrath, coltrane, yched,...

Issue #315302 by mstrelan, tacituseu, PaulMagrath, coltrane, yched, DamienMcKenna, quietone: Node Access Rebuild never finishes (infinite loop)

(cherry picked from commit f221e075)

core/modules/node/node.module

@@ -1179,10 +1179,11 @@ function _node_access_rebuild_batch_operation(&$context) {
     ->execute();
   $node_storage->resetCache($nids);
   $nodes = Node::loadMultiple($nids);
-  foreach ($nodes as $nid => $node) {
+  foreach ($nids as $nid) {
     // To preserve database integrity, only write grants if the node
     // loads successfully.
-    if (!empty($node)) {
+    if (!empty($nodes[$nid])) {
+      $node = $nodes[$nid];
       /** @var \Drupal\node\NodeAccessControlHandlerInterface $access_control_handler */
       $access_control_handler = \Drupal::entityTypeManager()->getAccessControlHandler('node');
       $grants = $access_control_handler->acquireGrants($node);

core/phpstan-baseline.neon

@@ -1675,11 +1675,6 @@ parameters:
 			count: 1
 			path: modules/node/node.module
 
-		-
-			message: "#^Variable \\$node in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: modules/node/node.module
-
 		-
 			message: "#^Method Drupal\\\\node\\\\ConfigTranslation\\\\NodeTypeMapper\\:\\:setEntity\\(\\) should return bool but return statement is missing\\.$#"
 			count: 1