Verified Commit 09367101 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3273325 by Dom., Wim Leers, andregp, ifrik: CKE5 and contrib: better... 

Issue #3273325 by Dom., Wim Leers, andregp, ifrik: CKE5 and contrib: better "next action" description on upgrade path messages

(cherry picked from commit dafde755)
parent 12e8b703

core/modules/ckeditor5/src/Plugin/Editor/CKEditor5.php

+10 −2
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ 
use Drupal\Core\Form\SubformState;

use Drupal\Core\Form\SubformStateInterface;

use Drupal\Core\Language\LanguageManagerInterface;

use Drupal\Core\Messenger\MessengerInterface;

use Drupal\Core\Plugin\ContainerFactoryPluginInterface;

use Drupal\ckeditor5\SmartDefaultSettings;

use Drupal\Core\Validation\Plugin\Validation\Constraint\PrimitiveTypeConstraint;
@@ -263,8 +264,15 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta 
      assert($editor->getSettings() === $this->getDefaultSettings());

      if (!$format->isNew()) {

        [$editor, $messages] = $this->smartDefaultSettings->computeSmartDefaultSettings($editor, $format);

        foreach ($messages as $message) {

          $this->messenger()->addMessage($message);

        foreach ($messages as $type => $messages_per_type) {

          foreach ($messages_per_type as $message) {

            $this->messenger()->addMessage($message, $type);

          }

        }

        if (isset($messages[MessengerInterface::TYPE_WARNING]) || isset($messages[MessengerInterface::TYPE_ERROR])) {

          $this->messenger()->addMessage($this->t('Check <a href=":handbook">this handbook page</a> for details about compatibility issues of contrib modules.', [

            ':handbook' => 'https://www.drupal.org/node/3273985',

          ]), MessengerInterface::TYPE_WARNING);

        }

      }

      $eventual_editor_and_format = $this->getEventualEditorWithPrimedFilterFormat($form_state, $editor);

core/modules/ckeditor5/src/SmartDefaultSettings.php

+9 −8
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ 
use Drupal\ckeditor5\Plugin\CKEditor5PluginManagerInterface;

use Drupal\Component\Assertion\Inspector;

use Drupal\Component\Plugin\PluginManagerInterface;

use Drupal\Core\Messenger\MessengerInterface;

use Drupal\Core\StringTranslation\StringTranslationTrait;

use Drupal\editor\EditorInterface;

use Drupal\editor\Entity\Editor;
@@ -141,27 +142,27 @@ public function computeSmartDefaultSettings(?EditorInterface $text_editor, Filte 
      $unsupported = $missing->diff($missing_attributes);



      if ($enabling_message_content) {

        $messages[] = $this->t('The following plugins were enabled to support tags that are allowed by this text format: %enabling_message_content.',

        $messages[MessengerInterface::TYPE_STATUS][] = $this->t('The following plugins were enabled to support tags that are allowed by this text format: %enabling_message_content.',

          ['%enabling_message_content' => $enabling_message_content],

        );

      }

      // Warn user about unsupported tags.

      if (!$unsupported->isEmpty()) {

        $this->addTagsToSourceEditing($editor, $unsupported);

        $messages[] = $this->t("The following tags were permitted by this format's filter configuration, but no plugin was available that supports them. To ensure the tags remain supported by this text format, the following were added to the Source Editing plugin's <em>Manually editable HTML tags</em>: @unsupported_string.", [

        $messages[MessengerInterface::TYPE_STATUS][] = $this->t("The following tags were permitted by this format's filter configuration, but no plugin was available that supports them. To ensure the tags remain supported by this text format, the following were added to the Source Editing plugin's <em>Manually editable HTML tags</em>: @unsupported_string.", [

          '@unsupported_string' => $unsupported->toFilterHtmlAllowedTagsString(),

        ]);

      }



      if ($enabled_for_attributes_message_content) {

        $messages[] = $this->t('The following plugins were enabled to support specific attributes that are allowed by this text format: %enabled_for_attributes_message_content.',

        $messages[MessengerInterface::TYPE_STATUS][] = $this->t('The following plugins were enabled to support specific attributes that are allowed by this text format: %enabled_for_attributes_message_content.',

          ['%enabled_for_attributes_message_content' => $enabled_for_attributes_message_content],

        );

      }

      // Warn user about supported tags but missing attributes.

      if (!$missing_attributes->isEmpty()) {

        $this->addTagsToSourceEditing($editor, $missing_attributes);

        $messages[] = $this->t("This format's HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin's <em>Manually editable HTML tags</em>: @missing_attributes.", [

        $messages[MessengerInterface::TYPE_STATUS][] = $this->t("This format's HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin's <em>Manually editable HTML tags</em>: @missing_attributes.", [

          '@missing_attributes' => $missing_attributes->toFilterHtmlAllowedTagsString(),

        ]);

      }
@@ -181,7 +182,7 @@ private function addTagsToSourceEditing(EditorInterface $editor, HTMLRestriction 
    $messages = [];

    $settings = $editor->getSettings();

    if (!isset($settings['toolbar']['items']) || !in_array('sourceEditing', $settings['toolbar']['items'])) {

      $messages[] = $this->t('The <em>Source Editing</em> plugin was enabled to support tags and/or attributes that are not explicitly supported by any available CKEditor 5 plugins.');

      $messages[MessengerInterface::TYPE_STATUS][] = $this->t('The <em>Source Editing</em> plugin was enabled to support tags and/or attributes that are not explicitly supported by any available CKEditor 5 plugins.');

      $settings['toolbar']['items'][] = 'sourceEditing';

    }

    $allowed_tags_array = $settings['plugins']['ckeditor5_sourceEditing']['allowed_tags'] ?? [];
@@ -232,7 +233,7 @@ private function createSettingsFromCKEditor4(array $ckeditor4_settings, array $e 
            $equivalent = $this->upgradePluginManager->mapCKEditor4ToolbarButtonToCKEditor5ToolbarItem($cke4_button, $text_format_html_restrictions);

          }

          catch (\OutOfBoundsException $e) {

            $messages[] = $this->t('The CKEditor 4 button %button does not have a known upgrade path. If it allowed editing markup, then you can do so now through the Source Editing functionality.', [

            $messages[MessengerInterface::TYPE_WARNING][] = $this->t('The CKEditor 4 button %button does not have a known upgrade path. If it allowed editing markup, then you can do so now through the Source Editing functionality.', [

              '%button' => $cke4_button,

            ]);

            continue;
@@ -270,7 +271,7 @@ private function createSettingsFromCKEditor4(array $ckeditor4_settings, array $e 
        $settings['plugins'] += $cke5_plugin_settings;

      }

      catch (\OutOfBoundsException $e) {

        $messages[] = $this->t('The %cke4_plugin_id plugin settings do not have a known upgrade path.', [

        $messages[MessengerInterface::TYPE_WARNING][] = $this->t('The %cke4_plugin_id plugin settings do not have a known upgrade path.', [

          '%cke4_plugin_id' => $cke4_plugin_id,

        ]);

        continue;
@@ -762,7 +763,7 @@ private function computeSubsetSettingForEnabledPluginsWithSubsets(EditorInterfac 
        $subset_configuration = $this->upgradePluginManager->computeCKEditor5PluginSubsetConfiguration($plugin_name, $text_format);

      }

      catch (\OutOfBoundsException $e) {

        $messages[] = $this->t('The CKEditor 5 plugin %button has a configurable subset of elements, but does not have a known upgrade path to configure that subset to match your text format. Hence it is now using its default configuration.', [

        $messages[MessengerInterface::TYPE_WARNING][] = $this->t('The CKEditor 5 plugin %button has a configurable subset of elements, but does not have a known upgrade path to configure that subset to match your text format. Hence it is now using its default configuration.', [

          '%plugin' => $plugin_name,

        ]);

        continue;

core/modules/ckeditor5/tests/src/Kernel/SmartDefaultSettingsTest.php

+68 −39
Original line number Diff line number Diff line
@@ -404,9 +404,13 @@ public function test(string $format_id, array $filters_to_drop, array $expected_ 
    // The resulting pair should be valid.

    $this->assertSame([], $this->validatePairToViolationsArray($updated_text_editor, $updated_text_format, TRUE));



    foreach ($messages as $key => $message) {

      $messages[$key] = (string) $message;

    // Transforms TranslatableMarkup objects to string.

    foreach ($messages as $type => $messages_per_type) {

      foreach ($messages_per_type as $key => $message) {

        $messages[$type][$key] = (string) $message;

      }

    }



    $this->assertSame($expected_messages, $messages);

  }
@@ -484,17 +488,21 @@ public function provider() { 
      'expected_superset' => '<span lang dir>',

      'expected_fundamental_compatibility_violations' => [],

      'expected_messages' => [

        'status' => [

          'The following plugins were enabled to support tags that are allowed by this text format: <em class="placeholder">Code (for tags: &lt;code&gt;) Language (for tags: &lt;span&gt;)</em>.',

          'The following tags were permitted by this format\'s filter configuration, but no plugin was available that supports them. To ensure the tags remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;cite&gt; &lt;dl&gt; &lt;dt&gt; &lt;dd&gt;.',

        ],

      ],

    ];



    yield "basic_html can be switched to CKEditor 5 without problems (3 upgrade messages)" => NestedArray::mergeDeep(

      $basic_html_test_case,

      [

        'expected_messages' => [

          'status' => [

            'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt; &lt;h2 id&gt; &lt;h3 id&gt; &lt;h4 id&gt; &lt;h5 id&gt; &lt;h6 id&gt;.',

          ],

        ],

      ]

    );
@@ -514,8 +522,10 @@ public function provider() { 
          ],

        ],

        'expected_messages' => [

          'status' => [

            'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt; &lt;h2 id&gt; &lt;h3 id&gt; &lt;h4 id&gt; &lt;h5 id&gt; &lt;h6 id&gt; &lt;img data-caption&gt;.',

          ],

        ],

      ]);



    yield "basic_html with filter_align removed => disallows <img data-align> => supported through sourceEditing (3 upgrade messages) " => NestedArray::mergeDeep(
@@ -534,8 +544,10 @@ public function provider() { 
          ],

        ],

        'expected_messages' => [

          'status' => [

            'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt; &lt;h2 id&gt; &lt;h3 id&gt; &lt;h4 id&gt; &lt;h5 id&gt; &lt;h6 id&gt; &lt;img data-align&gt;.',

          ],

        ],

      ]);



    yield "basic_html_without_h4_h6 can be switched to CKEditor 5 without problems, heading configuration computed automatically" => [
@@ -563,10 +575,11 @@ public function provider() { 
      ],

      'expected_superset' => $basic_html_test_case['expected_superset'],

      'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],

      'expected_messages' => array_merge(

        $basic_html_test_case['expected_messages'],

        ['This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt; &lt;h2 id&gt; &lt;h3 id&gt; &lt;h5 id&gt;.'],

      ),

      'expected_messages' => array_merge_recursive($basic_html_test_case['expected_messages'], [

        'status' => [

          'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt; &lt;h2 id&gt; &lt;h3 id&gt; &lt;h5 id&gt;.',

        ],

      ]),

    ];



    yield "basic_html_with_h1 can be switched to CKEditor 5 without problems, heading configuration computed automatically" => [
@@ -594,10 +607,11 @@ public function provider() { 
      ],

      'expected_superset' => $basic_html_test_case['expected_superset'],

      'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],

      'expected_messages' => array_merge(

        $basic_html_test_case['expected_messages'],

        ['This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt; &lt;h2 id&gt; &lt;h3 id&gt; &lt;h4 id&gt; &lt;h5 id&gt; &lt;h6 id&gt;.'],

      ),

      'expected_messages' => array_merge_recursive($basic_html_test_case['expected_messages'], [

        'status' => [

          'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt; &lt;h2 id&gt; &lt;h3 id&gt; &lt;h4 id&gt; &lt;h5 id&gt; &lt;h6 id&gt;.',

        ],

      ]),

    ];



    yield "basic_html_without_headings can be switched to CKEditor 5 without problems, heading configuration computed automatically" => [
@@ -623,10 +637,11 @@ public function provider() { 
      ],

      'expected_superset' => $basic_html_test_case['expected_superset'],

      'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],

      'expected_messages' => array_merge(

        $basic_html_test_case['expected_messages'],

        ['This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt;.'],

      ),

      'expected_messages' => array_merge_recursive($basic_html_test_case['expected_messages'], [

        'status' => [

          'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt;.',

        ],

      ]),

    ];



    yield "basic_html_with_pre can be switched to CKEditor 5 without problems, heading configuration computed automatically" => [
@@ -644,10 +659,12 @@ public function provider() { 
      'expected_superset' => '<code class="language-*"> ' . $basic_html_test_case['expected_superset'],

      'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],

      'expected_messages' => [

        'status' => [

          'The following plugins were enabled to support tags that are allowed by this text format: <em class="placeholder">Code (for tags: &lt;code&gt;) Language (for tags: &lt;span&gt;) Code Block (for tags: &lt;pre&gt;)</em>.',

        $basic_html_test_case['expected_messages'][1],

          $basic_html_test_case['expected_messages']['status'][1],

          'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt; &lt;h2 id&gt; &lt;h3 id&gt; &lt;h4 id&gt; &lt;h5 id&gt; &lt;h6 id&gt;.',

        ],

      ],

    ];



    yield "basic_html_with_alignable_p can be switched to CKEditor 5 without problems, align buttons added automatically" => [
@@ -682,11 +699,11 @@ public function provider() { 
        $basic_html_test_case['expected_superset'],

      ]),

      'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],

      'expected_messages' => array_merge($basic_html_test_case['expected_messages'],



        [

      'expected_messages' => array_merge_recursive($basic_html_test_case['expected_messages'], [

        'status' => [

          'The following plugins were enabled to support specific attributes that are allowed by this text format: <em class="placeholder">Align center ( for tag: &lt;p&gt; to support: class with value(s):  text-align-center), Justify ( for tag: &lt;p&gt; to support: class with value(s):  text-align-justify)</em>.',

          'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt; &lt;h2 id&gt; &lt;h3 id&gt; &lt;h4 id&gt; &lt;h5 id&gt; &lt;h6 id&gt;.',

        ],

      ]),

    ];
@@ -706,8 +723,10 @@ public function provider() { 
      // @todo: Remove data-view-mode in https://www.drupal.org/project/drupal/issues/3269657.

      'expected_superset' => $basic_html_test_case['expected_superset'] . ' <drupal-media data-view-mode>',

      'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],

      'expected_messages' => array_merge($basic_html_test_case['expected_messages'], [

      'expected_messages' => array_merge_recursive($basic_html_test_case['expected_messages'], [

        'status' => [

          "This format's HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin's <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt; &lt;h2 id&gt; &lt;h3 id&gt; &lt;h4 id&gt; &lt;h5 id&gt; &lt;h6 id&gt;.",

        ],

      ]),

    ];
@@ -727,9 +746,10 @@ public function provider() { 
      ],

      'expected_superset' => $basic_html_test_case['expected_superset'],

      'expected_fundamental_compatibility_violations' => $basic_html_test_case['expected_fundamental_compatibility_violations'],

      'expected_messages' => array_merge($basic_html_test_case['expected_messages'],

        [

      'expected_messages' => array_merge_recursive($basic_html_test_case['expected_messages'], [

        'status' => [

          'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt; &lt;h2 id&gt; &lt;h3 id&gt; &lt;h4 id&gt; &lt;h5 id&gt; &lt;h6 id&gt; &lt;img data-*&gt;.',

        ],

      ]),

    ];
@@ -793,10 +813,15 @@ public function provider() { 
        '' => 'CKEditor 5 needs at least the &lt;p&gt; and &lt;br&gt; tags to be allowed to be able to function. They are not allowed by the "<em class="placeholder">Limit allowed HTML tags and correct faulty HTML</em>" (<em class="placeholder">filter_html</em>) filter.',

      ],

      'expected_messages' => [

        'status' => [

          'The following plugins were enabled to support tags that are allowed by this text format: <em class="placeholder">Link (for tags: &lt;a&gt;) Block quote (for tags: &lt;blockquote&gt;) Code (for tags: &lt;code&gt;) List (for tags: &lt;ul&gt;&lt;ol&gt;&lt;li&gt;)</em>.',

          'The following tags were permitted by this format\'s filter configuration, but no plugin was available that supports them. To ensure the tags remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;cite&gt; &lt;dl&gt; &lt;dt&gt; &lt;dd&gt;.',

          'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type&gt; &lt;h2 id&gt; &lt;h3 id&gt; &lt;h4 id&gt; &lt;h5 id&gt; &lt;h6 id&gt;.',

        ],

      ],

      'expected_post_filter_drop_fundamental_compatibility_violations' => [

        '' => 'CKEditor 5 needs at least the &lt;p&gt; and &lt;br&gt; tags to be allowed to be able to function. They are not allowed by the "<em class="placeholder">Limit allowed HTML tags and correct faulty HTML</em>" (<em class="placeholder">filter_html</em>) filter.',

      ],

    ];



    yield "full_html can be switched to CKEditor 5 (no upgrade messages)" => [
@@ -905,10 +930,12 @@ public function provider() { 
        '' => 'CKEditor 5 needs at least the &lt;p&gt; and &lt;br&gt; tags to be allowed to be able to function. They are not allowed by the "<em class="placeholder">Limit allowed HTML tags and correct faulty HTML</em>" (<em class="placeholder">filter_html</em>) filter.',

      ],

      'expected_messages' => [

        'status' => [

          'The following plugins were enabled to support tags that are allowed by this text format: <em class="placeholder">Link (for tags: &lt;a&gt;) Block quote (for tags: &lt;blockquote&gt;) Code (for tags: &lt;code&gt;) List (for tags: &lt;ul&gt;&lt;ol&gt;&lt;li&gt;)</em>.',

          'The following tags were permitted by this format\'s filter configuration, but no plugin was available that supports them. To ensure the tags remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;cite&gt; &lt;dl&gt; &lt;dt&gt; &lt;dd&gt;.',

          'This format\'s HTML filters includes plugins that support the following tags, but not some of their attributes. To ensure these attributes remain supported by this text format, the following were added to the Source Editing plugin\'s <em>Manually editable HTML tags</em>: &lt;a hreflang&gt; &lt;blockquote cite&gt; &lt;ul type&gt; &lt;ol start type=&quot;1 A I&quot;&gt; &lt;h2 id=&quot;jump-*&quot;&gt; &lt;h3 id&gt; &lt;h4 id&gt; &lt;h5 id&gt; &lt;h6 id&gt;.',

        ],

      ],

    ];



    yield "cke4_plugins_with_settings can be switched to CKEditor 5 without problems, settings are upgraded too" => [
@@ -929,9 +956,11 @@ public function provider() { 
      'expected_superset' => '',

      'expected_fundamental_compatibility_violations' => [],

      'expected_messages' => [

        'warning' => [

          'The CKEditor 4 button <em class="placeholder">Llama</em> does not have a known upgrade path. If it allowed editing markup, then you can do so now through the Source Editing functionality.',

          'The <em class="placeholder">llama_contextual_and_button</em> plugin settings do not have a known upgrade path.',

        ],

      ],

    ];



    yield "cke4_plugins_with_settings_for_disabled_plugins can be switched to CKEditor 5 without problems; irrelevant settings are dropped" => [