Skip to content
Snippets Groups Projects
Unverified Commit 0926b0cc authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3221933 by marcoscano, alexpott, owenbush: PHP Notice when using...

Issue #3221933 by marcoscano, alexpott, owenbush: PHP Notice when using "left_formula" in views join
parent 3e4b17a7
No related branches found
No related tags found
18 merge requests!12227Issue #3181946 by jonmcl, mglaman,!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!1896Issue #2940605: Can only intentionally re-render an entity with references 20 times,!1101Issue #2412669 by claudiu.cristea, Julfabre, sidharrell, catch, daffie,...,!1039Issue #2556069 by claudiu.cristea, bnjmnm, lauriii, pfrenssen, Tim Bozeman,...,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!1012Issue #3226887: Hreflang on non-canonical content pages,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!594Put each entity type table into a details element on admin/config/regional/content-language,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!512Issue #3207771: Menu UI node type form documentation points to non-existent function,!485Sets the autocomplete attribute for username/password input field on login form.,!449Issue #2784233: Allow multiple vocabularies in the taxonomy filter,!231Issue #2671162: summary text wysiwyg patch working fine on 9.2.0-dev,!43Resolve #3173180: Add UI for 'loading' html attribute to images,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
......@@ -266,7 +266,11 @@ public function __construct(array $configuration, $plugin_id, $plugin_definition
}
$this->leftTable = $configuration['left_table'];
$this->leftField = $configuration['left_field'];
if (!empty($configuration['left_field'])) {
$this->leftField = $configuration['left_field'];
}
$this->field = $configuration['field'];
if (!empty($configuration['left_formula'])) {
......
......@@ -205,6 +205,8 @@ public function testBasePlugin() {
// Test that joins using 'left_formula' are properly built.
$configuration['left_formula'] = 'MAX(views_test_data.uid)';
// When 'left_formula' is present, 'left_field' is no longer required.
unset($configuration['left_field']);
$join = $this->manager->createInstance('standard', $configuration);
$table = ['alias' => 'users6'];
$join->buildJoin($query, $table, $view->query);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment