Skip to content
Snippets Groups Projects
Verified Commit 07eea76d authored by Dave Long's avatar Dave Long
Browse files

Issue #3310170 follow-up by nicxvan, godotislate: Use UUID as entity ID 

(cherry picked from commit b5c5a2a3)
parent 9b1a9796
No related branches found
No related tags found
23 merge requests!11636Draft: Issue #3515643 by macsim: fieldNameExists method is inconsistent,!11515Issue #3480419 by mondrake, smustgrave, catch: Method...,!11380Issue #3490698 by catch, spokje: Bump MINIMUM_STABILITY back to 'stable' when...,!11281Use Drupal Core Leadership terminology in MAINTAINERS.txt,!11239Issue #3507548: Allow workspace changes listing to show all items, without a pager,!11238Fix issue #3051797,!11213Issue #3506743 by tomislav.matokovic: Increasing the color contrast for the navigation block title against the background of the navigation sidebar to at least 4.5:1,!11147Draft: Try to avoid manually setting required cache contexts,!11108Issue #3490298 by nicxvan: Profiles can be missed in OOP hooks,!11093Drupal on MongoDB 11.1.x,!11017Issue #3502540: Add date filter for moderated content.,!11009Issue #3486972 migrate feed icon,!10999Cleaning up Taxonomy hooks and updating baseline.,!10977Issue #3501457: Fix path used in a A11y Test Admin,!10881Issue #3489329 by mfb, casey: symfony/http-foundation commit 32310ff breaks PathValidator,!10570Issue #3494197: Convert Twig engine hooks,!10567Issue #3494154: Index is not added if entity doesn't support revisions,!10548Revert "Issue #3478621 by catch, longwave, nicxvan: Add filecache to OOP hook attribute parsing",!10404Margin has been added,!10391Issue #3485117 by nexusnovaz, godotislate, nicxvan: Fix return type on...,!10388Issue #3485117 by nexusnovaz, godotislate, nicxvan: Fix return type on...,!10376Issue #3485117 by nexusnovaz, godotislate, nicxvan: Fix return type on...,!10237Issue #3484105 by nicxvan, godotislate: Automatically included .inc files are no longer included
Pipeline #336974 canceled
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal

#336977

    Hide whitespace changes
    Inline Side-by-side
    core/.phpstan-baseline.php
    + 0
    − 138
    View file @ 07eea76d
    ......@@ -16678,12 +16678,6 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/contact/tests/modules/contact_storage_test/contact_storage_test.module',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\contact\\\\Functional\\\\ContactLanguageTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/contact/tests/src/Functional/ContactLanguageTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\contact\\\\Functional\\\\ContactPersonalTest\\:\\:assertCacheContext\\(\\) has no return type specified\\.$#',
    ......@@ -17644,24 +17638,6 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/content_moderation/tests/src/Functional/ModerationContentTranslationTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\content_moderation\\\\Functional\\\\ModerationContentTranslationTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/content_moderation/tests/src/Functional/ModerationContentTranslationTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\content_moderation\\\\Functional\\\\ModerationFormTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/content_moderation/tests/src/Functional/ModerationFormTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\content_moderation\\\\Functional\\\\ModerationLocaleTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/content_moderation/tests/src/Functional/ModerationLocaleTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\content_moderation\\\\Functional\\\\ModerationRevisionRevertTest\\:\\:addEntityTypeAndBundleToWorkflow\\(\\) has no return type specified\\.$#',
    ......@@ -18628,30 +18604,12 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/content_translation/tests/modules/content_translation_test/content_translation_test.module',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\content_translation\\\\Functional\\\\ContentTranslationContextualLinksTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/content_translation/tests/src/Functional/ContentTranslationContextualLinksTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\content_translation\\\\Functional\\\\ContentTranslationLanguageChangeTest\\:\\:createImageField\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/content_translation/tests/src/Functional/ContentTranslationLanguageChangeTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\content_translation\\\\Functional\\\\ContentTranslationLanguageChangeTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/content_translation/tests/src/Functional/ContentTranslationLanguageChangeTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\content_translation\\\\Functional\\\\ContentTranslationOperationsTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/content_translation/tests/src/Functional/ContentTranslationOperationsTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\content_translation\\\\Functional\\\\ContentTranslationPendingRevisionTestBase\\:\\:addEntityTypeAndBundleToWorkflow\\(\\) has no return type specified\\.$#',
    ......@@ -18880,12 +18838,6 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/content_translation/tests/src/Functional/ContentTranslationUITestBase.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\content_translation\\\\Functional\\\\ContentTranslationUntranslatableFieldsTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/content_translation/tests/src/Functional/ContentTranslationUntranslatableFieldsTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\content_translation\\\\Functional\\\\ContentTranslationWorkflowsTest\\:\\:assertCacheContext\\(\\) has no return type specified\\.$#',
    ......@@ -20230,12 +20182,6 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/field/tests/src/Functional/EntityReference/EntityReferenceFieldTranslatedReferenceViewTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\field\\\\Functional\\\\EntityReference\\\\EntityReferenceFieldTranslatedReferenceViewTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/field/tests/src/Functional/EntityReference/EntityReferenceFieldTranslatedReferenceViewTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\field\\\\Functional\\\\EntityReference\\\\EntityReferenceIntegrationTest\\:\\:assertConfigEntityImport\\(\\) has no return type specified\\.$#',
    ......@@ -22456,12 +22402,6 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/file/tests/src/Functional/FileManagedTestBase.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\file\\\\Functional\\\\FileOnTranslatedEntityTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/file/tests/src/Functional/FileOnTranslatedEntityTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: method.notFound
    'message' => '#^Call to an undefined method Drupal\\\\Tests\\\\file\\\\Functional\\\\FileUploadJsonBasicAuthTest\\:\\:getExpectedUnauthorizedEntityAccessCacheability\\(\\)\\.$#',
    ......@@ -22504,12 +22444,6 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/file/tests/src/Functional/FileUploadJsonCookieTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\file\\\\Functional\\\\PrivateFileOnTranslatedEntityTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/file/tests/src/Functional/PrivateFileOnTranslatedEntityTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\file\\\\Functional\\\\Rest\\\\FileJsonAnonTest\\:\\:assertAuthenticationEdgeCases\\(\\) has no return type specified\\.$#',
    ......@@ -24268,12 +24202,6 @@
    'count' => 2,
    'path' => __DIR__ . '/modules/image/tests/src/Functional/ImageFieldValidateTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\image\\\\Functional\\\\ImageOnTranslatedEntityTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/image/tests/src/Functional/ImageOnTranslatedEntityTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\image\\\\Functional\\\\ImageStyleFlushTest\\:\\:createSampleImage\\(\\) has no return type specified\\.$#',
    ......@@ -26248,12 +26176,6 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/language/tests/src/Functional/LanguageConfigSchemaTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\language\\\\Functional\\\\LanguageSelectorTranslatableTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/language/tests/src/Functional/LanguageSelectorTranslatableTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\language\\\\Functional\\\\LanguageSelectorTranslatableTest\\:\\:getAdministratorPermissions\\(\\) has no return type specified\\.$#',
    ......@@ -31414,24 +31336,12 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/menu_ui/tests/src/Functional/MenuUiContentModerationTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\menu_ui\\\\Functional\\\\MenuUiContentTranslationTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/menu_ui/tests/src/Functional/MenuUiContentTranslationTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\menu_ui\\\\Functional\\\\MenuUiLanguageTest\\:\\:assertMenuLink\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/menu_ui/tests/src/Functional/MenuUiLanguageTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\menu_ui\\\\Functional\\\\MenuUiNodeTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/menu_ui/tests/src/Functional/MenuUiNodeTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\menu_ui\\\\Functional\\\\MenuUiTest\\:\\:assertMenuLink\\(\\) has no return type specified\\.$#',
    ......@@ -35070,12 +34980,6 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/node/tests/src/Functional/NodeTranslationUITest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\node\\\\Functional\\\\NodeTranslationUITest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/node/tests/src/Functional/NodeTranslationUITest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\node\\\\Functional\\\\NodeTranslationUITest\\:\\:getNewEntityValues\\(\\) has no return type specified\\.$#',
    ......@@ -36456,18 +36360,6 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/path/tests/src/Functional/PathContentModerationTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\path\\\\Functional\\\\PathContentModerationTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/path/tests/src/Functional/PathContentModerationTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\path\\\\Functional\\\\PathLanguageTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/path/tests/src/Functional/PathLanguageTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\path\\\\Functional\\\\PathTestBase\\:\\:assertPathAliasExists\\(\\) has no return type specified\\.$#',
    ......@@ -36486,12 +36378,6 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/path/tests/src/Functional/PathWithNodeAccessGrantsTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\path\\\\Functional\\\\PathWithNodeAccessGrantsTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/path/tests/src/Functional/PathWithNodeAccessGrantsTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\path\\\\Kernel\\\\Migrate\\\\d6\\\\MigrateUrlAliasTest\\:\\:assertPathAliasExists\\(\\) has no return type specified\\.$#',
    ......@@ -58815,12 +58701,6 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/views/tests/src/Functional/Plugin/DisplayFeedTranslationTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\views\\\\Functional\\\\Plugin\\\\DisplayFeedTranslationTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/views/tests/src/Functional/Plugin/DisplayFeedTranslationTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\views\\\\Functional\\\\Plugin\\\\DisplayFeedTranslationTest\\:\\:setWaitForTerminate\\(\\) has no return type specified\\.$#',
    ......@@ -59055,12 +58935,6 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/views/tests/src/Functional/SearchMultilingualTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\views\\\\Functional\\\\SearchMultilingualTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/views/tests/src/Functional/SearchMultilingualTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: variable.undefined
    'message' => '#^Variable \\$link might not be defined\\.$#',
    ......@@ -62127,12 +62001,6 @@
    'count' => 1,
    'path' => __DIR__ . '/modules/workspaces/tests/modules/workspaces_test/workspaces_test.module',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\workspaces\\\\Functional\\\\PathWorkspacesTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/modules/workspaces/tests/src/Functional/PathWorkspacesTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\Tests\\\\workspaces\\\\Functional\\\\PathWorkspacesTest\\:\\:isLabelInContentOverview\\(\\) has no return type specified\\.$#',
    ......@@ -64773,12 +64641,6 @@
    'count' => 1,
    'path' => __DIR__ . '/tests/Drupal/FunctionalTests/Routing/PathEncodedTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\FunctionalTests\\\\Routing\\\\RouteCachingLanguageTest\\:\\:disableBundleTranslation\\(\\) has no return type specified\\.$#',
    'count' => 1,
    'path' => __DIR__ . '/tests/Drupal/FunctionalTests/Routing/RouteCachingLanguageTest.php',
    ];
    $ignoreErrors[] = [
    // identifier: missingType.return
    'message' => '#^Method Drupal\\\\FunctionalTests\\\\Routing\\\\RouteCachingLanguageTest\\:\\:providerLanguage\\(\\) has no return type specified\\.$#',
    core/modules/language/tests/src/Traits/LanguageTestTrait.php
    + 1
    − 1
    View file @ 07eea76d
    ......@@ -62,7 +62,7 @@ public static function enableBundleTranslation(string $entity_type_id, string $b
    * @param string $bundle
    * The bundle name.
    */
    public static function disableBundleTranslation(string $entity_type_id, string $bundle) {
    public static function disableBundleTranslation(string $entity_type_id, string $bundle): void {
    // @todo Move to API call when it exists, to be added at
    // https://www.drupal.org/project/drupal/issues/3408046
    $content_language_settings = ContentLanguageSettings::loadByEntityTypeBundle($entity_type_id, $bundle);
    ......
    0% or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Finish editing this message first!
    Please register or to comment