Unverified Commit 0635e0df authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3251754 by spokje, quietone, longwave, smustgrave, mallezie, mstrelan,... 

Issue #3251754 by spokje, quietone, longwave, smustgrave, mallezie, mstrelan, alexpott, daffie, tstoeckler, mondrake, samaraof@ciandt.com: Use DrupalPractice.CodeAnalysis.VariableAnalysis for Kernel and Unit tests
parent c39eaf1a

core/modules/ckeditor5/tests/src/Kernel/ValidatorsTest.php

+0 −1
Original line number Diff line number Diff line
@@ -97,7 +97,6 @@ public function test(array $ckeditor5_settings, array $expected_violations): voi 
    );

    $violations = $typed_config->validate();



    $actual_violations = self::violationsToArray($violations);

    $this->assertSame($expected_violations, self::violationsToArray($violations));



    if (empty($expected_violations)) {

core/modules/field/tests/src/Unit/Plugin/migrate/process/d6/FieldInstanceSettingsTest.php

+0 −2
Original line number Diff line number Diff line
@@ -5,7 +5,6 @@ 
namespace Drupal\Tests\field\Unit\Plugin\migrate\process\d6;



use Drupal\field\Plugin\migrate\process\d6\FieldInstanceSettings;

use Drupal\migrate\Plugin\MigrationInterface;

use Drupal\migrate\MigrateExecutableInterface;

use Drupal\migrate\Row;

use Drupal\Tests\UnitTestCase;
@@ -25,7 +24,6 @@ class FieldInstanceSettingsTest extends UnitTestCase { 
   */

  public function testGetSettings($field_type, $instance_settings, $expected): void {

    $instance_settings = unserialize($instance_settings);

    $migration = $this->createMock(MigrationInterface::class);

    $plugin = new FieldInstanceSettings([], 'd6_field_field_settings', []);



    $executable = $this->createMock(MigrateExecutableInterface::class);

core/modules/field/tests/src/Unit/Plugin/migrate/process/d6/FieldSettingsTest.php

+0 −2
Original line number Diff line number Diff line
@@ -5,7 +5,6 @@ 
namespace Drupal\Tests\field\Unit\Plugin\migrate\process\d6;



use Drupal\field\Plugin\migrate\process\d6\FieldSettings;

use Drupal\migrate\Plugin\MigrationInterface;

use Drupal\migrate\MigrateExecutableInterface;

use Drupal\migrate\Row;

use Drupal\Tests\UnitTestCase;
@@ -22,7 +21,6 @@ class FieldSettingsTest extends UnitTestCase { 
   * @dataProvider getSettingsProvider

   */

  public function testGetSettings($field_type, $field_settings, $allowed_values): void {

    $migration = $this->createMock(MigrationInterface::class);

    $plugin = new FieldSettings([], 'd6_field_settings', []);



    $executable = $this->createMock(MigrateExecutableInterface::class);

core/modules/field/tests/src/Unit/Plugin/migrate/process/d7/FieldInstanceSettingsTest.php

+0 −2
Original line number Diff line number Diff line
@@ -5,7 +5,6 @@ 
namespace Drupal\Tests\field\Unit\Plugin\migrate\process\d7;



use Drupal\field\Plugin\migrate\process\d7\FieldInstanceSettings;

use Drupal\migrate\Plugin\MigrationInterface;

use Drupal\migrate\MigrateExecutableInterface;

use Drupal\migrate\Row;

use Drupal\Tests\migrate\Unit\MigrateTestCase;
@@ -22,7 +21,6 @@ class FieldInstanceSettingsTest extends MigrateTestCase { 
   * @covers ::transform

   */

  public function testTransformImageSettings(): void {

    $migration = $this->createMock(MigrationInterface::class);

    $plugin = new FieldInstanceSettings([], 'd7_field_instance_settings', []);



    $executable = $this->createMock(MigrateExecutableInterface::class);

core/modules/field/tests/src/Unit/Plugin/migrate/process/d7/FieldSettingsTest.php

+0 −2
Original line number Diff line number Diff line
@@ -5,7 +5,6 @@ 
namespace Drupal\Tests\field\Unit\Plugin\migrate\process\d7;



use Drupal\field\Plugin\migrate\process\d7\FieldSettings;

use Drupal\migrate\Plugin\MigrationInterface;

use Drupal\migrate\MigrateExecutableInterface;

use Drupal\migrate\Row;

use Drupal\Tests\migrate\Unit\MigrateTestCase;
@@ -22,7 +21,6 @@ class FieldSettingsTest extends MigrateTestCase { 
   * @covers ::transform

   */

  public function testTransformImageSettings(): void {

    $migration = $this->createMock(MigrationInterface::class);

    $plugin = new FieldSettings([], 'd7_field_settings', []);



    $executable = $this->createMock(MigrateExecutableInterface::class);