Skip to content
Snippets Groups Projects
Verified Commit 05e4d1a8 authored by Dave Long's avatar Dave Long
Browse files

Issue #3441844 by catch: Set budgets rather than exact numbers of asset size assertions

parent 8cd02c7f
Branches
Tags
27 merge requests!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8540Issue #3457061: Bootstrap Modal dialog Not closing after 10.3.0 Update,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8373Issue #3427374 by danflanagan8, Vighneshh: taxonomy_tid ViewsArgumentDefault...,!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2794Issue #3100732: Allow specifying `meta` data on JSON:API objects,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #150363 canceled
......@@ -25,9 +25,9 @@ class AssetAggregationAcrossPagesTest extends PerformanceTestBase {
public function testFrontAndRecipesPages() {
$performance_data = $this->doRequests();
$this->assertSame(4, $performance_data->getStylesheetCount());
$this->assertSame(82347, $performance_data->getStylesheetBytes());
$this->assertLessThan(82500, $performance_data->getStylesheetBytes());
$this->assertSame(2, $performance_data->getScriptCount());
$this->assertSame(14134, $performance_data->getScriptBytes());
$this->assertLessThan(14500, $performance_data->getScriptBytes());
}
/**
......@@ -39,9 +39,9 @@ public function testFrontAndRecipesPagesAuthenticated() {
$this->rebuildAll();
$performance_data = $this->doRequests();
$this->assertSame(4, $performance_data->getStylesheetCount());
$this->assertSame(89167, $performance_data->getStylesheetBytes());
$this->assertLessThan(89500, $performance_data->getStylesheetBytes());
$this->assertSame(2, $performance_data->getScriptCount());
$this->assertSame(264134, $performance_data->getScriptBytes());
$this->assertLessThan(264500, $performance_data->getScriptBytes());
}
/**
......
......@@ -37,9 +37,9 @@ public function testFrontPageAuthenticatedWarmCache(): void {
$this->drupalGet('<front>');
}, 'authenticatedFrontPage');
$this->assertSame(2, $performance_data->getStylesheetCount());
$this->assertSame(44958, $performance_data->getStylesheetBytes());
$this->assertLessThan(45500, $performance_data->getStylesheetBytes());
$this->assertSame(1, $performance_data->getScriptCount());
$this->assertSame(132067, $performance_data->getScriptBytes());
$this->assertLessThan(132500, $performance_data->getScriptBytes());
$expected_queries = [
'SELECT "session" FROM "sessions" WHERE "sid" = "SESSION_ID" LIMIT 0, 1',
......
......@@ -65,9 +65,9 @@ public function testFrontPageHotCache() {
$this->assertSame(1, $performance_data->getCacheTagIsValidCount());
$this->assertSame(0, $performance_data->getCacheTagInvalidationCount());
$this->assertSame(1, $performance_data->getScriptCount());
$this->assertSame(7067, $performance_data->getScriptBytes());
$this->assertLessThan(7500, $performance_data->getScriptBytes());
$this->assertSame(2, $performance_data->getStylesheetCount());
$this->assertSame(41548, $performance_data->getStylesheetBytes());
$this->assertLessThan(42000, $performance_data->getStylesheetBytes());
}
/**
......
......@@ -69,7 +69,7 @@ public function testAnonymous() {
}, 'standardFrontPage');
$this->assertNoJavaScript($performance_data);
$this->assertSame(1, $performance_data->getStylesheetCount());
$this->assertSame(3491, $performance_data->getStylesheetBytes());
$this->assertLessThan(3500, $performance_data->getStylesheetBytes());
$expected_queries = [
'SELECT "base_table"."id" AS "id", "base_table"."path" AS "path", "base_table"."alias" AS "alias", "base_table"."langcode" AS "langcode" FROM "path_alias" "base_table" WHERE ("base_table"."status" = 1) AND ("base_table"."alias" LIKE "/node" ESCAPE ' . "'\\\\'" . ') AND ("base_table"."langcode" IN ("en", "und")) ORDER BY "base_table"."langcode" ASC, "base_table"."id" DESC',
......@@ -123,7 +123,7 @@ public function testAnonymous() {
}, 'standardNodePage');
$this->assertNoJavaScript($performance_data);
$this->assertSame(1, $performance_data->getStylesheetCount());
$this->assertSame(3216, $performance_data->getStylesheetBytes());
$this->assertLessThan(3500, $performance_data->getStylesheetBytes());
$expected_queries = [
'SELECT "base_table"."id" AS "id", "base_table"."path" AS "path", "base_table"."alias" AS "alias", "base_table"."langcode" AS "langcode" FROM "path_alias" "base_table" WHERE ("base_table"."status" = 1) AND ("base_table"."alias" LIKE "/node/1" ESCAPE ' . "'\\\\'" . ') AND ("base_table"."langcode" IN ("en", "und")) ORDER BY "base_table"."langcode" ASC, "base_table"."id" DESC',
......@@ -152,7 +152,7 @@ public function testAnonymous() {
}, 'standardUserPage');
$this->assertNoJavaScript($performance_data);
$this->assertSame(1, $performance_data->getStylesheetCount());
$this->assertSame(3216, $performance_data->getStylesheetBytes());
$this->assertLessThan(3500, $performance_data->getStylesheetBytes());
$expected_queries = [
'SELECT "base_table"."id" AS "id", "base_table"."path" AS "path", "base_table"."alias" AS "alias", "base_table"."langcode" AS "langcode" FROM "path_alias" "base_table" WHERE ("base_table"."status" = 1) AND ("base_table"."alias" LIKE "/user/2" ESCAPE ' . "'\\\\'" . ') AND ("base_table"."langcode" IN ("en", "und")) ORDER BY "base_table"."langcode" ASC, "base_table"."id" DESC',
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment