Verified Commit 05e4d1a8 authored by Dave Long's avatar Dave Long
Browse files

Issue #3441844 by catch: Set budgets rather than exact numbers of asset size assertions

parent 8cd02c7f

core/profiles/demo_umami/tests/src/FunctionalJavascript/AssetAggregationAcrossPagesTest.php

+4 −4
Original line number Diff line number Diff line
@@ -25,9 +25,9 @@ class AssetAggregationAcrossPagesTest extends PerformanceTestBase { 
  public function testFrontAndRecipesPages() {

    $performance_data = $this->doRequests();

    $this->assertSame(4, $performance_data->getStylesheetCount());

    $this->assertSame(82347, $performance_data->getStylesheetBytes());

    $this->assertLessThan(82500, $performance_data->getStylesheetBytes());

    $this->assertSame(2, $performance_data->getScriptCount());

    $this->assertSame(14134, $performance_data->getScriptBytes());

    $this->assertLessThan(14500, $performance_data->getScriptBytes());

  }



  /**
@@ -39,9 +39,9 @@ public function testFrontAndRecipesPagesAuthenticated() { 
    $this->rebuildAll();

    $performance_data = $this->doRequests();

    $this->assertSame(4, $performance_data->getStylesheetCount());

    $this->assertSame(89167, $performance_data->getStylesheetBytes());

    $this->assertLessThan(89500, $performance_data->getStylesheetBytes());

    $this->assertSame(2, $performance_data->getScriptCount());

    $this->assertSame(264134, $performance_data->getScriptBytes());

    $this->assertLessThan(264500, $performance_data->getScriptBytes());

  }



  /**

core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryAuthenticatedPerformanceTest.php

+2 −2
Original line number Diff line number Diff line
@@ -37,9 +37,9 @@ public function testFrontPageAuthenticatedWarmCache(): void { 
      $this->drupalGet('<front>');

    }, 'authenticatedFrontPage');

    $this->assertSame(2, $performance_data->getStylesheetCount());

    $this->assertSame(44958, $performance_data->getStylesheetBytes());

    $this->assertLessThan(45500, $performance_data->getStylesheetBytes());

    $this->assertSame(1, $performance_data->getScriptCount());

    $this->assertSame(132067, $performance_data->getScriptBytes());

    $this->assertLessThan(132500, $performance_data->getScriptBytes());



    $expected_queries = [

      'SELECT "session" FROM "sessions" WHERE "sid" = "SESSION_ID" LIMIT 0, 1',

core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryFrontPagePerformanceTest.php

+2 −2
Original line number Diff line number Diff line
@@ -65,9 +65,9 @@ public function testFrontPageHotCache() { 
    $this->assertSame(1, $performance_data->getCacheTagIsValidCount());

    $this->assertSame(0, $performance_data->getCacheTagInvalidationCount());

    $this->assertSame(1, $performance_data->getScriptCount());

    $this->assertSame(7067, $performance_data->getScriptBytes());

    $this->assertLessThan(7500, $performance_data->getScriptBytes());

    $this->assertSame(2, $performance_data->getStylesheetCount());

    $this->assertSame(41548, $performance_data->getStylesheetBytes());

    $this->assertLessThan(42000, $performance_data->getStylesheetBytes());

  }



  /**

core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php

+3 −3
Original line number Diff line number Diff line
@@ -69,7 +69,7 @@ public function testAnonymous() { 
    }, 'standardFrontPage');

    $this->assertNoJavaScript($performance_data);

    $this->assertSame(1, $performance_data->getStylesheetCount());

    $this->assertSame(3491, $performance_data->getStylesheetBytes());

    $this->assertLessThan(3500, $performance_data->getStylesheetBytes());



    $expected_queries = [

      'SELECT "base_table"."id" AS "id", "base_table"."path" AS "path", "base_table"."alias" AS "alias", "base_table"."langcode" AS "langcode" FROM "path_alias" "base_table" WHERE ("base_table"."status" = 1) AND ("base_table"."alias" LIKE "/node" ESCAPE ' . "'\\\\'" . ') AND ("base_table"."langcode" IN ("en", "und")) ORDER BY "base_table"."langcode" ASC, "base_table"."id" DESC',
@@ -123,7 +123,7 @@ public function testAnonymous() { 
    }, 'standardNodePage');

    $this->assertNoJavaScript($performance_data);

    $this->assertSame(1, $performance_data->getStylesheetCount());

    $this->assertSame(3216, $performance_data->getStylesheetBytes());

    $this->assertLessThan(3500, $performance_data->getStylesheetBytes());



    $expected_queries = [

      'SELECT "base_table"."id" AS "id", "base_table"."path" AS "path", "base_table"."alias" AS "alias", "base_table"."langcode" AS "langcode" FROM "path_alias" "base_table" WHERE ("base_table"."status" = 1) AND ("base_table"."alias" LIKE "/node/1" ESCAPE ' . "'\\\\'" . ') AND ("base_table"."langcode" IN ("en", "und")) ORDER BY "base_table"."langcode" ASC, "base_table"."id" DESC',
@@ -152,7 +152,7 @@ public function testAnonymous() { 
    }, 'standardUserPage');

    $this->assertNoJavaScript($performance_data);

    $this->assertSame(1, $performance_data->getStylesheetCount());

    $this->assertSame(3216, $performance_data->getStylesheetBytes());

    $this->assertLessThan(3500, $performance_data->getStylesheetBytes());



    $expected_queries = [

      'SELECT "base_table"."id" AS "id", "base_table"."path" AS "path", "base_table"."alias" AS "alias", "base_table"."langcode" AS "langcode" FROM "path_alias" "base_table" WHERE ("base_table"."status" = 1) AND ("base_table"."alias" LIKE "/user/2" ESCAPE ' . "'\\\\'" . ') AND ("base_table"."langcode" IN ("en", "und")) ORDER BY "base_table"."langcode" ASC, "base_table"."id" DESC',