Verified Commit 05d87619 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3258931 by nod_, hooroomoo, xjm, catch, effulgentsia, Wim Leers:... 

Issue #3258931 by nod_, hooroomoo, xjm, catch, effulgentsia, Wim Leers: Deprecate backbone and tag it internal
parent 59901155

core/core.libraries.yml

+19 −1
Original line number Diff line number Diff line 
# All libraries are defined in alphabetical order.



backbone:

  remote: https://github.com/jashkenas/backbone

  version: "1.4.0"

  license:

    name: MIT

    url: https://raw.githubusercontent.com/jashkenas/backbone/1.4.0/LICENSE

    gpl-compatible: true

  js:

    assets/vendor/backbone/backbone-min.js: { weight: -19, minified: true }

  dependencies:

    - core/underscore

  deprecated: The %library_id% asset library is deprecated in Drupal 9.4.0 and will be removed in Drupal 10.0.0.



internal.backbone:

  # Internal library. Do not depend on it outside core nor add new core usage.

  # The library will be removed as soon as the following issues are fixed:

  #  - https://www.drupal.org/project/drupal/issues/3203920

  #  - https://www.drupal.org/project/drupal/issues/3204011

  #  - https://www.drupal.org/project/drupal/issues/3204015

  remote: https://github.com/jashkenas/backbone

  version: "1.4.0"

  license:
@@ -1085,7 +1103,7 @@ underscore: 
  deprecated: The %library_id% asset library is deprecated in Drupal 9.4.0 and will be removed in Drupal 10.0.0.



internal.underscore:

  # Internal library, do not depend on it.

  # Internal library. Do not depend on it outside core nor add new core usage.

  # The library will be removed as soon as the following issues are fixed:

  #  - https://www.drupal.org/project/drupal/issues/3270395

  #  - https://www.drupal.org/project/drupal/issues/3203920

core/lib/Drupal/Core/Render/theme.api.php

+1 −1
Original line number Diff line number Diff line
@@ -844,7 +844,7 @@ function hook_library_info_build() { 
  // Add a library whose information changes depending on certain conditions.

  $libraries['mymodule.zombie'] = [

    'dependencies' => [

      'core/backbone',

      'core/once',

    ],

  ];

  if (Drupal::moduleHandler()->moduleExists('minifyzombies')) {

core/modules/ckeditor/ckeditor.libraries.yml

+1 −1
Original line number Diff line number Diff line
@@ -50,7 +50,7 @@ drupal.ckeditor.admin: 
    - core/drupal

    - core/drupalSettings

    - core/once

    - core/backbone

    - core/internal.backbone

    - core/drupal.dialog

    - core/drupal.announce

    - core/ckeditor

core/modules/contextual/contextual.libraries.yml

+4 −2
Original line number Diff line number Diff line
@@ -22,7 +22,8 @@ drupal.contextual-links: 
    - core/drupal

    - core/drupal.ajax

    - core/drupalSettings

    - core/backbone

    # @todo Remove this in https://www.drupal.org/project/drupal/issues/3203920

    - core/internal.backbone

    - core/modernizr

    - core/once
@@ -41,7 +42,8 @@ drupal.contextual-toolbar: 
  dependencies:

    - core/jquery

    - core/drupal

    - core/backbone

    # @todo Remove this in https://www.drupal.org/project/drupal/issues/3203920

    - core/internal.backbone

    - core/once

    - core/drupal.tabbingmanager

    - core/drupal.announce

core/modules/quickedit/quickedit.libraries.yml

+1 −1
Original line number Diff line number Diff line
@@ -30,7 +30,7 @@ quickedit: 
    - core/jquery

    - core/once

    - core/internal.underscore

    - core/backbone

    - core/internal.backbone

    - core/jquery.form

    - core/drupal

    - core/drupal.displace