ImageStylesPathAndUrlTest.php 13.6 KB
Newer Older
1 2 3 4
<?php

namespace Drupal\image\Tests;

5
use Drupal\image\Entity\ImageStyle;
6 7 8 9
use Drupal\simpletest\WebTestBase;

/**
 * Tests the functions for generating paths and URLs for image styles.
10 11
 *
 * @group image
12 13
 */
class ImageStylesPathAndUrlTest extends WebTestBase {
14 15 16 17 18 19

  /**
   * Modules to enable.
   *
   * @var array
   */
20
  public static $modules = ['image', 'image_module_test'];
21

22 23 24 25
  /**
   * @var \Drupal\image\ImageStyleInterface
   */
  protected $style;
26

27
  protected function setUp() {
28
    parent::setUp();
29

30
    $this->style = ImageStyle::create(['name' => 'style_foo', 'label' => $this->randomString()]);
31
    $this->style->save();
32 33 34
  }

  /**
35
   * Tests \Drupal\image\ImageStyleInterface::buildUri().
36
   */
37
  public function testImageStylePath() {
38
    $scheme = 'public';
39 40
    $actual = $this->style->buildUri("$scheme://foo/bar.gif");
    $expected = "$scheme://styles/" . $this->style->id() . "/$scheme/foo/bar.gif";
41
    $this->assertEqual($actual, $expected, 'Got the path for a file URI.');
42

43 44
    $actual = $this->style->buildUri('foo/bar.gif');
    $expected = "$scheme://styles/" . $this->style->id() . "/$scheme/foo/bar.gif";
45
    $this->assertEqual($actual, $expected, 'Got the path for a relative file path.');
46 47 48
  }

  /**
49
   * Tests an image style URL using the "public://" scheme.
50
   */
51
  public function testImageStyleUrlAndPathPublic() {
52
    $this->doImageStyleUrlAndPathTests('public');
53 54 55
  }

  /**
56
   * Tests an image style URL using the "private://" scheme.
57
   */
58
  public function testImageStyleUrlAndPathPrivate() {
59
    $this->doImageStyleUrlAndPathTests('private');
60 61 62
  }

  /**
63
   * Tests an image style URL with the "public://" scheme and unclean URLs.
64
   */
65
  public function testImageStyleUrlAndPathPublicUnclean() {
66 67
    $this->doImageStyleUrlAndPathTests('public', FALSE);
  }
68 69

  /**
70
   * Tests an image style URL with the "private://" schema and unclean URLs.
71
   */
72
  public function testImageStyleUrlAndPathPrivateUnclean() {
73
    $this->doImageStyleUrlAndPathTests('private', FALSE);
74 75 76
  }

  /**
77
   * Tests an image style URL with a file URL that has an extra slash in it.
78
   */
79
  public function testImageStyleUrlExtraSlash() {
80
    $this->doImageStyleUrlAndPathTests('public', TRUE, TRUE);
81 82
  }

83 84 85
  /**
   * Tests that an invalid source image returns a 404.
   */
86
  public function testImageStyleUrlForMissingSourceImage() {
87
    $non_existent_uri = 'public://foo.png';
88
    $generated_url = $this->style->buildUrl($non_existent_uri);
89 90 91 92
    $this->drupalGet($generated_url);
    $this->assertResponse(404, 'Accessing an image style URL with a source image that does not exist provides a 404 error response.');
  }

93
  /**
94
   * Tests building an image style URL.
95
   */
96
  public function doImageStyleUrlAndPathTests($scheme, $clean_url = TRUE, $extra_slash = FALSE) {
97
    $this->prepareRequestForGenerator($clean_url);
98 99 100

    // Make the default scheme neither "public" nor "private" to verify the
    // functions work for other than the default scheme.
101
    $this->config('system.file')->set('default_scheme', 'temporary')->save();
102 103

    // Create the directories for the styles.
104
    $directory = $scheme . '://styles/' . $this->style->id();
105
    $status = file_prepare_directory($directory, FILE_CREATE_DIRECTORY);
106
    $this->assertNotIdentical(FALSE, $status, 'Created the directory for the generated images for the test style.');
107 108 109

    // Create a working copy of the file.
    $files = $this->drupalGetTestFiles('image');
110
    $file = array_shift($files);
111 112 113
    $original_uri = file_unmanaged_copy($file->uri, $scheme . '://', FILE_EXISTS_RENAME);
    // Let the image_module_test module know about this file, so it can claim
    // ownership in hook_file_download().
114
    \Drupal::state()->set('image.test_file_download', $original_uri);
115
    $this->assertNotIdentical(FALSE, $original_uri, 'Created the generated image file.');
116 117

    // Get the URL of a file that has not been generated and try to create it.
118
    $generated_uri = $this->style->buildUri($original_uri);
119
    $this->assertFalse(file_exists($generated_uri), 'Generated file does not exist.');
120
    $generate_url = $this->style->buildUrl($original_uri, $clean_url);
121

122 123 124 125 126 127
    // Ensure that the tests still pass when the file is generated by accessing
    // a poorly constructed (but still valid) file URL that has an extra slash
    // in it.
    if ($extra_slash) {
      $modified_uri = str_replace('://', ':///', $original_uri);
      $this->assertNotEqual($original_uri, $modified_uri, 'An extra slash was added to the generated file URI.');
128
      $generate_url = $this->style->buildUrl($modified_uri, $clean_url);
129
    }
130 131
    if (!$clean_url) {
      $this->assertTrue(strpos($generate_url, 'index.php/') !== FALSE, 'When using non-clean URLS, the system path contains the script name.');
132
    }
133 134
    // Add some extra chars to the token.
    $this->drupalGet(str_replace(IMAGE_DERIVATIVE_TOKEN . '=', IMAGE_DERIVATIVE_TOKEN . '=Zo', $generate_url));
135
    $this->assertResponse(403, 'Image was inaccessible at the URL with an invalid token.');
136 137
    // Change the parameter name so the token is missing.
    $this->drupalGet(str_replace(IMAGE_DERIVATIVE_TOKEN . '=', 'wrongparam=', $generate_url));
138
    $this->assertResponse(403, 'Image was inaccessible at the URL with a missing token.');
139

140 141 142 143
    // Check that the generated URL is the same when we pass in a relative path
    // rather than a URI. We need to temporarily switch the default scheme to
    // match the desired scheme before testing this, then switch it back to the
    // "temporary" scheme used throughout this test afterwards.
144
    $this->config('system.file')->set('default_scheme', $scheme)->save();
145 146 147
    $relative_path = file_uri_target($original_uri);
    $generate_url_from_relative_path = $this->style->buildUrl($relative_path, $clean_url);
    $this->assertEqual($generate_url, $generate_url_from_relative_path);
148
    $this->config('system.file')->set('default_scheme', 'temporary')->save();
149

150 151
    // Fetch the URL that generates the file.
    $this->drupalGet($generate_url);
152 153 154
    $this->assertResponse(200, 'Image was generated at the URL.');
    $this->assertTrue(file_exists($generated_uri), 'Generated file does exist after we accessed it.');
    $this->assertRaw(file_get_contents($generated_uri), 'URL returns expected file.');
155 156 157
    $image = $this->container->get('image.factory')->get($generated_uri);
    $this->assertEqual($this->drupalGetHeader('Content-Type'), $image->getMimeType(), 'Expected Content-Type was reported.');
    $this->assertEqual($this->drupalGetHeader('Content-Length'), $image->getFileSize(), 'Expected Content-Length was reported.');
158 159 160 161 162

    // Check that we did not download the original file.
    $original_image = $this->container->get('image.factory')->get($original_uri);
    $this->assertNotEqual($this->drupalGetHeader('Content-Length'), $original_image->getFileSize());

163
    if ($scheme == 'private') {
164
      $this->assertEqual($this->drupalGetHeader('Expires'), 'Sun, 19 Nov 1978 05:00:00 GMT', 'Expires header was sent.');
165
      $this->assertNotEqual(strpos($this->drupalGetHeader('Cache-Control'), 'no-cache'), FALSE, 'Cache-Control header contains \'no-cache\' to prevent caching.');
166
      $this->assertEqual($this->drupalGetHeader('X-Image-Owned-By'), 'image_module_test', 'Expected custom header has been added.');
167

168 169
      // Make sure that a second request to the already existing derivative
      // works too.
170
      $this->drupalGet($generate_url);
171
      $this->assertResponse(200, 'Image was generated at the URL.');
172

173 174 175 176 177 178
      // Check that the second request also returned the generated image.
      $this->assertEqual($this->drupalGetHeader('Content-Length'), $image->getFileSize());

      // Check that we did not download the original file.
      $this->assertNotEqual($this->drupalGetHeader('Content-Length'), $original_image->getFileSize());

179 180
      // Make sure that access is denied for existing style files if we do not
      // have access.
181
      \Drupal::state()->delete('image.test_file_download');
182 183 184
      $this->drupalGet($generate_url);
      $this->assertResponse(403, 'Confirmed that access is denied for the private image style.');

185 186 187 188
      // Repeat this with a different file that we do not have access to and
      // make sure that access is denied.
      $file_noaccess = array_shift($files);
      $original_uri_noaccess = file_unmanaged_copy($file_noaccess->uri, $scheme . '://', FILE_EXISTS_RENAME);
189
      $generated_uri_noaccess = $scheme . '://styles/' . $this->style->id() . '/' . $scheme . '/' . drupal_basename($original_uri_noaccess);
190
      $this->assertFalse(file_exists($generated_uri_noaccess), 'Generated file does not exist.');
191
      $generate_url_noaccess = $this->style->buildUrl($original_uri_noaccess);
192 193

      $this->drupalGet($generate_url_noaccess);
194
      $this->assertResponse(403, 'Confirmed that access is denied for the private image style.');
195
      // Verify that images are not appended to the response. Currently this test only uses PNG images.
196
      if (strpos($generate_url, '.png') === FALSE) {
197 198 199 200 201
        $this->fail('Confirming that private image styles are not appended require PNG file.');
      }
      else {
        // Check for PNG-Signature (cf. http://www.libpng.org/pub/png/book/chapter08.html#png.ch08.div.2) in the
        // response body.
202
        $this->assertNoRaw(chr(137) . chr(80) . chr(78) . chr(71) . chr(13) . chr(10) . chr(26) . chr(10), 'No PNG signature found in the response body.');
203
      }
204
    }
205 206 207 208 209 210 211 212 213
    else {
      $this->assertEqual($this->drupalGetHeader('Expires'), 'Sun, 19 Nov 1978 05:00:00 GMT', 'Expires header was sent.');
      $this->assertEqual(strpos($this->drupalGetHeader('Cache-Control'), 'no-cache'), FALSE, 'Cache-Control header contains \'no-cache\' to prevent caching.');

      if ($clean_url) {
        // Add some extra chars to the token.
        $this->drupalGet(str_replace(IMAGE_DERIVATIVE_TOKEN . '=', IMAGE_DERIVATIVE_TOKEN . '=Zo', $generate_url));
        $this->assertResponse(200, 'Existing image was accessible at the URL with an invalid token.');
      }
214
    }
215

216 217
    // Allow insecure image derivatives to be created for the remainder of this
    // test.
218
    $this->config('image.settings')->set('allow_insecure_derivatives', TRUE)->save();
219 220 221 222 223 224 225

    // Create another working copy of the file.
    $files = $this->drupalGetTestFiles('image');
    $file = array_shift($files);
    $original_uri = file_unmanaged_copy($file->uri, $scheme . '://', FILE_EXISTS_RENAME);
    // Let the image_module_test module know about this file, so it can claim
    // ownership in hook_file_download().
226
    \Drupal::state()->set('image.test_file_download', $original_uri);
227 228 229 230

    // Suppress the security token in the URL, then get the URL of a file that
    // has not been created and try to create it. Check that the security token
    // is not present in the URL but that the image is still accessible.
231
    $this->config('image.settings')->set('suppress_itok_output', TRUE)->save();
232
    $generated_uri = $this->style->buildUri($original_uri);
233
    $this->assertFalse(file_exists($generated_uri), 'Generated file does not exist.');
234
    $generate_url = $this->style->buildUrl($original_uri, $clean_url);
235 236 237
    $this->assertIdentical(strpos($generate_url, IMAGE_DERIVATIVE_TOKEN . '='), FALSE, 'The security token does not appear in the image style URL.');
    $this->drupalGet($generate_url);
    $this->assertResponse(200, 'Image was accessible at the URL with a missing token.');
238 239 240 241 242 243 244 245 246

    // Stop supressing the security token in the URL.
    $this->config('image.settings')->set('suppress_itok_output', FALSE)->save();
    // Ensure allow_insecure_derivatives is enabled.
    $this->assertEqual($this->config('image.settings')->get('allow_insecure_derivatives'), TRUE);
    // Check that a security token is still required when generating a second
    // image derivative using the first one as a source.
    $nested_url = $this->style->buildUrl($generated_uri, $clean_url);
    $matches_expected_url_format = (boolean) preg_match('/styles\/' . $this->style->id() . '\/' . $scheme . '\/styles\/' . $this->style->id() . '\/' . $scheme . '/', $nested_url);
247
    $this->assertTrue($matches_expected_url_format, "URL for a derivative of an image style matches expected format.");
248 249 250 251 252 253 254 255 256 257 258 259 260 261 262
    $nested_url_with_wrong_token = str_replace(IMAGE_DERIVATIVE_TOKEN . '=', 'wrongparam=', $nested_url);
    $this->drupalGet($nested_url_with_wrong_token);
    $this->assertResponse(403, 'Image generated from an earlier derivative was inaccessible at the URL with a missing token.');
    // Check that this restriction cannot be bypassed by adding extra slashes
    // to the URL.
    $this->drupalGet(substr_replace($nested_url_with_wrong_token, '//styles/', strrpos($nested_url_with_wrong_token, '/styles/'), strlen('/styles/')));
    $this->assertResponse(403, 'Image generated from an earlier derivative was inaccessible at the URL with a missing token, even with an extra forward slash in the URL.');
    $this->drupalGet(substr_replace($nested_url_with_wrong_token, '////styles/', strrpos($nested_url_with_wrong_token, '/styles/'), strlen('/styles/')));
    $this->assertResponse(403, 'Image generated from an earlier derivative was inaccessible at the URL with a missing token, even with multiple forward slashes in the URL.');
    // Make sure the image can still be generated if a correct token is used.
    $this->drupalGet($nested_url);
    $this->assertResponse(200, 'Image was accessible when a correct token was provided in the URL.');

    // Check that requesting a nonexistent image does not create any new
    // directories in the file system.
263
    $directory = $scheme . '://styles/' . $this->style->id() . '/' . $scheme . '/' . $this->randomMachineName();
264 265
    $this->drupalGet(file_create_url($directory . '/' . $this->randomString()));
    $this->assertFalse(file_exists($directory), 'New directory was not created in the filesystem when requesting an unauthorized image.');
266
  }
267

268
}