From 76cf7243f78ba9b80392a446d5758fdc7d9243ff Mon Sep 17 00:00:00 2001 From: bjorn <bjorn@swis.nl> Date: Fri, 18 Apr 2025 11:27:49 +0200 Subject: [PATCH 1/2] feat: remove allowFallback, let's see what breaks --- core/config/schema/core.data_types.schema.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/core/config/schema/core.data_types.schema.yml b/core/config/schema/core.data_types.schema.yml index 3e88997a1cf5..cb7148f4c544 100644 --- a/core/config/schema/core.data_types.schema.yml +++ b/core/config/schema/core.data_types.schema.yml @@ -768,9 +768,6 @@ field.field_settings.entity_reference: PluginExists: manager: plugin.manager.entity_reference_selection interface: 'Drupal\Core\Entity\EntityReferenceSelection\SelectionInterface' - # @todo Remove this line and explicitly require valid entity reference - # selection plugin IDs in https://drupal.org/i/3420198. - allowFallback: true handler_settings: type: entity_reference_selection.[%parent.handler] label: 'Entity reference selection plugin settings' -- GitLab From cc9f792bba4938f7c2ffe4b49c5420f03001f354 Mon Sep 17 00:00:00 2001 From: bjorn <bjorn@swis.nl> Date: Fri, 18 Apr 2025 11:53:55 +0200 Subject: [PATCH 2/2] fix: NodeFieldOverridesTest should not assume default resolves into 'default:user'. --- core/modules/node/tests/src/Kernel/NodeFieldOverridesTest.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/modules/node/tests/src/Kernel/NodeFieldOverridesTest.php b/core/modules/node/tests/src/Kernel/NodeFieldOverridesTest.php index 70c4538a4a57..e8d433dc59a4 100644 --- a/core/modules/node/tests/src/Kernel/NodeFieldOverridesTest.php +++ b/core/modules/node/tests/src/Kernel/NodeFieldOverridesTest.php @@ -34,7 +34,7 @@ class NodeFieldOverridesTest extends EntityKernelTestBase { */ protected function setUp(): void { parent::setUp(); - $this->installConfig(['user']); + $this->installConfig(['user', 'field', 'node']); $this->user = $this->createUser(); \Drupal::service('current_user')->setAccount($this->user); } @@ -52,6 +52,7 @@ public function testFieldOverrides(): void { } $uid_field = \Drupal::service('entity_field.manager')->getBaseFieldDefinitions('node')['uid']; $config = $uid_field->getConfig('ponies'); + $config->setSetting('handler', 'default:user'); $config->save(); $this->assertEquals('Drupal\node\Entity\Node::getDefaultEntityOwner', $config->get('default_value_callback')); /** @var \Drupal\node\NodeInterface $node */ -- GitLab