From 3c465879d964599fc90a71fb2b3bfe78c979e072 Mon Sep 17 00:00:00 2001 From: Riyas N R <riyas.nr@qed42.com> Date: Wed, 19 Feb 2025 20:49:48 +0530 Subject: [PATCH 1/2] Issue #2205797: Create unit test for ConfigManager()->getEntityTypeByIdName() --- .../Core/Config/ConfigDependencyTest.php | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/core/tests/Drupal/KernelTests/Core/Config/ConfigDependencyTest.php b/core/tests/Drupal/KernelTests/Core/Config/ConfigDependencyTest.php index b0ac992f084f..f0244ebff85b 100644 --- a/core/tests/Drupal/KernelTests/Core/Config/ConfigDependencyTest.php +++ b/core/tests/Drupal/KernelTests/Core/Config/ConfigDependencyTest.php @@ -657,4 +657,31 @@ protected function getDependentIds(array $dependents): array { return $dependent_ids; } + /** + * @covers ::getEntityTypeIdByName + */ + public function testgetEntityTypeIdByName(): void { + /** @var \Drupal\Core\Config\ConfigManagerInterface $config_manager */ + $config_manager = \Drupal::service('config.manager'); + /** @var \Drupal\Core\Config\Entity\ConfigEntityStorage $storage */ + $storage = $this->container->get('entity_type.manager') + ->getStorage('config_test'); + $entity_1 = $storage->create( + [ + 'id' => 'entity_1', + ] + ); + $entity_1->save(); + + // Test for config entity with type. + // Do a dry run using. + // \Drupal\Core\Config\ConfigManager::getEntityTypeIdByName(). + $config_entities = $config_manager->getEntityTypeIdByName($entity_1->getConfigDependencyName()); + $this->assertEquals('config_test', $config_entities, 'Entity type id is correct.'); + + // Test for simple config. + $this->assertNull($config_manager->getEntityTypeIdByName('system.site'), 'No entity type ID should be returned for system.site.'); + + } + } -- GitLab From 4f22dbc97b8608fbebf5896433ea89ed8374fbdd Mon Sep 17 00:00:00 2001 From: Riyas N R <riyas.nr@qed42.com> Date: Wed, 19 Feb 2025 20:58:57 +0530 Subject: [PATCH 2/2] Issue #2205797: Create unit test method name spell --- .../Drupal/KernelTests/Core/Config/ConfigDependencyTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/tests/Drupal/KernelTests/Core/Config/ConfigDependencyTest.php b/core/tests/Drupal/KernelTests/Core/Config/ConfigDependencyTest.php index f0244ebff85b..f2cf5af01831 100644 --- a/core/tests/Drupal/KernelTests/Core/Config/ConfigDependencyTest.php +++ b/core/tests/Drupal/KernelTests/Core/Config/ConfigDependencyTest.php @@ -660,7 +660,7 @@ protected function getDependentIds(array $dependents): array { /** * @covers ::getEntityTypeIdByName */ - public function testgetEntityTypeIdByName(): void { + public function testGetEntityTypeIdByName(): void { /** @var \Drupal\Core\Config\ConfigManagerInterface $config_manager */ $config_manager = \Drupal::service('config.manager'); /** @var \Drupal\Core\Config\Entity\ConfigEntityStorage $storage */ -- GitLab