1. 12 Oct, 2008 1 commit
  2. 06 Dec, 2007 1 commit
  3. 02 Aug, 2007 1 commit
  4. 01 May, 2007 1 commit
  5. 15 Feb, 2007 1 commit
  6. 15 Oct, 2006 1 commit
  7. 27 Aug, 2006 1 commit
  8. 24 Aug, 2006 1 commit
  9. 16 Aug, 2006 1 commit
  10. 05 Jul, 2006 1 commit
  11. 13 Apr, 2006 1 commit
  12. 15 Jan, 2006 2 commits
  13. 14 Jan, 2006 1 commit
  14. 22 Oct, 2005 1 commit
  15. 21 Oct, 2005 1 commit
  16. 25 Aug, 2005 1 commit
  17. 10 Aug, 2005 1 commit
  18. 30 Jul, 2005 1 commit
  19. 25 May, 2005 2 commits
  20. 31 Mar, 2005 1 commit
  21. 28 Jan, 2005 1 commit
  22. 27 Jan, 2005 3 commits
  23. 06 Dec, 2004 1 commit
  24. 04 Dec, 2004 1 commit
    • Dries's avatar
      · cbf3f21e
      Dries authored
      - Patch by Steven: fixed bug in pager_query().
      cbf3f21e
  25. 02 Dec, 2004 1 commit
  26. 29 Nov, 2004 1 commit
    • Dries's avatar
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so... · 29337ad8
      Dries authored
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent:
      
      db_query($query, $a, $b, $c);
      db_query($query, array($a, $b, $c));
      
      This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places.
      
      However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call.
      
      This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions.
      
      I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc.
      
      Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example:
      - array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3");
      - $params[] = 0;
      - $params[] = 1;
      - $result = call_user_func_array('db_query_range', $params);
      + $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1);
      
      and
      
      - return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit)));
      + return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit);
      
      I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too.
      
      This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query.  This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself.  With the new, documented syntax, there is no more excuse to put data directly in the query.
      29337ad8
  27. 31 Oct, 2004 1 commit
  28. 09 Sep, 2004 1 commit
    • Dries's avatar
      · b84b6e42
      Dries authored
      - Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments.
      b84b6e42
  29. 12 Aug, 2004 1 commit
  30. 25 Jul, 2004 1 commit
    • Dries's avatar
      · 702a0576
      Dries authored
      - Patch #9478 by JonBob: allow printf-style arguments in pager_query.
      
        Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature.
      
        This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
      702a0576
  31. 22 Jul, 2004 1 commit
  32. 02 Jul, 2004 1 commit
    • Dries's avatar
      · 9986cb36
      Dries authored
      - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).
      9986cb36
  33. 22 Jun, 2004 1 commit
  34. 21 Jun, 2004 1 commit
  35. 19 Jun, 2004 1 commit
    • Dries's avatar
      · cbc230a3
      Dries authored
      - Patch #7696 by TDobes: renamed 'static' to 'sticky' which is a more
        logical name.  Requires a database upgrade.
      cbc230a3
  36. 15 Apr, 2004 1 commit