1. 10 Jul, 2004 1 commit
    • Dries's avatar
      · ac5b5616
      Dries authored
      - More tab-improvements by JonBob: improved support for the default tabs!
      ac5b5616
  2. 08 Jul, 2004 2 commits
  3. 07 Jul, 2004 1 commit
  4. 06 Jul, 2004 1 commit
    • Dries's avatar
      · 9d35fe7a
      Dries authored
      - Patch #4166 by daBrado: don't show the profile fields when the user does
        not have the 'access users' permission set.
      9d35fe7a
  5. 04 Jul, 2004 1 commit
    • Dries's avatar
      · fe2b3e7c
      Dries authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
      
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
      
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
      fe2b3e7c
  6. 03 Jul, 2004 1 commit
  7. 02 Jul, 2004 1 commit
  8. 30 Jun, 2004 2 commits
  9. 28 Jun, 2004 3 commits
  10. 27 Jun, 2004 2 commits
    • Dries's avatar
      - Removed left-over instance of _user_profile(). · 7ebcac26
      Dries authored
      7ebcac26
    • Dries's avatar
      I refactored quite a bit of the user.module: · 1b1c4702
      Dries authored
      $ diffstat user.patch
      database/database.mysql |    4
      database/database.pgsql |    2
      database/updates.inc    |   10 -
      modules/block.module    |   20 +-
      modules/locale.module   |    9
      modules/profile.module  |  108 +++++++----
      modules/system.module   |    8
      modules/user.module     |  456 +++++++++++++++++++-----------------------------
      8 files changed, 289 insertions(+), 328 deletions(-)
      
      More functionality, less code.  Here is a list of the changes:
      
      - Some user API changes:
         + When $type is 'form', you have to return an associative array of groups.  In turn, each group is an array with a 'title', 'data' and 'weight'.
         + A new $type has been added, namely 'categories'.  User settings can be organized in categories.  Categories can be sorted, as can the groups within a category.  (Ordering 'categories' is somewhat broken due to a bug in the menu system.)
      
      - The 'my account > edit' page will use subtabs for each 'category'.  Read: you can break down the account settings into multiple subpages.
      
      - Profile module improvements:
         + Added support for private fields to the profile module!
         + Improved workflow of profile administration pages.
         + Improved the form descriptions.
      
      - Code improvements:
         + Unified user_edit() and user_admin_edit().
         + Unified and cleaned up the validation code.  Fixed some validation glitches too.
      1b1c4702
  11. 24 Jun, 2004 2 commits
    • Dries's avatar
      · d4e7affb
      Dries authored
      - Bugfix: made it possible for administrators to edit the values of custom
        profile fields of users.
      d4e7affb
    • Dries's avatar
      · 3468310a
      Dries authored
      - Patch #8778 by Morbus Iff: with the tabs patch, user/login, user/register, and user/password now show all three forms, as opposed to just the requested relevance. The attached patch implements a quick workaround: three new callbacks, and a cheapy modification of user_page where I use a ternary to test whether arg(2) exists (as it would in the case of user/nnn/edit). If it does, we set that to $op, and if it doesn't (in the case of user/login, etc.), we set arg(1).
      3468310a
  12. 23 Jun, 2004 1 commit
    • Dries's avatar
      · ae6aa4e5
      Dries authored
      - Patch #8758 by Morbus Iff: allow users to modify their profile under
        the new tabs system.
      ae6aa4e5
  13. 22 Jun, 2004 1 commit
    • Dries's avatar
      · 0ee30cbc
      Dries authored
      - Fixed broken URLs in the user module (access rules) due the the recent
        tabs patch.
      0ee30cbc
  14. 21 Jun, 2004 1 commit
  15. 20 Jun, 2004 2 commits
  16. 18 Jun, 2004 1 commit
    • Dries's avatar
      · 54b77d64
      Dries authored
      Tabs patch!
      
      CHANGES
      -------
      
       + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
      
       + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
      
       + Grouped settings. All settings have been grouped under 'administer > settings'.
      
      TODO
      ----
      
       + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.
      
       + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
      54b77d64
  17. 14 Jun, 2004 1 commit
  18. 01 Jun, 2004 1 commit
  19. 31 May, 2004 2 commits
    • Kjartan's avatar
    • Dries's avatar
      · 7f08110a
      Dries authored
      - Improved form handling.
      
        + Introduced two new functions:
            1. form_set_error($name, $message): files an error against the form
               element with the specified  $name.
            2. form_has_errors(): returns true if errors has been filed against
               form elements.
      
        + Updated the form handling:
             1. The form_ functions will add 'class="error"' when a form field
                has been found to be erroneous.
             2. The error message is passed to theme_form_element() when the
                particular form field has been found to be erroneous.
      
        + I updated the user and profile module to take advantage of these new
          functions.
      
        + IMPORTANT: the _user() hook changed.  The 'validate' case should no
          longer retun an error message when something goes wrong but should
          set it with form_set_error().
      7f08110a
  20. 24 May, 2004 2 commits
  21. 21 May, 2004 1 commit
  22. 20 May, 2004 1 commit
    • Dries's avatar
      · fdb1fbfc
      Dries authored
      - Simplified the 'anonymous poster settings' of the comment module and
        made it possible to enforce a username/e-mail address.  Based on
        James Seng's work there are now 3 radio buttons:
      
         ( ) Anonymous users may not enter contact information
         ( ) Anonymous users may leave contact information
         ( ) Anonymous users must leave contact information
      
      - Fixed a bug in the default theme_comment_view() function.
      
      - Added permalinks for comments.  Requested by Michael and Christina.
        Maintainers of contributed themes might want to add permalinks too.
      
      TODO:
      
      - Fix the interaction design of the submission form: the page you are
        directed to and the validation of the contact information.
      
      - Changing the comment viewing options appears to be broken?
      fdb1fbfc
  23. 19 May, 2004 1 commit
  24. 15 May, 2004 1 commit
    • Dries's avatar
      · fed7e664
      Dries authored
      - Patch #6682 by jhriggs: added form_checkboxes(), much like form_radios()
        and updated some modules to take advantage of it.
      fed7e664
  25. 11 May, 2004 1 commit
  26. 10 May, 2004 1 commit
    • Dries's avatar
      · 1ad9afb8
      Dries authored
      - Added support for multiple user roles.  Patch by Jim Hriggs.
      1ad9afb8
  27. 01 May, 2004 1 commit
  28. 29 Apr, 2004 2 commits
  29. 22 Apr, 2004 1 commit
  30. 21 Apr, 2004 1 commit