1. 27 Jan, 2005 1 commit
  2. 19 Jan, 2005 2 commits
    • Dries's avatar
      · 7bdca92a
      Dries authored
      - Patch #6847 by Gerhard: replaced vocabulary->nodes by a separate table and tidied up the taxonomy API a bit.  This fixes a number of issues.
      7bdca92a
    • Steven Wittens's avatar
      - Fix tracker pager count query being wrong (it did not return a count but a... · 09bd156b
      Steven Wittens authored
      - Fix tracker pager count query being wrong (it did not return a count but a set, and it counted nodes with more than 1 comment as multiple nodes).
      - Clean up various SQL queries: removing literally inserted data (db_escape_string is evil!), fixing single "%" which should be "%%", fixing integers being compared as strings.
      09bd156b
  3. 17 Jan, 2005 3 commits
  4. 16 Jan, 2005 1 commit
    • Dries's avatar
      · 971a0e24
      Dries authored
      - Patch #14731 by chx: made it possible to rewrite node queries.
      971a0e24
  5. 28 Dec, 2004 1 commit
  6. 24 Dec, 2004 1 commit
  7. 15 Dec, 2004 1 commit
    • Dries's avatar
      - Patch #13907 by Neil: less ways to set the page title. · 2b17b3a9
      Dries authored
         * Less logic in theme code.
         * Encourages use of the menu system.
         * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
         * Very slightly more efficient.
      2b17b3a9
  8. 29 Nov, 2004 1 commit
    • Dries's avatar
      · e7ce1e3c
      Dries authored
      - Patch #11977 by matteo: added extra DISTINCT()s to two SQL queries to make them work with node-level permissions.
      e7ce1e3c
  9. 27 Nov, 2004 1 commit
  10. 23 Nov, 2004 1 commit
  11. 21 Nov, 2004 1 commit
    • Dries's avatar
      · fa978390
      Dries authored
      - Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
      
        Read the manual for pg_escape_string:  "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
      fa978390
  12. 15 Nov, 2004 2 commits
  13. 31 Oct, 2004 1 commit
    • Dries's avatar
      - Patch #11875 by Neil Drumm: block module configuration improvements. · b3adcf05
      Dries authored
      The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.
      
      Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.
      
      The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.
      
      An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
      b3adcf05
  14. 28 Oct, 2004 1 commit
  15. 18 Oct, 2004 1 commit
    • Dries's avatar
      · 1362571d
      Dries authored
      - Patch #11510 by Adrian: turned a non-ANSI SQL query into ANSI SQL so it works with PostgreSQL.
      1362571d
  16. 15 Oct, 2004 1 commit
    • Dries's avatar
      · dfb3c3ae
      Dries authored
      - Patch #11577 by drumm: changed t('ago') -> t('%time ago', ...) to make it
        translatable in languages such as Spanish.
      dfb3c3ae
  17. 14 Oct, 2004 1 commit
  18. 13 Oct, 2004 1 commit
  19. 04 Oct, 2004 1 commit
  20. 30 Sep, 2004 1 commit
    • Dries's avatar
      · 327a256a
      Dries authored
      - Removed the title attribute from the taxonomy links.  Temporary fix for #7468.
      327a256a
  21. 19 Sep, 2004 2 commits
  22. 16 Sep, 2004 1 commit
    • Dries's avatar
      · 5c7983c4
      Dries authored
      - Patch #8179 by JonBob: reintroduced menu caching.
      5c7983c4
  23. 14 Sep, 2004 1 commit
  24. 11 Sep, 2004 1 commit
  25. 08 Sep, 2004 1 commit
    • Dries's avatar
      · 7b716e8e
      Dries authored
      - Patch #10622 by Adrian: fixes various PostgreSQL related problems.
      
        1) Menu problems with Postgres (this is a highly critical 1 line fix)
        2) Archive module fails with Postgres
        3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch)
        4) Book module fails with Postgres
        5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug.
        6) Creating accregator_item_table in PostgreSQL
        7) Postgres - Polls not displayed on Poll Page
        8) Blog module has sql errors with postgres
      
        This should not affect MySQL users (hopefully).
      7b716e8e
  26. 03 Sep, 2004 1 commit
  27. 21 Aug, 2004 1 commit
    • Dries's avatar
      · 94e30bf7
      Dries authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
      94e30bf7
  28. 19 Aug, 2004 1 commit
    • Dries's avatar
      · fa25c7a0
      Dries authored
      - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions).
      fa25c7a0
  29. 18 Aug, 2004 1 commit
    • Dries's avatar
      · 83a739bd
      Dries authored
      - Code improvements by Stefan: made all status messages consistent (and easier to translate).
      83a739bd
  30. 16 Aug, 2004 1 commit
    • Dries's avatar
      · 2f33b939
      Dries authored
      - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter.
      2f33b939
  31. 12 Aug, 2004 1 commit
  32. 10 Aug, 2004 1 commit
  33. 09 Aug, 2004 1 commit
  34. 07 Aug, 2004 2 commits
    • Dries's avatar
      · bdbc34c9
      Dries authored
      - Patch #6760 by JonBob: refactored the taxonomy module URLs to be nicer, improved the code/Doxygen comments.
      
        As discussed before, the path "taxonomy/page/or/1,2" becomes "taxonomy/term/1+2" and the path "taxonomy/page/and/1,2" becomes "taxonomy/term/1,2". The most common case of listing nodes attached to a single term becomes simpler, since it doesn't require a meaningless "or" or "and". A depth of "0" is assumed, but a positive integer or "all" can be used. Feeds are available at "taxonomy/term/1+2/all/feed" and the like.
      
        This iteration of the patch also changes the structure of taxonomy_select_nodes(), since it was not following Drupal conventions. A handful of contrib modules call this function, and will need to be updated. Instead of passing in a $taxonomy object containing parameters for the function, the parameters are passed independently. This simplifies the code quite a bit. The queries were changed to only return node IDs for speed; all results from this function are passed through node_load() anyway, so the extra information returned was discarded. The AND query was also changed to avoid the strange trick and remove an extra query, at the expense of a table join per root term in the AND. This cleans up the code substantially while at the same time enabling the use of AND with a depth parameter.
      
        TODO: update contribution modules.
      bdbc34c9
    • Dries's avatar
      · 6f024382
      Dries authored
      - Made the taxonomy module use drupal_goto() to fix up the interaction behavior.
      6f024382