- 22 Jan, 2005 1 commit
-
-
Dries Buytaert authored
+ The "add new comment" was missing for polls. + Renames $main to $teaser where appropriate to follow latest Drupal conventions.
-
- 19 Jan, 2005 1 commit
-
-
Steven Wittens authored
- Fix tracker pager count query being wrong (it did not return a count but a set, and it counted nodes with more than 1 comment as multiple nodes). - Clean up various SQL queries: removing literally inserted data (db_escape_string is evil!), fixing single "%" which should be "%%", fixing integers being compared as strings.
-
- 16 Jan, 2005 1 commit
-
-
Dries Buytaert authored
- Patch #14731 by chx: made it possible to rewrite node queries.
-
- 15 Dec, 2004 1 commit
-
-
Dries Buytaert authored
* Less logic in theme code. * Encourages use of the menu system. * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them. * Very slightly more efficient.
-
- 24 Nov, 2004 1 commit
-
-
Dries Buytaert authored
- Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated. Check your contributed modules and update them accordingly.
-
- 23 Nov, 2004 1 commit
-
-
Dries Buytaert authored
- Patch #6166 by Moshe: node preview should not display links. Push the links to the theme instead of the theme having to pull them in using node_link(). TODO: 1. Update theme upgrade instructions in the handbook: node_link() is gone. 2. Remove page_link() just like we removed node_link().
-
- 31 Oct, 2004 1 commit
-
-
Dries Buytaert authored
The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions. Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook. The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path. An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
-
- 18 Sep, 2004 1 commit
-
-
Steven Wittens authored
-
- 16 Sep, 2004 1 commit
-
-
Dries Buytaert authored
- Patch #8179 by JonBob: reintroduced menu caching.
-
- 08 Sep, 2004 1 commit
-
-
Dries Buytaert authored
- Patch #10622 by Adrian: fixes various PostgreSQL related problems. 1) Menu problems with Postgres (this is a highly critical 1 line fix) 2) Archive module fails with Postgres 3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch) 4) Book module fails with Postgres 5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug. 6) Creating accregator_item_table in PostgreSQL 7) Postgres - Polls not displayed on Poll Page 8) Blog module has sql errors with postgres This should not affect MySQL users (hopefully).
-
- 21 Aug, 2004 1 commit
-
-
Dries Buytaert authored
- Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
-
- 18 Aug, 2004 1 commit
-
-
Dries Buytaert authored
- Code improvements by Stefan: made all status messages consistent (and easier to translate).
-
- 16 Aug, 2004 1 commit
-
-
Dries Buytaert authored
- Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter.
-
- 31 Jul, 2004 1 commit
-
-
Dries Buytaert authored
- Patch #9543 by JonBob: added node-level access control!
-
- 30 Jul, 2004 1 commit
-
-
Dries Buytaert authored
- Patch #5347 by JonBob: Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first: Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming. Advantages of this refactoring: - I can use it for book.module to remove the extra viewing path. - The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value. - We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them). - The attachment.module people could use it to append their attachments in a list after the node. - Gabor could use it instead of his filter perversion for his "articles in a series" module. - A little less code in each view hook. - The content hook is no longer needed, so that means even less code. Disadvantages: - Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules). - Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway). Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
-
- 07 Jul, 2004 1 commit
-
-
Dries Buytaert authored
-
- 06 Jul, 2004 1 commit
-
-
Dries Buytaert authored
- Patch #9049 by JonBob: fixed a number of tab issues.
-
- 04 Jul, 2004 2 commits
-
-
Steven Wittens authored
- If you are allowed to vote, results are now shown on a separate node tab "node/id/results". - Poll voting now submits to a separate URL and uses drupal_goto to go back to the poll node
-
Dries Buytaert authored
- Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly: * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error(). * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
-
- 20 Jun, 2004 1 commit
-
-
Dries Buytaert authored
-
- 18 Jun, 2004 1 commit
-
-
Dries Buytaert authored
Tabs patch! CHANGES ------- + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page. + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'. + Grouped settings. All settings have been grouped under 'administer > settings'. TODO ---- + Update core themes: only Xtemplate default supports tabs and even those look ugly. Need help. + Update contributed modules. The menu() hook changed drastically. Updating your code adhere the new menu() function should be 90% of the work. Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
-
- 09 May, 2004 1 commit
-
-
Dries Buytaert authored
-
- 21 Apr, 2004 1 commit
-
-
Dries Buytaert authored
- Added support for 403 handling. Patch by JonBob. As a side benefit, administrators will be able to define a custom 403 page, just as they can define 404 pages now. This needs to be documented in the "Changes since / migrating to ..." pages.
-
- 14 Apr, 2004 1 commit
-
-
Steven Wittens authored
Poll.module / Statistics.module: fixing bug caused by using array_merge and drupal_map_assoc. This causes array keys to be renumbered, leading to bugs. Remember to use $array1 + $array2 instead.
-
- 25 Feb, 2004 1 commit
-
-
Dries Buytaert authored
- Patch by Gerhard: move the updates to database/updates.inc so packaging systems can by-pass update.php.
-
- 24 Feb, 2004 1 commit
-
-
Steven Wittens authored
* Code cleaning: simpler structures, removed some old leftovers, ... * Clean URLs everywhere (the old mechanism was broken anyway). Had to get rid of 'inline voting' (i.e. voting with the sideblock and ending up on the same page), but that was a bit confusing anyway. * Simplified submission form with form_group and streamlined choice mechanism. * Improved bar rendering in pollresults for themes with avatars, like xtemplate.
-
- 15 Feb, 2004 1 commit
-
-
Dries Buytaert authored
- Patch 5592 by Goba: let drupal_map_assoc() rule. :-) - Renamed CHANGELOG to CHANGELOG.txt for Windows uses.
-
- 27 Jan, 2004 1 commit
-
-
Dries Buytaert authored
- Patch 5049 by JonBob: allow a module to define multiple node types.
-
- 23 Jan, 2004 1 commit
-
-
Dries Buytaert authored
Patch 5287 by Stefan: multiline help texts should become inside a single $output.
-
- 11 Jan, 2004 1 commit
-
-
Dries Buytaert authored
-
- 04 Jan, 2004 1 commit
-
-
Dries Buytaert authored
- Patch 4948 by Goba: the poll module uses check_output() on the poll options.
-
- 30 Dec, 2003 1 commit
-
-
Steven Wittens authored
- Re-added STYLE/ON*= filtering (this got lost a while ago due to reorganisation) - Added form_group's to node.module's filter options - Fixed incorrect filter usage in poll.module
-
- 22 Dec, 2003 1 commit
-
-
Dries Buytaert authored
the theme functions left the poll module's poll_view() function in a state where it does not display the poll results or vote forms on their own pages, since it uses another (proprietary) $block parameter to handle the case when the poll is rendered to be displayed in a block. Patch by Goba.
-
- 17 Dec, 2003 1 commit
-
-
Dries Buytaert authored
- Updated the calls to menu() to use MENU_HIDE instead of 1
-
- 25 Nov, 2003 1 commit
-
-
Dries Buytaert authored
- Committed phase 4 of JonBob's menu system changes.
-
- 23 Nov, 2003 1 commit
-
-
Dries Buytaert authored
- Committed phase 3 of JonBob's menu changes. Adds an API for modules to define titles and breadcrumbs for their pages, and updates the theme system to display them.
-
- 20 Nov, 2003 1 commit
-
-
Dries Buytaert authored
- Patch by JonBob: Phase 2 of the menu system integration project. This unifies the interface used by admin and non-admin pages, and deprecates the _page hook in favor of explicit callbacks from menu(). Breadcrumbs, titles, and help text go away as a result of this patch; they will return in the phase 3 patch, printed by the theme.
-
- 09 Nov, 2003 1 commit
-
-
Dries Buytaert authored
- Committed stage 2 of the theme system improvements! Patch by CodeMonkeyX.
-
- 08 Nov, 2003 1 commit
-
-
Dries Buytaert authored
- Committed stage 1 of the menu callbacks improvements. Patch by Jonathan.
-
- 07 Nov, 2003 1 commit
-
-
Dries Buytaert authored
- Usability improvement: replaced many selection boxes by radio buttons. Patch by Stefan.
-