1. 23 Nov, 2004 2 commits
  2. 21 Nov, 2004 1 commit
    • Dries's avatar
      · fa978390
      Dries authored
      - Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
        Read the manual for pg_escape_string:  "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
  3. 15 Nov, 2004 1 commit
    • Dries's avatar
      · 9979acea
      Dries authored
      - Patch #12783 by Stefan: various small consistency/usability improvements.
  4. 07 Nov, 2004 2 commits
    • Dries's avatar
      · f01bd675
      Dries authored
      - Performance improvement: made 'sid' the primary key of the sessions table.
        That should improve performance of session handling as well improve
        performance of the "Who's online"-block.  Drupal.org's sessions table
        contains appr. 40.000 sessions on a slow day and rendering the "Who's
        online"-block became a performance bottleneck.
        This change has yet to be tested on a busy site so things might go wrong.
    • Dries's avatar
      - Patch #12658 by menesis: when an administrator adds a user, the... · a16be349
      Dries authored
      - Patch #12658 by menesis: when an administrator adds a user, the 'authenticated user' role was not assigned to the new user.
  5. 03 Nov, 2004 1 commit
  6. 02 Nov, 2004 1 commit
  7. 31 Oct, 2004 2 commits
    • Dries's avatar
      - Patch #11875 by Neil Drumm: block module configuration improvements. · b3adcf05
      Dries authored
      The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.
      Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.
      The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.
      An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
    • Dries's avatar
      - Patch #12232 by Steven/UnConed: search module improvements. · 8daed9cb
      Dries authored
      1) Clean up the text analyser: make it handle UTF-8 and all sorts of characters. The word splitter now does intelligent splitting into words and supports all Unicode characters. It has smart handling of acronyms, URLs, dates, ...
      2) It now indexes the filtered output, which means it can take advantage of HTML tags. Meaningful tags (headers, strong, em, ...) are analysed and used to boost certain words scores. This has the side-effect of allowing the indexing of PHP nodes.
      3) Link analyser for node links. The HTML analyser also checks for links. If they point to a node on the current site (handles path aliases) then the link's words are counted as part of the target node. This helps bring out commonly linked FAQs and answers to the top of the results.
      4) Index comments along with the node. This means that the search can make a difference between a single node/comment about 'X' and a whole thread about 'X'. It also makes the search results much shorter and more relevant (before this patch, comments were even shown first).
      5) We now keep track of total counts as well as a per item count for a word. This allows us to divide the word score by the total before adding up the scores for different words, and automatically makes noisewords have less influence than rare words. This dramatically improves the relevancy of multiword searches. This also makes the disadvantage of now using OR searching instead of AND searching less problematic.
      6) Includes support for text preprocessors through a hook. This is required to index Chinese and Japanese, because these languages do not use spaces between words. An external utility can be used to split these into words through a simple wrapper module. Other uses could be spell checking (although it would have no UI).
      7) Indexing is now regulated: only a certain amount of items will be indexed per cron run. This prevents PHP from running out of memory or timing out. This also makes the reindexing required for this patch automatic. I also added an index coverage estimate to the search admin screen.
      8) Code cleanup! Moved all the search stuff from common.inc into search.module, rewired some hooks and simplified the functions used. The search form and results now also use valid XHTML and form_ functions. The search admin was moved from search/configure to admin/search for consistency.
      9) Improved search output: we also show much more info per item: date, author, node type, amount of comments and a cool dynamic excerpt à la Google. The search form is now much more simpler and the help is only displayed as tips when no search results are found.
      10) By moving all search logic to SQL, I was able to add a pager to the search results. This improves usability and performance dramatically.
  8. 19 Oct, 2004 1 commit
  9. 18 Oct, 2004 1 commit
    • Dries's avatar
      · 07cdcb43
      Dries authored
      - Patch by James: made the blogapi module work again.
  10. 16 Oct, 2004 2 commits
    • Dries's avatar
      - Patch #11505 by Steven: 'my account' information is not saved. · 869a91b7
      Dries authored
        + Drupal 4.4 stored profile data in the serialized user->data column. Drupal 4.5 stores profile data in tables (but user->data is still available and used for other stuff, like locale or themes).  The update from 4.4 to 4.5 didn't remove the old data from the user->data column properly, because there is no mechanism in user_save to do so (it did try to unset the fields, but this has no effect).
        + On registration, hook_user('insert') is invoked after saving the data column. This means that any module-specific data is put into the data field. We cannot move hook_user('insert') higher up, because before that point, we do not have a complete $user object yet.
    • Dries's avatar
      - Patch #11642 by Steven: when editing a user as an admin, you can choose the... · 5a2e0d03
      Dries authored
      - Patch #11642 by Steven: when editing a user as an admin, you can choose the user's roles through form checkboxes. If the form validation fails and the form is redisplayed, the roles are lost. This is because the format for $user->roles is different from what form_checkboxes uses.
  11. 12 Oct, 2004 2 commits
  12. 06 Oct, 2004 1 commit
    • Dries's avatar
      · 9a8cd6a2
      Dries authored
      - Patch #11312 by killes: fixed problems with menu caching.
  13. 28 Sep, 2004 1 commit
    • Dries's avatar
      · 60f945bc
      Dries authored
      - Patch #11138 by Al: fixed GUI problem with deleting users.
  14. 24 Sep, 2004 2 commits
  15. 21 Sep, 2004 1 commit
  16. 20 Sep, 2004 1 commit
    • Dries's avatar
      · 16d3f9bc
      Dries authored
      - Patch #10845 by James: fixed the user/help page.
  17. 19 Sep, 2004 4 commits
    • Dries's avatar
      - Usability improvement: on the registration page, mark the username and e-mail · bc581161
      Dries authored
        address as required fields.  This makes for more consistent behavior, as the
        profile module might add required fields that are marked as such.
    • Dries's avatar
      · 5281a220
      Dries authored
      - Usability improvement: made the status messages use <em>foo</em> rather than "foo".
    • Dries's avatar
      · 6dbd0bcf
      Dries authored
      - Patch #6500 by Mathias with help from Steven: made it possible to add fields to the registration form.  This feature used to exist.
    • Dries's avatar
      · 34fc0b88
      Dries authored
      - Patch #10922 by drumm: usability improvment: tabified the user account pages (login, register, request new password).
  18. 17 Sep, 2004 2 commits
  19. 16 Sep, 2004 1 commit
    • Dries's avatar
      · 5c7983c4
      Dries authored
      - Patch #8179 by JonBob: reintroduced menu caching.
  20. 13 Sep, 2004 2 commits
  21. 12 Sep, 2004 1 commit
  22. 11 Sep, 2004 1 commit
  23. 10 Sep, 2004 1 commit
    • Dries's avatar
      · 0ddee8ff
      Dries authored
      - Patch #10718 by drumm: bugfix: it was possible to save a user with no roles assigned when the form clearly said at least one was required. The result of saving that was silently leaving the roles unchanged, which is rather bad.
  24. 08 Sep, 2004 1 commit
    • Dries's avatar
      · 2dedf5fb
      Dries authored
      - Modified patch #10644 by drumm: fixed some broken URLs.  Patch modified to
        use /user/$uid instead of /user/$uid/edit (where possible).
  25. 27 Aug, 2004 1 commit
  26. 24 Aug, 2004 2 commits
    • Steven Wittens's avatar
    • Steven Wittens's avatar
      Patch by me and Kjartan. · 44f341be
      Steven Wittens authored
      - Fixing a bug caused by the PHP5 patches.
      Beware: PHP4's array_merge() will silently accept objects and convert them to arrays. We should not depend on this behaviour in the future.
      File.inc / file-using modules:
      - Removing the constant FILE_SEPARATOR: forward slashes work fine on Windows, and it was being used incorrectly as an URL separator sometimes.
      - Adding @ to mkdir and chmod to supress ugly PHP errors. They are already reported with drupal_set_message().
      - Fixing default for variable 'file_directory_temp'.
      - Clarifying the help tip for 'file_directory_temp' in admin > settings.
  27. 22 Aug, 2004 1 commit
  28. 21 Aug, 2004 1 commit
    • Dries's avatar
      · 94e30bf7
      Dries authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.