1. 10 Jun, 2001 1 commit
    • Dries's avatar
      · d397bbe9
      Dries authored
      This a rather large commit that needs a lot of fine-tuning.  If you
      update, you'll break your site as you need switching from structure
      to index.module: so this can be considered an intermediate commit.
      
      If you upgrade, and you are welcome to, just create a collection
      called "section" (for now) and assign your nodes some attributes
      in the described format.
      
      Feedback and bugreports are welcomed.  Questions will be answered.
      
      CHANGES:
      
      - comment system:
         + when replying to a node (rather then to a comment), that
           node is displayed above the reply form.
         + when replying to a comment (rather then to a node), that
           comment is displayd above the reply form.
      
      - removed structure.inc, removed structure.module.
      
      - node.inc:
         + added 2 new node functions called 'node_attribute_edit()' and
           'node_attribute_save()' used to 'hook in' any indexing system
          including your home-brewed stuff if you'd want to.  Currently,
          index.module is the facto default index system.
      
          See story.module for usage.
      
      - book.module, story.module, poll.module, page.module, forum.module:
         + added preview functionality to administration section (via node
           module).
         + removed all references to structure.inc (category, topic).
      
      - moderate.module:
         + removed all references to structure.inc (category, topic).
      
      - book.module, story.module, page.module, forum.module:
         + increased the sizes of some textareas.
      
      - submit.php:
         + removed all references to structure.inc (category, topic).
      
      - marvin.theme:
         + removed dead code: function story() was depricated.
      
      - unconed.theme:
         + removed hardcoded references to drop.org.
      
      - marvin.theme, unconed.theme, jeroen.theme, yaroon.theme, example.theme:
         + removed all references to structure.inc (category, topic).
      
      TODO:
      
      - file.module, trip_link.module:
         + update preview functionality:
             see story.module for example.
         + remove references to 'cid' and 'tid', use 'attribute' instead:
             see story.module for example.
      
      - extend and build upon index.module as well as making it configurable
      d397bbe9
  2. 20 May, 2001 1 commit
    • Dries's avatar
      CHANGES · 20397ad3
      Dries authored
      - Redid settings.module and even renamed it to conf.module.
          * Settings are now grouped in basic categories like "system
            settings", "module settings" and "filters".
        * Added new settings to make Drupal easier to configure and
        to make some aspects like the watchdog scale better.
      
      - Renamed includes/settings.php to includes/conf.php.
      
      - Added filter support to conf.module and introduced filter hooks so
        modules can implement and export new filters.  Example filters are
        an HTML filter (implemented), a profanity filter, an url converter,
        ASCII smileys to images filter and so on ...
      
      - Reworked the check_* functions: user contributed content/input is
        only verified and filtered once in its lifespan.
      
      NOTES
      
      - Altough this is a large commit, no database changes are required.
      20397ad3
  3. 17 May, 2001 2 commits
    • Dries's avatar
      · 031e4d42
      Dries authored
      - Tidied up the field_get() API and improved the implementation of
        both field_set() and field_get().
      031e4d42
    • Dries's avatar
      · 6c387962
      Dries authored
      - Fixed bug in account.module.
      
      - Simplified field_set() API.
      
      - Made UnConeD's cool common timestamp format conform with the
        general coding style.  Sorry to be so picky about this but I
        really can't help it. ;)
      6c387962
  4. 16 May, 2001 1 commit
    • Dries's avatar
      · 6f02738c
      Dries authored
      - Removed the "history"-field from the SQL table "users" and added
        this information to the "users"-field in both nodes and comments.
        This database/table change reduces the number of SQL queries and
        makes Drupal scale better where a lot of voting/moderation takes
        place.  Last but not least it can be considered a new and better
        foundation for future moderation metrics / algorithms.  In other
        words: it is plain better.
      
          --> oops, all voting/moderation results will be lost!
          --> requires database update, see "2.00-to-x.xx.sql"!
      
      - Updated database/database.mysql
      6f02738c
  5. 29 Apr, 2001 1 commit
    • Dries's avatar
      · 828f36cd
      Dries authored
      - Addition: added a new, tiny forum module: I will use this forum
        module to develop and test the permission system along with the
        regular nodes.  And hopefully, this forum module will grow into
        a very useable piece of code for drop.org.
      
        Requires a new SQL table "forum", see 2.00-to-x.xx.sql.
      
      - Removed 1 unused hook from page.module.
      
      - Removed 1 unused function from comment.inc.
      828f36cd
  6. 21 Apr, 2001 2 commits
    • Steven Wittens's avatar
      a66c4e59
    • Dries's avatar
      · cccb132c
      Dries authored
      - Addition: added a "promote" field to the node table, which
        makes "promoting nodes" to the main page possible.  Stories
        and reviews could be promoted by default, but - on accasion
        a good book entry could be manually promoted too.  Thus all
        existing content types can be shown on the main page, not
        just stories.
      
        Requires a SQL update, see 2.00-to-x.xx.sql!
      
      - Addition: implemented "auto-post new submissions" feature
        to disable or by-pass the moderation queue in addition to
        "moderate new submissions".
      
        TODO: admin moderation versus registered user moderation.
      
      - Addition: added category and topic support to page.module.
      cccb132c
  7. 19 Apr, 2001 1 commit
    • Dries's avatar
      · 3f1979aa
      Dries authored
      - Addition: made it so that comments can be enabled/disabled on
        a node per node basis, rather then on a category per category
        basis.  The default settings for each individual category can
        be changed though.
      
        Example: it can be setup so that - by default - all stories
        posted to the category "article" will have comments enabled
        but stories submitted to "announcement" not.
      
        Different configuration schemes can easily be added later.
      
        Requires a SQL update, see 2.00-to-x.xx.sql/database.mysql.
      
      - Addition: made submit.php only use categories that users can
        actually submit new content to.
      3f1979aa
  8. 16 Apr, 2001 1 commit
    • Dries's avatar
      · b1c66cb5
      Dries authored
      Another big update so please read this carefully because there is important information hidden in it.
      
      Made it so that we can disable/enable comments on a category by category basis. In order to accomplish this I had to make a few (*temporary*) changes.
      
      I moved all comment code from the "module level" (eg. story.module) to the "node level".  It was nothing but the logical next step in nodifying drupal.  This enables us to add comments to all existing content types including book entries.  But also for book entries, this to can be toggled on and off. :-)
      
      Moreover module writers don't have to worry about the complex comment logic: it is "abstracted" away.  This implies that story.module got smaller, faster and easier to comprehend. :-)
      
      In order to accomplish this, I had to update ALL THEMES, which I did - and on my way I updated Goofy, Oranzh and UnConeD - with the previous changes.  All themes are up-to-date now!  I also had to remove the [ reply to this story ] links, and temporally re-introcuded the "Add comment" button in the "Comment control".  Tempora lly that is, UnConeD. ;)
      
      I plan to upgrade drop.org either tommorow or wednesday so test away if you have some time to kill. ;)
      
      Oh, I also fixed a few bugs and made various small improvements.
      b1c66cb5
  9. 15 Apr, 2001 1 commit
    • Dries's avatar
      · 1f056580
      Dries authored
      - improved submit.php:
        it now uses the new category code, incl content bindings.
        You can setup different "categories" which map on a content
        type.  Example:
          review   -> review.module
          article  -> story.module
          column   -> story.module
          announc. -> story.module
          addons   -> file.module
          themes   -> file.module
      - "generalised" story.module and book.module's output.
      - fixed bug in includes/timer.inc
      - fixed glitch in theme example.theme: it said "$how by" but
        the variable $how has never been declared.
      - added "drupal development settings" to display some timings
      - more work on the categories/topics -> does NOT work yet
      1f056580
  10. 09 Apr, 2001 1 commit
  11. 06 Apr, 2001 1 commit
    • Dries's avatar
      · 8213f5b2
      Dries authored
      A lot of small changes (search-n-replace) make a big commit:
      
        - fixed update bug in book.module
        - provide a log message when both adding and updating book pages
        - all configurable variables are now accessed through "variable_get()":
        - rewrote watchdog and submission throttle and removed watchdog.inc
        - improved robustness of sections.inc
        - imporved story.module
        - updated ./database/database.sql
      8213f5b2
  12. 05 Apr, 2001 1 commit
    • Dries's avatar
      · 048664f2
      Dries authored
      - a bunch of various updates
      048664f2
  13. 02 Apr, 2001 1 commit
    • Dries's avatar
      · 805107cd
      Dries authored
      Commiting my work of last Sunday:
      
       - removed ban.inc and ban.module and integrated it in account.module
         under the name "access control" --> the ban code was not really up
         to standard so this has now been dealt with.  This refactoring and
         reintegration cuts down the code size with 100 lines too.  :-)
         (The ban.module code was really old and it showed.)
      
       - added node.module and made the other modules reuse some of this
         code --> cut down the code size of modules by at least 100 lines
         and adds stability.
      
       - added a status() function to admin.php to display a conform status
         message where appropriate.  See admin.php for usage.
      
       - removed $theme->control() and made comments.inc handle this itself
         wrapped in a $theme->box().  No need to clutter the themes with
         such complexity --> updated all themes already. :-)
      
       - some small visual changes to some administration pages to be more
         consistent across different modules.
      805107cd
  14. 29 Mar, 2001 1 commit
    • Dries's avatar
      · 04ad9b8a
      Dries authored
      - fixed issue depricated call-by-reference issues
      - fixed small visual glitch in includes/function.inc
      - changed SQL tables around a bit to be more consistent
        (result: small changes to a lot of different files)
      - improved robustness of includes/node.inc
      - improved output of cron.module
      - improved output of node.php
      04ad9b8a
  15. 24 Mar, 2001 1 commit
    • Dries's avatar
      · fe095f5a
      Dries authored
      - simplified the comment code: the SQL queries are less complex, thus
        faster now.
      fe095f5a
  16. 21 Mar, 2001 1 commit
  17. 10 Mar, 2001 2 commits
    • Dries's avatar
      · 266167b9
      Dries authored
      - fixed small glitch as a result from David's patch
      266167b9
    • Dries's avatar
      · accd5f0c
      Dries authored
      - applied David Norman's patch to turn all <?'s into fully qualified
        <?php's.
      accd5f0c
  18. 08 Mar, 2001 3 commits
    • Dries's avatar
      · a1b15833
      Dries authored
      - more small improvements
      a1b15833
    • Dries's avatar
      - small bugfix · 87916cf8
      Dries authored
      87916cf8
    • Dries's avatar
      · 3958a714
      Dries authored
      - some important changes to our theme API which can be summerized as:
      
           abstract() + article() = story()
      
        abstract() and article() have been merged into a new function story()
        which looks like:
      
        function story($story_object, $reply) {
          if (!reply) {
             // full story
          }
          else {
             // main page version / abstract
          }
        }
      
        This should allow you to "compress" your theme as abstract() and
        article() tended to be 98% identical.
      
        => I didn't really merge your themes so I leave it up to *you* to
           improved the code!!! Do it ASAP as we release drupal 2.00 in 7
           days.
      
        In future we'll have similar functions for other content types as
        for example:
      
           review($review, $reply);
           enquete($enquete, $reply);
           ...
      3958a714
  19. 07 Mar, 2001 1 commit
    • Dries's avatar
      · f516626a
      Dries authored
      A rather large and important update:
      
      revised most of the SQL queries and tried to make drupal as secure as possible (while trying to avoid redundant/duplicate checks).  For drupal's sake, try to screw something up.  See the mail about PHPNuke being hacked appr. 6 days ago.  The one who finds a problem is rewarded a beer (and I'm willing to ship it to Norway if required).  I beg you to be evil.  Try dumping a table a la "http://localhost/index.php?date=77778;DROP TABLE users" or something. ;)
      f516626a
  20. 01 Mar, 2001 1 commit
    • Dries's avatar
      · 728249cb
      Dries authored
      - fixed small translation glitch in format_interval
      - added a couple of missing t() functions
      - improved the comments module, fixed the score problem Jeroen
        reported earlier -> it's slicker but I hope it won't break anything
      728249cb
  21. 18 Feb, 2001 1 commit
    • Dries's avatar
      · 4371b627
      Dries authored
      - added fine-grained user permission system which allows us to give
        certain users access to specific administration sections only.
          Ex. a FAQ maintainer can only edit the FAQ, and members of an
              "editorial board" can only edit comments, diaries and
               stories, ..
      - code review => rewrote include/user.inc which is much easier now
      - fixed 4 small bugs
      4371b627
  22. 17 Feb, 2001 1 commit
    • Dries's avatar
      · 52a1d1bb
      Dries authored
      - More updates on the translation support
      52a1d1bb
  23. 12 Feb, 2001 1 commit
    • Dries's avatar
      · db554e85
      Dries authored
      - initial import of the preliminary translation code.
      - added timer.inc for benchmarking purpose
      - bugfix for php-clean
      - bugfix for account.php
      - removed redundant format_data
      - ...
      db554e85
  24. 04 Feb, 2001 1 commit
  25. 25 Jan, 2001 1 commit
    • Dries's avatar
      · f162723f
      Dries authored
      - fixed ieni-wienie small bug in comment.inc (reported by NotZen)
      f162723f
  26. 21 Jan, 2001 1 commit
    • Dries's avatar
      · 7cc7b405
      Dries authored
      - fixed some bugs in the new comment/discussion code and added a few
        enhancements
      7cc7b405
  27. 20 Jan, 2001 3 commits
    • Dries's avatar
      · 8b4181d0
      Dries authored
      - 2 more bugfixes
      8b4181d0
    • Dries's avatar
      · e25c50b9
      Dries authored
      - 3 small bugfixes
      e25c50b9
    • Dries's avatar
      · 2952d16f
      Dries authored
      - updated/improved discussion engine: it needs additional fine-tuning
        though but I think this is stable enough for public consumption and
        real-life testing.
         ==> a first big step towards a flexible comment engine.
      
      IMPORTANT:
        - Required theme updatins:
      
          UnConeD: check your $theme->controls() as I added a very, very
                   dummy implementation
      
        - Required database updates:
      
          alter table users modify mode tinyint(1) DEFAULT '' NOT NULL;
          alter table comments change sid lid int(6) DEFAULT '0' NOT NULL;
          alter table comments add link varchar(16) DEFAULT '' NOT NULL;
          update comments set link = 'story';
      2952d16f
  28. 03 Nov, 2000 1 commit
    • Dries's avatar
      - fixed bug in search.php · aa1b366d
      Dries authored
      - fixed bug in discussion.php
      - theme update: comment() now takes 3 arguments:
          $comment - an object with comment data
          $link    - a link to the reply form of that particular
                     comment
          $thread  - the subthread of that particular comment
      - theme 'marvin' and theme 'zaphod' are updated, theme
        'unconed' is left to be done
      aa1b366d