1. 29 Apr, 2001 3 commits
    • natrak's avatar
      Fixes · c8d16d76
      natrak authored
       - Changed include "includes/common.inc"; to include_once
         "includes/common.inc"; Including the common file more than once will
         cause bad things.
      c8d16d76
    • Dries's avatar
      · ef7d5e12
      Dries authored
      CHANGES:
      
      - Added new form_* functions to common.inc, used for building
        forms: it should improve 'stability' (no form typos, every-
        thing properly escaped/unescaped) and should help providing
        a very consistent user interface (wrt forms).
      
      - Adjusted node.module to use the new form functions.
        (Can be used as an example.)
      
      - Adjusted book.module to use the new form functions.
        (Can be used as an example.)
      
      - Merged function.inc into common.inc!
      
      - Slowly removing all global $status and $rstatus variables:
        use node_status() instead.
      
      TODO:
      
      - Apart from implementing the permission system, I'll spend
        some time updating most modules today and tomorrow to use
        the new form functions.
      ef7d5e12
    • Dries's avatar
      · 828f36cd
      Dries authored
      - Addition: added a new, tiny forum module: I will use this forum
        module to develop and test the permission system along with the
        regular nodes.  And hopefully, this forum module will grow into
        a very useable piece of code for drop.org.
      
        Requires a new SQL table "forum", see 2.00-to-x.xx.sql.
      
      - Removed 1 unused hook from page.module.
      
      - Removed 1 unused function from comment.inc.
      828f36cd
  2. 27 Apr, 2001 2 commits
    • Kjartan's avatar
      CHANGES · 95f92686
      Kjartan authored
      - Modified conf_init() to use default.conf if nothing else can be found.
      - Added some comments to hostname.conf to reflect the changes and
        provide more information on how to rename the file.
      
      TODO
      - The Drupal handbook should be updated once the CVS version is released.
      - Should try to remove the remainder of info from hostname.conf and go for a
        completely web-based administration if possible.
      - Does having all the settings in a SQL database make Drupal add more
        overhead than including a .conf file? If nobody knows for sure some tests
        should be done. If yes, concider having the admin interface generate an
        include file in addition to saving to the database.
      95f92686
    • natrak's avatar
      CHANGES · 4f6b2151
      natrak authored
      - Modified conf_init() to use default.conf if nothing else can be found.
      - Added some comments to hostname.conf to reflect the changes and
        provide more information on how to rename the file.
      
      TODO
      - The Drupal handbook should be updated once the CVS version is released.
      - Should try to remove the remainder of info from hostname.conf and go for a
        completely web-based administration if possible.
      - Does having all the settings in a SQL database make Drupal add more
        overhead than including a .conf file? If nobody knows for sure some tests
        should be done. If yes, concider having the admin interface generate an
        include file in addition to saving to the database.
      4f6b2151
  3. 23 Apr, 2001 2 commits
    • Kjartan's avatar
      Changes · bd8952eb
      Kjartan authored
      - Fixed an error in module_rehash_blocks() that didn't handle '-symbols.
      - Removed some module depencies. Drupal will now run (sorta) even if there
        are no modules installed.
      - Changed theme_link() to check if certain modules are installed before
        offering a link to them.
      
      Todo
      - Check all SQL queries to make sure they are addslashes'ed correctly.
      - Check the effects of changing the PHP magic_quotes setting.
      - Make the theme_link() function to be customizable either via the admin
        page and/or in the module itself.
      bd8952eb
    • natrak's avatar
      Changes · 78def048
      natrak authored
      - Fixed an error in module_rehash_blocks() that didn't handle '-symbols.
      - Removed some module depencies. Drupal will now run (sorta) even if there
        are no modules installed.
      - Changed theme_link() to check if certain modules are installed before
        offering a link to them.
      
      Todo
      - Check all SQL queries to make sure they are addslashes'ed correctly.
      - Check the effects of changing the PHP magic_quotes setting.
      - Make the theme_link() function to be customizable either via the admin
        page and/or in the module itself.
      78def048
  4. 22 Apr, 2001 1 commit
    • natrak's avatar
      - Fixed the update sql file. Changes have to start with the oldest and progress · 78bee959
      natrak authored
        to the newest. It would try to change tables that had not yet been created
        causing major problems to the node module. (NOTE: if you are doing a x.xx
        update to another x.xx version you might have to force MySQL to perform it
        using the -f flag. Remember to always backup your data before making
        changes).
      - Prevented 2.00-to-x.xx.php from executing. It would simply give a PHP error
        and not execute. Will wait for Dries to return before attempting to make it
        functional or remove it.
      78bee959
  5. 21 Apr, 2001 13 commits
  6. 19 Apr, 2001 8 commits
    • Dries's avatar
      · 3f1979aa
      Dries authored
      - Addition: made it so that comments can be enabled/disabled on
        a node per node basis, rather then on a category per category
        basis.  The default settings for each individual category can
        be changed though.
      
        Example: it can be setup so that - by default - all stories
        posted to the category "article" will have comments enabled
        but stories submitted to "announcement" not.
      
        Different configuration schemes can easily be added later.
      
        Requires a SQL update, see 2.00-to-x.xx.sql/database.mysql.
      
      - Addition: made submit.php only use categories that users can
        actually submit new content to.
      3f1979aa
    • Dries's avatar
      · a6e6dfb9
      Dries authored
      - Addition: added 2 new functions check_mail() and check_name()
        to functions.inc useful for resp. verifying an e-mail address
        and username: currently used by account.php - but reusable by
        Julian's refer.module for example (prepares integration).
      a6e6dfb9
    • Dries's avatar
      · 78cd8cda
      Dries authored
      - Addition: added a new function "module_hook($module, $hook)" to check
        wether a module implements a certain hook or not.
      78cd8cda
    • Dries's avatar
      · 11666090
      Dries authored
      - Addition: added new "cvs.module" to display and mail drupal's
        CVS log messages.  Our additional Perl script that hooks into
        the CVS repository is also provided in ./scripts.  Requires a
        SQL update, see 2.00-to-x.xx.sql.
      11666090
    • Dries's avatar
      · d001c733
      Dries authored
      - Updated CHANGELOG and fixed a few typos.
      d001c733
    • Dries's avatar
      · 7eb6d653
      Dries authored
      - Updated CHANGELOG and fixed a few typos.
      7eb6d653
    • Dries's avatar
      · a380938f
      Dries authored
      - Updated CHANGELOG
      a380938f
    • Dries's avatar
      · 45ed041b
      Dries authored
      - structure.inc: added category_name($cid) and topic_name($tid).
        They both return a linked string with the respective category,
        or topic name.  Updated all themes to use these new functions.
      
      - (stripped tabs from emsa files, nevermind)
      45ed041b
  7. 18 Apr, 2001 1 commit
  8. 17 Apr, 2001 3 commits
    • Dries's avatar
      · 73ad4c76
      Dries authored
      - fixed bug in page.module: $theme->header() got called twice.
      73ad4c76
    • Jeroen's avatar
      Hey, · 16c316c8
      Jeroen authored
      I also applied UnConeD's remark about the PHP_SELF. And remover jeroen2.theme, added yaroon.theme and commit it now. Dries, if you have 5 minutes, just move the jeroen2 directory to yaroon.
      
      Jeroen.
      16c316c8
    • Dries's avatar
      · 19f85e99
      Dries authored
      - fixed sub-directory problem reported by UnConeD
      19f85e99
  9. 16 Apr, 2001 7 commits
    • Jeroen's avatar
      I updated my theme, and changed something about the update Dries did. I think... · cedbefc9
      Jeroen authored
      I updated my theme, and changed something about the update Dries did. I think you left a <a href> there... But now it's OK. Also when I first looked at my theme it looked real ugly in NS .76, but then after some fiddling around, but restoring everything I changed it looked OK again. Weird. I haven't changed a thing. We'll see, if anything else happens make sure to let me know.
      cedbefc9
    • Dries's avatar
      · a6373132
      Dries authored
      - updated the forgotten theme: theme Jeroen doesn't render 100% correct in Netscape btw - it is certainly not due to my changes.  I have this feeling that there is an unclosed tag somewhere.
      
      - all these themes are getting a pain to maintain but I guess nothing we can do about it.  Hopefully the theme API is about to stabalize soon.  In future, we should certainly keep the number of "supported" below 10 so as so we have, say, 11 themes I suggest to kick out the one that is less interesting.  It will then become an "unsupported theme" available through drop.org/drupal but maybe not in prime condition.  It think we'll have our hands full with 10 themes already.  It is really the max IMHO.  Comments/suggestions/noding heads?
      a6373132
    • Dries's avatar
      · 6a71425e
      Dries authored
      - improved interface a bit
      6a71425e
    • Dries's avatar
      · b1c66cb5
      Dries authored
      Another big update so please read this carefully because there is important information hidden in it.
      
      Made it so that we can disable/enable comments on a category by category basis. In order to accomplish this I had to make a few (*temporary*) changes.
      
      I moved all comment code from the "module level" (eg. story.module) to the "node level".  It was nothing but the logical next step in nodifying drupal.  This enables us to add comments to all existing content types including book entries.  But also for book entries, this to can be toggled on and off. :-)
      
      Moreover module writers don't have to worry about the complex comment logic: it is "abstracted" away.  This implies that story.module got smaller, faster and easier to comprehend. :-)
      
      In order to accomplish this, I had to update ALL THEMES, which I did - and on my way I updated Goofy, Oranzh and UnConeD - with the previous changes.  All themes are up-to-date now!  I also had to remove the [ reply to this story ] links, and temporally re-introcuded the "Add comment" button in the "Comment control".  Tempora lly that is, UnConeD. ;)
      
      I plan to upgrade drop.org either tommorow or wednesday so test away if you have some time to kill. ;)
      
      Oh, I also fixed a few bugs and made various small improvements.
      b1c66cb5
    • Jeroen's avatar
      Hey, · 2f898ebc
      Jeroen authored
      This should be it. For now... I applied most of the remarks you told me to. Only the seemingly floating squares... well let's just say they add to the mysteriousness of the page. I can't delete them. I don't think my site would look without them. We'll just see what the users think of it shall we? I can ask them abou the squares once it's released. So, all there is now is the fat vertical bar in NS 4.76. I also don't know what it looks like in Opera... and UnConeD, does it show a bit OK in IE? I polished the navigation box' algorithm a bit. Even more stable now.
      
      I do have one remark Dries. When submitting something you don't have to choose story or book anymore but you have to select one of the categories. Is this OK? But wouldn't it be more logical to choose what type of thing you are going to submit. I don't think you will be placing an Announcement in the book. By the way how do you add a page to the book now? I can't find it... Or do I have to create book and story myself... Ahh heck Dries it's just broken OK? ;)
      
      For the rest. Oh yes, I am not going to work with the categories. The squares in front of a $story->title represent the topic the title is under (e.g.: linux, science, Media, Announcements) But not the category (I see them as a some sort of sub-folder in each topic) I haven't found a good way to display it yet. I still have to find how to import it in the lay-out so it wouldn't mess up. I already liked the fact that I don't have text-links for the former categories anymore... We'll see what happens...
      
      Jeroen.
      2f898ebc
    • Dries's avatar
      · 599677ef
      Dries authored
      - updated database.mysql file
      599677ef
    • Dries's avatar
      · 53c67ac0
      Dries authored
      - a few changes which might help overcome Jeroen's redeclartion problem
        (or might not)
      53c67ac0