1. 05 Aug, 2004 1 commit
    • Dries's avatar
      · c6b1eaa2
      Dries authored
      - Patch #9775 by TDobes: consistency operation.  Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view".
      c6b1eaa2
  2. 03 Aug, 2004 1 commit
    • Dries's avatar
      - Partial patch #9643 by Bart: · 254256de
      Dries authored
         + the confirmation before deleting a comment was missing a check_output.
         + after editing a comment, two pages were shown (two calls to theme('page',..)), replaced this by a drupal_goto.
      254256de
  3. 01 Aug, 2004 1 commit
    • Dries's avatar
      · 4aefe695
      Dries authored
      - Fixed broken link + removed redundant form descriptions (there is no point
        in repeating the title).
      4aefe695
  4. 14 Jul, 2004 1 commit
    • Dries's avatar
      · 9b49f01f
      Dries authored
      - Patch #7466 by TDobes: comments module would add a link of register even if "user_register" was set to 0.
      9b49f01f
  5. 13 Jul, 2004 1 commit
    • Dries's avatar
      · dbd1c4f1
      Dries authored
      - Patch #9253 by Morbus: fixed bug that manifested itself with a duplicate page when a user has submitted a comment that goes into the moderation queue. Part of the problem seemed to be that the "your comment is in the moderation queue" message was set as a theme print, as opposed to a drupal_set_message().  This patch fixes that, as well as adding a drupal_goto() to redirect the user back to where they came.
      dbd1c4f1
  6. 10 Jul, 2004 2 commits
    • Dries's avatar
      · bbb41d0f
      Dries authored
      - Patch by JonBob: updated the comment module to take advantage of the latest
        menu system improvements.
      bbb41d0f
    • Dries's avatar
      - Patch 8756 by Morbus: · e21f238a
      Dries authored
      * improves the doxygentation and help text.
      * deletes comment_admin and comment_page; using proper callbacks instead.
      * related/modified callbacks/menus/functions were tweaked to not use arg() at all.
      * the "settings" subtab was weighted to -10 so it'd appear first (in prep of JonBob's local default).
      * moderation pages weren't properly showing defined votes or thresholds; fixed.
      * when moderation votes or thresholds didn't exist, no error stating as such was shown; fixed.
      * we show "submit votes" on the moderation votes page only when votes actually exist.
      * fixes the (broken in CVS) comment/reply and comment/edit features.
      * fixes the (broken in CVS) "save settings" for comment view options and comment moderation.
      
      In addition I:
      
      * fixed a couple warnings introduced by Morbus' patch.
      * fixed a couple translation bugs.
      * fixed comment_node_url().
      
      I also found that:
      
      * the collapsed comment views (i.e. 'threaded list - collapsed) are broken.
      e21f238a
  7. 08 Jul, 2004 2 commits
    • Dries's avatar
      · 82c9fab7
      Dries authored
      - Patch #9010 by Morbus: reorganized the order of functions in the comment
        module.
      82c9fab7
    • Dries's avatar
      · 898bdeff
      Dries authored
      - Marked required fields on the node (story, book, page, blog) and comment
        forms using the $required argument of the form_ functions.
      
      - Replaced all Optional's and Required's from the taxonomy forms with proper
        use of the form_ functions.
      
      Please check your contributed modules too!
      898bdeff
  8. 07 Jul, 2004 1 commit
  9. 05 Jul, 2004 1 commit
  10. 04 Jul, 2004 1 commit
    • Dries's avatar
      · fe2b3e7c
      Dries authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
      
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
      
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
      fe2b3e7c
  11. 23 Jun, 2004 1 commit
    • Dries's avatar
      · 23142e0e
      Dries authored
      - Patch #8757 by Morbus Iff: fixed redirection after comment moderation.
      23142e0e
  12. 21 Jun, 2004 1 commit
  13. 20 Jun, 2004 3 commits
  14. 19 Jun, 2004 1 commit
    • Dries's avatar
      · a42b84e5
      Dries authored
      First tab improvements by Adrian:
      
        + Changed menu.inc to generate two separate lists instead of nested lists:
          that seems to be the only alternative to get rid of absolute positioning.
      
        + Changed the tabs code to be more sexy and put the code in misc/drupal.css
          so all themes are automagically updated.
      a42b84e5
  15. 18 Jun, 2004 1 commit
    • Dries's avatar
      · 54b77d64
      Dries authored
      Tabs patch!
      
      CHANGES
      -------
      
       + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
      
       + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
      
       + Grouped settings. All settings have been grouped under 'administer > settings'.
      
      TODO
      ----
      
       + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.
      
       + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
      54b77d64
  16. 17 Jun, 2004 1 commit
    • Dries's avatar
      · 7d19e3dc
      Dries authored
      - Patch #8553 by Moshe: hide the 'add new comment' link when showing the
        comment form.
      7d19e3dc
  17. 04 Jun, 2004 1 commit
  18. 02 Jun, 2004 2 commits
  19. 31 May, 2004 3 commits
    • Dries's avatar
      · 7a33d9f6
      Dries authored
      - Patch #7350 by Mathias: return part a taxonomy tree to a user-defined
        depth/level.
      
      - Updated CHANGELOG.txt.
      7a33d9f6
    • Dries's avatar
      · b08aba8f
      Dries authored
      - Reworked comment submission.  It is less broken now.
      b08aba8f
    • Dries's avatar
      · 7f08110a
      Dries authored
      - Improved form handling.
      
        + Introduced two new functions:
            1. form_set_error($name, $message): files an error against the form
               element with the specified  $name.
            2. form_has_errors(): returns true if errors has been filed against
               form elements.
      
        + Updated the form handling:
             1. The form_ functions will add 'class="error"' when a form field
                has been found to be erroneous.
             2. The error message is passed to theme_form_element() when the
                particular form field has been found to be erroneous.
      
        + I updated the user and profile module to take advantage of these new
          functions.
      
        + IMPORTANT: the _user() hook changed.  The 'validate' case should no
          longer retun an error message when something goes wrong but should
          set it with form_set_error().
      7f08110a
  20. 24 May, 2004 1 commit
    • Dries's avatar
      · a7713036
      Dries authored
      - Patch 7444 (#35) by Pablo.  This patch addresses some issues with showing
        anonymous usernames in comments.  It does not solve all my problems, but
        others claim it works as advertised.  I'm committing this because it does
        fix some pending issues (even though that might not be the end of it).
      a7713036
  21. 20 May, 2004 1 commit
    • Dries's avatar
      · fdb1fbfc
      Dries authored
      - Simplified the 'anonymous poster settings' of the comment module and
        made it possible to enforce a username/e-mail address.  Based on
        James Seng's work there are now 3 radio buttons:
      
         ( ) Anonymous users may not enter contact information
         ( ) Anonymous users may leave contact information
         ( ) Anonymous users must leave contact information
      
      - Fixed a bug in the default theme_comment_view() function.
      
      - Added permalinks for comments.  Requested by Michael and Christina.
        Maintainers of contributed themes might want to add permalinks too.
      
      TODO:
      
      - Fix the interaction design of the submission form: the page you are
        directed to and the validation of the contact information.
      
      - Changing the comment viewing options appears to be broken?
      fdb1fbfc
  22. 18 May, 2004 1 commit
    • Dries's avatar
      · 10c5e95a
      Dries authored
      - Made it possible for anonymous users to leave their name, e-mail address
        and the URL of their homepage.  Patch by Pablo.
      10c5e95a
  23. 10 May, 2004 2 commits
  24. 03 May, 2004 1 commit
    • Dries's avatar
      · bfca0888
      Dries authored
      - Patch #7504 by bylund: multiple form_radio-function calls is used instead
        of a single form_radios-call. This could cause problems when trying to
        style individual form elements.
      bfca0888
  25. 01 May, 2004 2 commits
  26. 21 Apr, 2004 1 commit
    • Dries's avatar
      · 7231c88a
      Dries authored
      - Added support for 403 handling.  Patch by JonBob.  As a side benefit,
        administrators will be able to define a custom 403 page, just as they
        can define 404 pages now.
      
        This needs to be documented in the "Changes since / migrating to ..."
        pages.
      7231c88a
  27. 18 Apr, 2004 1 commit
    • Dries's avatar
      · 291b56c0
      Dries authored
      - Fixed problem with global session variable that caused the wrong page to
        be rendered after posting a comment.
      291b56c0
  28. 15 Apr, 2004 2 commits
  29. 21 Mar, 2004 1 commit
    • Dries's avatar
      - More profile module improvements: · 754f2ac2
      Dries authored
        + Updated the _user() hook's "$type == 'view'" case to match the
           "$type == 'edit'" case.  That is, both have to return an associtive
           array of the format array('category' => 'fields').
      
         + Updated the profile pages to group fields by category.  Made possible
           thanks to the above change.
      
         + Moved logic out of the theme_ functions.
      754f2ac2
  30. 20 Mar, 2004 1 commit