1. 05 Jul, 2006 1 commit
  2. 13 Apr, 2006 1 commit
  3. 15 Jan, 2006 2 commits
  4. 14 Jan, 2006 1 commit
  5. 22 Oct, 2005 1 commit
  6. 21 Oct, 2005 1 commit
  7. 25 Aug, 2005 1 commit
  8. 10 Aug, 2005 1 commit
  9. 30 Jul, 2005 1 commit
  10. 25 May, 2005 2 commits
  11. 31 Mar, 2005 1 commit
  12. 28 Jan, 2005 1 commit
  13. 27 Jan, 2005 3 commits
  14. 06 Dec, 2004 1 commit
  15. 04 Dec, 2004 1 commit
    • Dries's avatar
      · cbf3f21e
      Dries authored
      - Patch by Steven: fixed bug in pager_query().
      cbf3f21e
  16. 02 Dec, 2004 1 commit
  17. 29 Nov, 2004 1 commit
    • Dries's avatar
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so... · 29337ad8
      Dries authored
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent:
      
      db_query($query, $a, $b, $c);
      db_query($query, array($a, $b, $c));
      
      This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places.
      
      However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call.
      
      This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions.
      
      I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc.
      
      Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example:
      - array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3");
      - $params[] = 0;
      - $params[] = 1;
      - $result = call_user_func_array('db_query_range', $params);
      + $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1);
      
      and
      
      - return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit)));
      + return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit);
      
      I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too.
      
      This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query.  This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself.  With the new, documented syntax, there is no more excuse to put data directly in the query.
      29337ad8
  18. 31 Oct, 2004 1 commit
  19. 09 Sep, 2004 1 commit
    • Dries's avatar
      · b84b6e42
      Dries authored
      - Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments.
      b84b6e42
  20. 12 Aug, 2004 1 commit
  21. 25 Jul, 2004 1 commit
    • Dries's avatar
      · 702a0576
      Dries authored
      - Patch #9478 by JonBob: allow printf-style arguments in pager_query.
      
        Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature.
      
        This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
      702a0576
  22. 22 Jul, 2004 1 commit
  23. 02 Jul, 2004 1 commit
    • Dries's avatar
      · 9986cb36
      Dries authored
      - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).
      9986cb36
  24. 22 Jun, 2004 1 commit
  25. 21 Jun, 2004 1 commit
  26. 19 Jun, 2004 1 commit
    • Dries's avatar
      · cbc230a3
      Dries authored
      - Patch #7696 by TDobes: renamed 'static' to 'sticky' which is a more
        logical name.  Requires a database upgrade.
      cbc230a3
  27. 15 Apr, 2004 1 commit
  28. 15 Feb, 2004 1 commit
    • Dries's avatar
      · 74229399
      Dries authored
      - Patch 5834 by Jeremy: made multiple pagers on one page work.
      74229399
  29. 06 Jan, 2004 1 commit
  30. 22 Dec, 2003 1 commit
    • Dries's avatar
      · 7883ea6e
      Dries authored
      - Accessibility improvement: changed a <b>-tag to a <strong>-tag, used to
        indicated the current page.
      7883ea6e
  31. 08 Dec, 2003 2 commits
    • Dries's avatar
      - Improvements by Goba: · 712a30b5
      Dries authored
        + removes the lots of pagers and indirect pager themeing
        + add the theme_pager() function, which should be called as
          theme("pager", ...) to get a pager.
      712a30b5
    • Dries's avatar
      · 3904790e
      Dries authored
      - Tidied up the DoxyGen comments.  Patch by Kjartan.
      3904790e
  32. 24 Nov, 2003 1 commit
    • Dries's avatar
      Patch by Ax to fixe and improve to the core doxygen PHPdoc: · 06045ff7
      Dries authored
        * fixes all doxygen warnings [#]_ in the current code base
          + changes @param style from phpDocumentor (@param type $var desc) to doxygen (@param $var desc)
          + documents all undocumented parameters
          + escapes / fixes html warnings
          + fixes @defgroup in theme.inc
        * adds more groupings [#]_
          + drupal_{set|get}_title, drupal_{set|get}_breadcrumb
          + pager.inc: pager_api (pager_query(), pager_display()), pager pieces
        * adds a new group "themeable" which contains all themeable functions.
      06045ff7
  33. 09 Nov, 2003 1 commit
    • Dries's avatar
      · 951b553a
      Dries authored
      - Committed stage 2 of the theme system improvements!  Patch by CodeMonkeyX.
      951b553a
  34. 04 Jun, 2003 1 commit
    • Dries's avatar
      · 355d25e7
      Dries authored
      - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4.  This fixes critical bug #1618.  Patch by Marco.
      
        ==> This fix requires to run update.php!
      
      - Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.
      
      - Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.
      
      - Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.
      
      - Code improvements: removed some dead code from the comment module.  Patch by Marco.
      
      - Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.
      
      - CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.
      
      - GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.
      
      - GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.
      
      - GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.
      
      - GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.
      
      TODO:
      
      - Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.
      
      - There is code emitting '<div align="right">' which doesn't validate.
      
      - Does our XML feeds validate with the charset changes?
      
      - The forum module's SQL doesn't work properly on PostgreSQL.
      355d25e7
  35. 03 Jun, 2003 1 commit
    • Dries's avatar
      - Bugfix: made request_uri() rewrite ( and ) with their entity equivalents · 05288ac4
      Dries authored
      to avoid XSS attacks!  Patch by Al, Moshe, Marco, Kjartan and me.
      
      - Bugfix: the admin module does now import drupal.css prior to admin.css.
      Patch by me.
      
      - Bugfix: the admin module was still emitting a <base href=""> tag.  I
      removed this as it is been taken care of by theme_head();  Patch by me.
      
      - Bugfix: made the tracker module's pager only consider published pages.
      Patch by Moshe.
      
      - Bugfix: cured some typos in the comment module's help function.  Patch by
      Marco.
      
      - Bugfix: fixed a typo in the pager_display() that caused optional
      attributes to be discarded.
      
      - Bugfix: made the Xtemplate emit empty boxes like any other theme does.
      Patch by Al.
      
      - Bugfix: fixed broken link on the statistics module's log page.
      Reported by Kjartan.
      
      - CSS improvements: made the HTML output emitted by the tracker module
      look nicer.  Patch by Moshe and Al.
      
      - CSS improvements: added CSS classes for form elements.  Patch by Al.
      
      - CSS improvements: added a vertical gap between the last form item and the
      submit button.  Patch by Al.  Note that Opera 6 is not picking up this
      CSS but apparently others browsers such as Konqueror do.
      
      - Xtemplate improvements: changed the color of the selected day in the
      archive module's calendar.  Patch by Al.
      
      - Usability improvements: made the "birthday" field of the profile module
      look nicer.  Patch by Al.
      
      ------
      
      - TODO: it might be a good idea to emit the following meta tag in the
      theme_head() function:
      
      <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
      
      Currently, some themes (and modules!) emit this while others don't.  This
      would also make it possible to change the charset site-wide.
      
      - TODO: now we added support for td.dark and td.light to drupal.css, maybe
      it can be removed from admin.css as well as xtemplate.css?
      05288ac4