1. 04 Nov, 2004 1 commit
    • Dries's avatar
      - Patch #12232 by Steven: more search improvements: · b6eee48c
      Dries authored
         + When a comment is posted, a node needs to be re-indexed. Luckily, we can use node_comment_statistics for this easily.
         + When a node is deleted, it should be deleted from the search index as well.
         + The search wipe didn't properly remove links to nodes from the index.
         + Section url was faulty in _help.
         + Minor code rearrangement.
      b6eee48c
  2. 03 Nov, 2004 1 commit
    • Dries's avatar
      - Patch by Steven: · bd6ae693
      Dries authored
         + Display 'friendly' name rather than module name in search watchdog
           messages.
         + Remove left-over from search_total table.
         + Add index wipe button to the admin
         + Moved the admin to admin/settings/search
         + Prevented menu bug when node modules update the breadcrumb in view
           (thanks JonBob).
         + Changed search_total table's word key to PRIMARY.
      bd6ae693
  3. 31 Oct, 2004 2 commits
    • Dries's avatar
      - Patch #11875 by Neil Drumm: block module configuration improvements. · b3adcf05
      Dries authored
      The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.
      
      Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.
      
      The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.
      
      An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
      b3adcf05
    • Dries's avatar
      - Patch #12232 by Steven/UnConed: search module improvements. · 8daed9cb
      Dries authored
      1) Clean up the text analyser: make it handle UTF-8 and all sorts of characters. The word splitter now does intelligent splitting into words and supports all Unicode characters. It has smart handling of acronyms, URLs, dates, ...
      
      2) It now indexes the filtered output, which means it can take advantage of HTML tags. Meaningful tags (headers, strong, em, ...) are analysed and used to boost certain words scores. This has the side-effect of allowing the indexing of PHP nodes.
      
      3) Link analyser for node links. The HTML analyser also checks for links. If they point to a node on the current site (handles path aliases) then the link's words are counted as part of the target node. This helps bring out commonly linked FAQs and answers to the top of the results.
      
      4) Index comments along with the node. This means that the search can make a difference between a single node/comment about 'X' and a whole thread about 'X'. It also makes the search results much shorter and more relevant (before this patch, comments were even shown first).
      
      5) We now keep track of total counts as well as a per item count for a word. This allows us to divide the word score by the total before adding up the scores for different words, and automatically makes noisewords have less influence than rare words. This dramatically improves the relevancy of multiword searches. This also makes the disadvantage of now using OR searching instead of AND searching less problematic.
      
      6) Includes support for text preprocessors through a hook. This is required to index Chinese and Japanese, because these languages do not use spaces between words. An external utility can be used to split these into words through a simple wrapper module. Other uses could be spell checking (although it would have no UI).
      
      7) Indexing is now regulated: only a certain amount of items will be indexed per cron run. This prevents PHP from running out of memory or timing out. This also makes the reindexing required for this patch automatic. I also added an index coverage estimate to the search admin screen.
      
      8) Code cleanup! Moved all the search stuff from common.inc into search.module, rewired some hooks and simplified the functions used. The search form and results now also use valid XHTML and form_ functions. The search admin was moved from search/configure to admin/search for consistency.
      
      9) Improved search output: we also show much more info per item: date, author, node type, amount of comments and a cool dynamic excerpt à la Google. The search form is now much more simpler and the help is only displayed as tips when no search results are found.
      
      10) By moving all search logic to SQL, I was able to add a pager to the search results. This improves usability and performance dramatically.
      8daed9cb
  4. 29 Oct, 2004 1 commit
  5. 19 Oct, 2004 1 commit
  6. 16 Oct, 2004 1 commit
    • Dries's avatar
      · 7ebd772f
      Dries authored
      - Patch #10664 by TDobes: fixed collapsed comments + updated the code comments.
      7ebd772f
  7. 12 Oct, 2004 1 commit
  8. 10 Oct, 2004 1 commit
  9. 09 Oct, 2004 1 commit
  10. 04 Oct, 2004 2 commits
  11. 28 Sep, 2004 1 commit
  12. 21 Sep, 2004 1 commit
    • Dries's avatar
      · 4f5164c9
      Dries authored
      - Patch #10977 by Gerhard: added missing node access controls for RSS feeds.
      4f5164c9
  13. 20 Sep, 2004 2 commits
  14. 16 Sep, 2004 1 commit
    • Dries's avatar
      · 5c7983c4
      Dries authored
      - Patch #8179 by JonBob: reintroduced menu caching.
      5c7983c4
  15. 14 Sep, 2004 2 commits
  16. 09 Sep, 2004 2 commits
  17. 08 Sep, 2004 1 commit
  18. 06 Sep, 2004 1 commit
  19. 25 Aug, 2004 1 commit
  20. 23 Aug, 2004 1 commit
  21. 22 Aug, 2004 1 commit
  22. 21 Aug, 2004 2 commits
    • Dries's avatar
      · 8b8a2bd6
      Dries authored
      - Patch #10187 by JonBob: bugfix: added missing permission check.
      8b8a2bd6
    • Dries's avatar
      · 94e30bf7
      Dries authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
      94e30bf7
  23. 19 Aug, 2004 1 commit
    • Dries's avatar
      · fa25c7a0
      Dries authored
      - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions).
      fa25c7a0
  24. 18 Aug, 2004 1 commit
    • Dries's avatar
      · 83a739bd
      Dries authored
      - Code improvements by Stefan: made all status messages consistent (and easier to translate).
      83a739bd
  25. 17 Aug, 2004 1 commit
    • Dries's avatar
      · 78b052a6
      Dries authored
      - The upload (filehandler) module has landed!
      78b052a6
  26. 16 Aug, 2004 3 commits
    • Dries's avatar
      · 451821ab
      Dries authored
      - Patch #10110 by JonBob: code improvement: looks like we have an artifact from before clean URLs in node.module. This patch removes the global variable $mod, which is no longer set and not necessary here anyway.
      451821ab
    • Dries's avatar
      · 2f33b939
      Dries authored
      - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter.
      2f33b939
    • Dries's avatar
      · ef07dd08
      Dries authored
      - Patch #10102 by Gerhard: removing some cruft from the node module!
      ef07dd08
  27. 14 Aug, 2004 1 commit
  28. 13 Aug, 2004 1 commit
  29. 12 Aug, 2004 2 commits
  30. 11 Aug, 2004 1 commit
    • Dries's avatar
      · 1831e1b6
      Dries authored
      - New locale module thanks to Gerhard, Goba, Marco, Kristjan and others.
      
        The new locale module provides every functionality on the web interface, so you don't need to edit the configuration files or add columns, when you add a new language. This module is an integration of the old locale and localegettext modules, plus a bunch of logic to parse Gettext Portable Object files (opposed to Machine Object files, as supported by localegettext).
      
        Note: I made some minor changes to the context-sensitive help texts and to some of the status messages.
      1831e1b6
  31. 10 Aug, 2004 1 commit
    • Steven Wittens's avatar
      The Input formats - filter patch has landed. I still need to make update... · 660f9928
      Steven Wittens authored
      The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
      
      Here's an overview of the changes:
      1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
      The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.
      
      The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.
      
      2) Filters have toggles
      Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.
      
      3) Multiple filters per module
      This was necessary to accomodate the next change, and it's also a logical extension of the filter system.
      
      4) Embedded PHP is now a filter
      Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
      This change means that block.module now passes custom block contents through the filter system.
      As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.
      
      5) User-supplied PHP code now requires <?php ?> tags.
      This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.
      
      Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.
      
      6) Filter caching was added.
      Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.
      
      7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.
      
      8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
      660f9928