1. 31 Oct, 2004 2 commits
    • Dries Buytaert's avatar
      - Patch #11875 by Neil Drumm: block module configuration improvements. · b3adcf05
      Dries Buytaert authored
      The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.
      Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.
      The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.
      An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
    • Dries Buytaert's avatar
      - Patch #12232 by Steven/UnConed: search module improvements. · 8daed9cb
      Dries Buytaert authored
      1) Clean up the text analyser: make it handle UTF-8 and all sorts of characters. The word splitter now does intelligent splitting into words and supports all Unicode characters. It has smart handling of acronyms, URLs, dates, ...
      2) It now indexes the filtered output, which means it can take advantage of HTML tags. Meaningful tags (headers, strong, em, ...) are analysed and used to boost certain words scores. This has the side-effect of allowing the indexing of PHP nodes.
      3) Link analyser for node links. The HTML analyser also checks for links. If they point to a node on the current site (handles path aliases) then the link's words are counted as part of the target node. This helps bring out commonly linked FAQs and answers to the top of the results.
      4) Index comments along with the node. This means that the search can make a difference between a single node/comment about 'X' and a whole thread about 'X'. It also makes the search results much shorter and more relevant (before this patch, comments were even shown first).
      5) We now keep track of total counts as well as a per item count for a word. This allows us to divide the word score by the total before adding up the scores for different words, and automatically makes noisewords have less influence than rare words. This dramatically improves the relevancy of multiword searches. This also makes the disadvantage of now using OR searching instead of AND searching less problematic.
      6) Includes support for text preprocessors through a hook. This is required to index Chinese and Japanese, because these languages do not use spaces between words. An external utility can be used to split these into words through a simple wrapper module. Other uses could be spell checking (although it would have no UI).
      7) Indexing is now regulated: only a certain amount of items will be indexed per cron run. This prevents PHP from running out of memory or timing out. This also makes the reindexing required for this patch automatic. I also added an index coverage estimate to the search admin screen.
      8) Code cleanup! Moved all the search stuff from common.inc into search.module, rewired some hooks and simplified the functions used. The search form and results now also use valid XHTML and form_ functions. The search admin was moved from search/configure to admin/search for consistency.
      9) Improved search output: we also show much more info per item: date, author, node type, amount of comments and a cool dynamic excerpt à la Google. The search form is now much more simpler and the help is only displayed as tips when no search results are found.
      10) By moving all search logic to SQL, I was able to add a pager to the search results. This improves usability and performance dramatically.
  2. 30 Oct, 2004 1 commit
  3. 29 Oct, 2004 2 commits
  4. 28 Oct, 2004 3 commits
  5. 27 Oct, 2004 1 commit
  6. 26 Oct, 2004 2 commits
  7. 23 Oct, 2004 6 commits
  8. 20 Oct, 2004 1 commit
  9. 19 Oct, 2004 1 commit
  10. 18 Oct, 2004 7 commits
  11. 17 Oct, 2004 2 commits
    • Dries Buytaert's avatar
      - Patch #11670 by TDobes: comment.module did not properly set a breadcrumb for... · a423eefe
      Dries Buytaert authored
      - Patch #11670 by TDobes: comment.module did not properly set a breadcrumb for creating/previewing new comments. The node on which your commenting and its location within the menu is not displayed. Instead, there is only a "Home" link. This is especially apparent when the "add new comment" form is set up to display on a separate page.
    • Dries Buytaert's avatar
      · 3302104f
      Dries Buytaert authored
      - Patch by Gerhard: small update to INSTALL.txt.
  12. 16 Oct, 2004 6 commits
    • Steven Wittens's avatar
      #11449: Adding a failsafe check for an improperly prefixed menu sequence. This... · b228f018
      Steven Wittens authored
      #11449: Adding a failsafe check for an improperly prefixed menu sequence. This is a temporary fix, awaiting a proper install system to end manual prefixing ;).
    • Dries Buytaert's avatar
      - Patch #11505 by Steven: 'my account' information is not saved. · 869a91b7
      Dries Buytaert authored
        + Drupal 4.4 stored profile data in the serialized user->data column. Drupal 4.5 stores profile data in tables (but user->data is still available and used for other stuff, like locale or themes).  The update from 4.4 to 4.5 didn't remove the old data from the user->data column properly, because there is no mechanism in user_save to do so (it did try to unset the fields, but this has no effect).
        + On registration, hook_user('insert') is invoked after saving the data column. This means that any module-specific data is put into the data field. We cannot move hook_user('insert') higher up, because before that point, we do not have a complete $user object yet.
    • Dries Buytaert's avatar
      - Patch #11642 by Steven: when editing a user as an admin, you can choose the... · 5a2e0d03
      Dries Buytaert authored
      - Patch #11642 by Steven: when editing a user as an admin, you can choose the user's roles through form checkboxes. If the form validation fails and the form is redisplayed, the roles are lost. This is because the format for $user->roles is different from what form_checkboxes uses.
    • Dries Buytaert's avatar
      · 2c45ab85
      Dries Buytaert authored
      - Fixed bug #9948: added some checks to system_setting_save() to avoid PHP warnings/errors.
    • Dries Buytaert's avatar
      · 7ebd772f
      Dries Buytaert authored
      - Patch #10664 by TDobes: fixed collapsed comments + updated the code comments.
    • Steven Wittens's avatar
      #7289: locale import fixes · ba276192
      Steven Wittens authored
  13. 15 Oct, 2004 6 commits