1. 12 Nov, 2005 1 commit
  2. 10 Nov, 2005 1 commit
  3. 09 Nov, 2005 1 commit
  4. 01 Nov, 2005 1 commit
  5. 31 Oct, 2005 2 commits
  6. 22 Oct, 2005 1 commit
  7. 11 Oct, 2005 1 commit
  8. 08 Oct, 2005 1 commit
    • Dries's avatar
      - Patch #33433 by chx: fixed a number of form API problems. · 7863be5e
      Dries authored
          * Default form value
          * Leftover debug function in form.inc
          * PHP5 issue with comment date (I got this patch from another issue)
          * Validation error fix (was calling legacy form validate)
          * Lots o' warnings on comment preview
          * Filter tips plus argument (gremlins. I swear this was not there.)
          * Message to clear what's going on with system settings
          * Non-freetagging taxonomies fixed
      7863be5e
  9. 07 Oct, 2005 1 commit
    • Dries's avatar
      - Patch #29465: new form API by Adrian et al. · 7e1527ee
      Dries authored
        TODO:
        + The contact.module was broken; a new patch for contact.module is needed.
        + Documentation is needed.
        + The most important modules need to be updated ASAP.
      7e1527ee
  10. 27 Sep, 2005 1 commit
  11. 17 Sep, 2005 1 commit
  12. 25 Aug, 2005 1 commit
  13. 14 Aug, 2005 2 commits
  14. 29 Jul, 2005 1 commit
  15. 29 Jun, 2005 1 commit
  16. 27 Jun, 2005 1 commit
  17. 21 Jun, 2005 1 commit
  18. 01 Jun, 2005 1 commit
  19. 07 May, 2005 2 commits
  20. 05 May, 2005 1 commit
  21. 24 Apr, 2005 1 commit
    • Dries's avatar
      · a76a1e1f
      Dries authored
      - Patch 20910 by chx: centralize print theme page.
      a76a1e1f
  22. 20 Apr, 2005 2 commits
  23. 01 Apr, 2005 1 commit
  24. 31 Mar, 2005 1 commit
  25. 18 Mar, 2005 1 commit
  26. 07 Mar, 2005 1 commit
  27. 03 Mar, 2005 1 commit
  28. 23 Jan, 2005 1 commit
    • Dries's avatar
      · 668e8cbf
      Dries authored
      - Patch #16016 by Goba: fixed various bugs in filter tip display.
      668e8cbf
  29. 19 Jan, 2005 2 commits
  30. 03 Jan, 2005 1 commit
  31. 15 Dec, 2004 1 commit
    • Dries's avatar
      - Patch #13907 by Neil: less ways to set the page title. · 2b17b3a9
      Dries authored
         * Less logic in theme code.
         * Encourages use of the menu system.
         * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
         * Very slightly more efficient.
      2b17b3a9
  32. 29 Nov, 2004 1 commit
    • Dries's avatar
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so... · 29337ad8
      Dries authored
      - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent:
      
      db_query($query, $a, $b, $c);
      db_query($query, array($a, $b, $c));
      
      This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places.
      
      However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call.
      
      This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions.
      
      I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc.
      
      Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example:
      - array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3");
      - $params[] = 0;
      - $params[] = 1;
      - $result = call_user_func_array('db_query_range', $params);
      + $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1);
      
      and
      
      - return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit)));
      + return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit);
      
      I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too.
      
      This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query.  This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself.  With the new, documented syntax, there is no more excuse to put data directly in the query.
      29337ad8
  33. 15 Nov, 2004 1 commit
    • Dries's avatar
      · 9979acea
      Dries authored
      - Patch #12783 by Stefan: various small consistency/usability improvements.
      9979acea
  34. 30 Oct, 2004 1 commit
  35. 14 Oct, 2004 1 commit