1. 30 Jul, 2004 1 commit
    • Dries Buytaert's avatar
      · aed1b0ca
      Dries Buytaert authored
      - Patch #5347 by JonBob:
      Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:
      Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.
      Advantages of this refactoring:
      - I can use it for book.module to remove the extra viewing path.
      - The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
      - We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
      - The attachment.module people could use it to append their attachments in a list after the node.
      - Gabor could use it instead of his filter perversion for his "articles in a series" module.
      - A little less code in each view hook.
      - The content hook is no longer needed, so that means even less code.
      - Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
      - Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).
      Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
  2. 29 Jul, 2004 1 commit
    • Steven Wittens's avatar
      Fixing a rather nasty bug with page cache: · 6c73823b
      Steven Wittens authored
      The headers stored for cached pages ended in a newline, which caused header("") to get called when serving the page.
      On some PHP versions (happens on 4.3.3 at least, but not in 5.0), PHP adds a blank header to the HTTP request (i.e. just \r\n) which ends HTTP headers prematurely and adds a newline at the beginning of the page.
      This was not an issue before because we output HTML. Now that we have GZip compression, this bug caused corruption of the output. :P
  3. 28 Jul, 2004 3 commits
  4. 26 Jul, 2004 1 commit
    • Dries Buytaert's avatar
      · d21207ae
      Dries Buytaert authored
      - Patch #8531 by drumm: took this date parser from MagpieRSS (conveniently GPL). The main benefit here is that timezones are handled properly (I have been noticing increasing complaints about that). I tested with a few feeds of different time formats and time zones and everything appeared correctly in my site's local time. Making this another function adds the benefit of parsability by other RSS (or other contexts) and RSS extension handling functions, where the W3C DTF is recomended.
  5. 25 Jul, 2004 8 commits
    • Steven Wittens's avatar
      CSS improvements: · ad5e3ebb
      Steven Wittens authored
      - Restoring background coloring for the watchdog logs (was broken)
      - Making watchdog backgrounds lighter, makes it easier on the eyes and improves readability.
      - Adjusted the spacing between items on the frontpage a bit to be clearer.
      - Fixed the vertical stretching of table rows with form controls in them.
    • Steven Wittens's avatar
    • Dries Buytaert's avatar
      · f2ac51dc
      Dries Buytaert authored
      - Patch #9346 by drumm: improved themability of some aggregator pages.
    • Dries Buytaert's avatar
      · f4460da9
      Dries Buytaert authored
      - Patch 9543 by JonBob: use drupal_goto() in menu administration.
    • Dries Buytaert's avatar
      · 2af5dff6
      Dries Buytaert authored
      - Patch #9464 by Moshe: menu.module omitted a pair of braces when calling
    • Dries Buytaert's avatar
    • Dries Buytaert's avatar
      · 702a0576
      Dries Buytaert authored
      - Patch #9478 by JonBob: allow printf-style arguments in pager_query.
        Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature.
        This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
    • Dries Buytaert's avatar
  6. 23 Jul, 2004 1 commit
  7. 22 Jul, 2004 3 commits
  8. 21 Jul, 2004 3 commits
  9. 16 Jul, 2004 1 commit
    • Dries Buytaert's avatar
      · 2a538a39
      Dries Buytaert authored
      - Patch by Andy: improved help text / module description.
  10. 15 Jul, 2004 2 commits
    • Dries Buytaert's avatar
      · 8aa052dc
      Dries Buytaert authored
      - Patch #9177 by James: fixed distributed authentication.
    • Dries Buytaert's avatar
      · 7765fa1f
      Dries Buytaert authored
      - Patch #9290 by Morbus / JonBob / TDobes: SUBTASK removal patch for menu.inc.
  11. 14 Jul, 2004 5 commits
  12. 13 Jul, 2004 8 commits
    • Dries Buytaert's avatar
      · 1c52b145
      Dries Buytaert authored
      - Patch #8080 by TDobes: added teaser support to the book and page module.
    • Dries Buytaert's avatar
      · 739bb8a8
      Dries Buytaert authored
      - Patch #9261 by drumm: made the aggregator overview tables more consistent by adding a items column to the categories table which acts like the same column in the feeds table.
    • Dries Buytaert's avatar
      · 2c9b5e31
      Dries Buytaert authored
      - Patch #9234 by TDobes: the latest menu changes have caused custom menu blocks not to render any output. If I create a new menu and menu items, and then enable the block, no output from that block is visible.
      This commit fixes the problem: custom menus were being defined as MENU_CUSTOM_ITEM rather than MENU_CUSTOM_MENU.  It also fixes a problem in which custom menus were mistakenly given the MENU_VISIBLE_IN_BREADCRUMB bit when edited. This would cause their titles to show up in the breadcrumb (which is undesirable... only menu items should be in there).
      Note that this will not fix any non-functioning custom menus you've defined since this bug appeared. You'll have to delete and recreate them or update the "type" column in the DB manually.
    • Dries Buytaert's avatar
      · dbd1c4f1
      Dries Buytaert authored
      - Patch #9253 by Morbus: fixed bug that manifested itself with a duplicate page when a user has submitted a comment that goes into the moderation queue. Part of the problem seemed to be that the "your comment is in the moderation queue" message was set as a theme print, as opposed to a drupal_set_message().  This patch fixes that, as well as adding a drupal_goto() to redirect the user back to where they came.
    • Dries Buytaert's avatar
      · df2e5ef5
      Dries Buytaert authored
      - Patch #8942 by Morbus: when testing under devel.module, the "SELECT timestamp from {history}" SQL statement is executed multiple times in two different functions. This duplicated code should be placed in a function, and that's been done already with node_last_visited() - the remaining code was just never updated to use the new routine. This patch changes the old code to use node_last_visited, and also modifies node_last_visited() to cache the result of the database call.
    • Dries Buytaert's avatar
      · 3613729d
      Dries Buytaert authored
      - Patch #8398 by TDobes: changed permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents.  In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch.
      Changes are as follows:
      "maintain personal blog" -> "edit own blog" (aggregator.module, blog.module, blogapi.module)
      "maintain personal pages" -> "edit own pages" (page.module)
      "maintain personal stories" -> "edit own stories (story.module)
    • Dries Buytaert's avatar
      · 50d78e98
      Dries Buytaert authored
      - Patch #9238 by JonBob: added code and Doxygen comments to common.inc and
    • Dries Buytaert's avatar
      - Small code simplifications. · 6477705f
      Dries Buytaert authored
      - Small usability improvement thanks to using drupal_goto() after deleting an
  13. 12 Jul, 2004 3 commits