1. 23 Aug, 2004 1 commit
  2. 22 Aug, 2004 1 commit
  3. 21 Aug, 2004 2 commits
    • Dries's avatar
      · 8b8a2bd6
      Dries authored
      - Patch #10187 by JonBob: bugfix: added missing permission check.
      8b8a2bd6
    • Dries's avatar
      · 94e30bf7
      Dries authored
      - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
      94e30bf7
  4. 19 Aug, 2004 1 commit
    • Dries's avatar
      · fa25c7a0
      Dries authored
      - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions).
      fa25c7a0
  5. 18 Aug, 2004 1 commit
    • Dries's avatar
      · 83a739bd
      Dries authored
      - Code improvements by Stefan: made all status messages consistent (and easier to translate).
      83a739bd
  6. 17 Aug, 2004 1 commit
    • Dries's avatar
      · 78b052a6
      Dries authored
      - The upload (filehandler) module has landed!
      78b052a6
  7. 16 Aug, 2004 3 commits
    • Dries's avatar
      · 451821ab
      Dries authored
      - Patch #10110 by JonBob: code improvement: looks like we have an artifact from before clean URLs in node.module. This patch removes the global variable $mod, which is no longer set and not necessary here anyway.
      451821ab
    • Dries's avatar
      · 2f33b939
      Dries authored
      - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter.
      2f33b939
    • Dries's avatar
      · ef07dd08
      Dries authored
      - Patch #10102 by Gerhard: removing some cruft from the node module!
      ef07dd08
  8. 14 Aug, 2004 1 commit
  9. 13 Aug, 2004 1 commit
  10. 12 Aug, 2004 2 commits
  11. 11 Aug, 2004 1 commit
    • Dries's avatar
      · 1831e1b6
      Dries authored
      - New locale module thanks to Gerhard, Goba, Marco, Kristjan and others.
      
        The new locale module provides every functionality on the web interface, so you don't need to edit the configuration files or add columns, when you add a new language. This module is an integration of the old locale and localegettext modules, plus a bunch of logic to parse Gettext Portable Object files (opposed to Machine Object files, as supported by localegettext).
      
        Note: I made some minor changes to the context-sensitive help texts and to some of the status messages.
      1831e1b6
  12. 10 Aug, 2004 1 commit
    • Steven Wittens's avatar
      The Input formats - filter patch has landed. I still need to make update... · 660f9928
      Steven Wittens authored
      The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
      
      Here's an overview of the changes:
      1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
      The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.
      
      The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.
      
      2) Filters have toggles
      Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.
      
      3) Multiple filters per module
      This was necessary to accomodate the next change, and it's also a logical extension of the filter system.
      
      4) Embedded PHP is now a filter
      Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
      This change means that block.module now passes custom block contents through the filter system.
      As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.
      
      5) User-supplied PHP code now requires <?php ?> tags.
      This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.
      
      Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.
      
      6) Filter caching was added.
      Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.
      
      7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.
      
      8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
      660f9928
  13. 06 Aug, 2004 1 commit
    • Dries's avatar
      · 821c6d2d
      Dries authored
      - Patch #9812 by Adrian: fixed some PostgreSQL/ANSI SQL compabitibility
        problems created by the new comment and node access permissions code.
      821c6d2d
  14. 05 Aug, 2004 2 commits
    • Dries's avatar
      · b47e4e16
      Dries authored
      - Patch #9794 by JonBob: a bug introduced late in the review process makes individual node views inaccessible to users who should have permission. This does not affect node listings, so was missed.
      b47e4e16
    • Dries's avatar
      · c6b1eaa2
      Dries authored
      - Patch #9775 by TDobes: consistency operation.  Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view".
      c6b1eaa2
  15. 04 Aug, 2004 1 commit
    • Dries's avatar
      · 07ae0fad
      Dries authored
      - Patch #9497 by gordon: made <!--break--> work even when the teaser length
        is set to unlimited and fixed up some code comments.
      07ae0fad
  16. 03 Aug, 2004 1 commit
    • Dries's avatar
      · c0f6fcca
      Dries authored
      - Patch #7336 by TDobes: in various parts of Drupal, we use the title attribute for links to provide a slightly more detailed explanation as to the purpose of a link or where it goes.
      c0f6fcca
  17. 31 Jul, 2004 1 commit
    • Dries's avatar
      · 202eee42
      Dries authored
      - Patch #9543 by JonBob: added node-level access control!
      202eee42
  18. 30 Jul, 2004 1 commit
    • Dries's avatar
      · aed1b0ca
      Dries authored
      - Patch #5347 by JonBob:
      
      Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:
      
      Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.
      
      Advantages of this refactoring:
      - I can use it for book.module to remove the extra viewing path.
      - The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
      - We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
      - The attachment.module people could use it to append their attachments in a list after the node.
      - Gabor could use it instead of his filter perversion for his "articles in a series" module.
      - A little less code in each view hook.
      - The content hook is no longer needed, so that means even less code.
      
      Disadvantages:
      - Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
      - Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).
      
      Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
      aed1b0ca
  19. 13 Jul, 2004 1 commit
    • Dries's avatar
      · df2e5ef5
      Dries authored
      - Patch #8942 by Morbus: when testing under devel.module, the "SELECT timestamp from {history}" SQL statement is executed multiple times in two different functions. This duplicated code should be placed in a function, and that's been done already with node_last_visited() - the remaining code was just never updated to use the new routine. This patch changes the old code to use node_last_visited, and also modifies node_last_visited() to cache the result of the database call.
      df2e5ef5
  20. 10 Jul, 2004 1 commit
    • Dries's avatar
      · ac5b5616
      Dries authored
      - More tab-improvements by JonBob: improved support for the default tabs!
      ac5b5616
  21. 08 Jul, 2004 1 commit
    • Dries's avatar
      · 898bdeff
      Dries authored
      - Marked required fields on the node (story, book, page, blog) and comment
        forms using the $required argument of the form_ functions.
      
      - Replaced all Optional's and Required's from the taxonomy forms with proper
        use of the form_ functions.
      
      Please check your contributed modules too!
      898bdeff
  22. 04 Jul, 2004 3 commits
    • Steven Wittens's avatar
      - Added revisions tab to node view (when needed) · d615cb24
      Steven Wittens authored
      - Updated node.module to use drupal_goto after submission: this allows people to refresh after submission without any problems.
      d615cb24
    • Dries's avatar
      · fe2b3e7c
      Dries authored
      - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
      
          * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
      
          * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
      fe2b3e7c
    • Dries's avatar
      · 353c05d0
      Dries authored
      - Made it possible to edit blog posts and made the blog module use tabs.
      353c05d0
  23. 02 Jul, 2004 1 commit
    • Dries's avatar
      · 9986cb36
      Dries authored
      - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).
      9986cb36
  24. 22 Jun, 2004 1 commit
    • Dries's avatar
      · e288b4dd
      Dries authored
      - Patch #8747 by JonBob: extended and standardized node.module Doxygen
        comments, and made formatting and quote usage more consistent.
      e288b4dd
  25. 21 Jun, 2004 2 commits
  26. 20 Jun, 2004 2 commits
  27. 19 Jun, 2004 2 commits
  28. 18 Jun, 2004 1 commit
    • Dries's avatar
      · 54b77d64
      Dries authored
      Tabs patch!
      
      CHANGES
      -------
      
       + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
      
       + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
      
       + Grouped settings. All settings have been grouped under 'administer > settings'.
      
      TODO
      ----
      
       + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.
      
       + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
      54b77d64
  29. 17 Jun, 2004 1 commit
  30. 10 Jun, 2004 1 commit